How to eliminate the repeated char in two strings

Question

0.00/5 (No votes)

See more:

Hi Experts..

I want to eliminate the repeated strings in Two strings.
For Example If i give
First string ==> vijayadhas
Second string ==> nasrya

The out put should be vijdha nr

First String ==> arun prasath
Second String ==> ramya

The output should be ==> unprsath my

I try this code. But it is not working perfect

//string s1 = "vijayadhas";
//string s2 = "nasrya";
string s1 = "arunprasath";
string s2 = "ramya";
ArrayList name1 = new ArrayList();
ArrayList name2 = new ArrayList();

for (int i = 0; i < s1.Length; i++)
{
name1.Add(s1[i]);
}

for (int i = 0; i < s2.Length; i++)
{
name2.Add(s2[i]);
}

for (int i = 0; i < name1.Count; i++)
{
for (int j = 0; j < name2.Count; j++)
{
if (s1[i] == s2[j])
{
name1.RemoveAt(i);
name2.RemoveAt(j);
}
}
}

int len = name1.Count + name2.Count;
Console.WriteLine("Length of the remaing Chars==>"+len);

Console.WriteLine("\n\n Name 1==>");
for (int i = 0; i < name1.Count; i++)
{
Console.Write(name1[i]);
}
Console.WriteLine("\n\n Name 2==>");
for (int i = 0; i < name2.Count; i++)
{
Console.Write(name2[i]);
}

The out put for this program is ==> rnpraah y

Where i have to change to get the correct output?
Please help me.

Posted 7-Dec-13 3:41am

Vijaydhas

Add a Solution

2 solutions

Solution 1

C#

string s1 = "arunprasath";
string s2 = "ramya";
string result;

for (int xIx = 0; xIx < s1.Length; xIx++)
{
    for (int xKx= 0; xKx < s2.Length; xKx++)
    {
        if (s1[xIx] == s2[xKx])
        {
            s1= s1.Remove(xIx--, 1);
            // One -- to mutch
            // s2= s2.Remove(xKx--, 1);
            s2= s2.Remove(xKIx, 1);
            break;
        }
    }
}
result = s1 + " " + s2;

Posted 7-Dec-13 4:11am

idle63

Updated 7-Dec-13 5:59am

v6

Comments

[no name] 7-Dec-13 11:01am

Thank you for accepting.
Please note also the comments/details on OriginalGriff solution. He is very right about efficiency.

Vijaydhas 7-Dec-13 11:10am

Thank you.. It's Working and easy to understand. Thanks..

BillWoodruff 7-Dec-13 23:45pm

Your answer is upvoted: good work ! But ... mmm ... I actually tested OriginalGriff's original solution ... the one using nested for loops and decrementing both loop counter variables in-line ... and it appeared to give the desired result on both examples supplied by the OP. Care to describe what you changed in detail ? thanks, Bill

[no name] 8-Dec-13 6:06am

Thank you for voting. You can see what I changed, it is only this outcommented line where I replaced xK-- by xK which has no effect because of the following break.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2013-12-07T04:15:00

I';m not sure why you think you need nested loops - all you need to do is look and see if there is a specific character in the string already.
Here is what I'd do:

C#

private string RemoveThese(string input, string remove)
    {
    foreach (char c in remove)
        {
        int found = input.IndexOf(c);
        if (found >= 0) input = input.Remove(found, 1);
        }
    return input;
    }

What it does is finds and removes all the characters in the remove string by checking if the IndexOf (which finds the first time it matches) is valid, and removing the character if it is.
All you then have to do is call the method twice:

C#

string output = RemoveThese(name1, name2) + RemoveThese(name2, name1);

(As it happens, that isn't the way I'd do it - it is horribly inefficient since it creates new strings left right and centre, since strings are immutable - but since I suspect you haven't got to the StringBuilder class yet, I didn't want to confuse you)