how to solve error of converting datatype varchar to numeric

Question

2.20/5 (3 votes)

See more:

(when i am trying to run this code it is giving an error near da.Fill(dth) that error converting data type varchar to numeric)

C#

public partial class ministatement : Form
{
    SqlConnection connect = new SqlConnection(@"data source=ABHINAV-PC\ABHI;integrated security=true;initial catalog=ATM;");

   public ministatement()
   {
       InitializeComponent();
   }

    private void ministatement_Load(object sender, EventArgs e)
    {

         connect.Open();
SqlCommand cmd = new SqlCommand("select * from transactions where account_no='" + label4.Text +"'" , connect);
        DataTable dth = new DataTable();
        SqlDataAdapter da = new SqlDataAdapter(cmd);
        da.Fill(dth);
        dataGridView1.DataSource = dth;
    }
}
}

Posted 13-Mar-14 3:20am

Abhinav Chaudhary

Updated 13-Mar-14 3:49am

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ)

v2

Add a Solution

Comments

Siva Hyderabad 13-Mar-14 9:27am

try this
SqlCommand cmd = new SqlCommand("select * from transactions where account_no='" +Convert.ToInt32( label4.Text) +"'" , connect);

Abhinav Chaudhary 13-Mar-14 9:38am

sir,i've tried this...but it is saying that the statement is not in proper format...
actually the label4 which i have included is passing value of another label in another form...

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) · Answer 1 · 2014-03-13T04:21:00

Solution 2

Use Parameterized query instead.

C#

SqlCommand cmd = new SqlCommand("select * from transactions where account_no=@AccountNo" , connect);

cmd.Parameters.Add(new SqlParameter("AccountNo", label4.Text))

Posted 13-Mar-14 4:21am

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ)

Raul Iloc · Answer 2 · 2014-03-13T03:42:00

Solution 1

You error seems to be the usage of ' '. If your DB filed is numeric you should use the value without ' ' like in the next example:

C#

SqlCommand cmd = new SqlCommand("select * from transactions where account_no=" + label4.Text, connect);

Better is to get your value from UI element (in your case label.Text), then use it in the SQlCommand:

C#

SqlCommand cmd = new SqlCommand(string.Format("select * from transactions where account_no={0}", yourValue), connect);

Posted 13-Mar-14 3:42am

Raul Iloc

Updated 13-Mar-14 3:54am

v2

Comments

Abhinav Chaudhary 13-Mar-14 9:48am

yes sir,but because of this it is only reading label4 as text not the value of label4....what should i do for that?

Raul Iloc 13-Mar-14 9:54am

See my update. You have a problem with your SQL and I gave you the solution!

Abhinav Chaudhary 13-Mar-14 10:10am

sir,what if the value of label4 is coming from another form...in my case this is the problem...what should i do for that?

Raul Iloc 14-Mar-14 2:13am

You should get the value from that form into a variable (should be int but could be also string if you have validation in the UI)and send it as a parameter to your method where the SQL is build.

Abhinav Chaudhary 14-Mar-14 2:34am

Sir,it is solved....i just written the code into the button event...thats it...