how to implement the if condition for the below code.

Question

1.00/5 (2 votes)

See more:

Hi Team,
I have the code which is working.In my code there are if condition is available ,I want to implement one more If condition in exiting if condition.My Condition is as follows:

I am reading the values from excel sheet .In excel there are number of rows and columns.I have CellId,route ,place,mobilenumber ..and so on as a column name in my excel file.
for example: In Cellid column, value are 123 ,other columns are having some value related to particular record for one row
for second row,In CellID column,value are 123 but other column are null.So in this senario,I want to check the record if same number of cellid exsist then read the record in which value are present in columns not to read the value in which cellid is present but other columns are null. How can i implement this in if condition.Please guide me.

C#

public IEntityCollectionBase GetZteBbhRecords(IEntityBase xmlConfiguration)
{
   IDataReader dataReader = null;
   ExcelDataAccess excelDataAccess = null;
   IEntityCollectionBase zteBbhRecords = Kaizen2GEntityCreator.GetZteBbhEntityCollection();
   try
   {
      IXmlConfiguration xmlConfig = xmlConfiguration as IXmlConfiguration;
      Logger.Write("Inside ZteBbhDataManager.GetZteBbhRecords()", xmlConfig.LogTypeInfo);
      excelDataAccess = CommonDataManager.GetDataAccess(xmlConfig);
      dataReader = excelDataAccess.ExecuteReader();
      IZteBbh zteBbhEntity = null;
      while (dataReader.Read())
      {
         zteBbhEntity = Kaizen2GEntityCreator.GetZteBbhEntity();
         zteBbhEntity = CommonDataManager.GetEntityFromExcelRow(dataReader, xmlConfig, zteBbhEntity) as IZteBbh;
         if (zteBbhEntity != null)
         {
            if ((zteBbhEntity.CombinedMaster as ICombinedMaster).CellId > 0)
            {
               if ((zteBbhEntity.CombinedMaster as ICombinedMaster).Circle.Trim().ToUpper() == "ROTN")
               {
                  (zteBbhEntity.CombinedMaster as ICombinedMaster).Circle = "ROTN-ZTE";
               }
               else if ((zteBbhEntity.CombinedMaster as ICombinedMaster).Circle.Trim().ToUpper() == "AP")
               {
                  (zteBbhEntity.CombinedMaster as ICombinedMaster).Circle = "AP-ZTE";
               }
 
               zteBbhEntity.FileLogId = xmlConfig.FileLogId;
               zteBbhEntity.HandOverSuccessRate = zteBbhEntity.HandOverSuccessRate * 100;
               zteBbhEntity.HandOverFailureRate = zteBbhEntity.HandOverFailureRate * 100;
               zteBbhEntity.RandomAccessSuccessRate = zteBbhEntity.RandomAccessSuccessRate * 100;
               zteBbhEntity.TbfSuccessRateUl = zteBbhEntity.TbfSuccessRateUl * 100;
               zteBbhEntity.TbfSuccessRateDl = zteBbhEntity.TbfSuccessRateDl * 100;
               zteBbhRecords.Add(zteBbhEntity);
            }
         }
      }
 
      Logger.Write("Exiting ZteBbhDataManager.GetZteBbhRecords()", xmlConfig.LogTypeInfo);
   }
   catch (Exception exception)
   {
      throw exception;
   }
   finally
   {
      dataReader.CloseDataReader();
      excelDataAccess.CloseConnection();
   }
 
   return zteBbhRecords;
}

indenting reduced

Posted 14-May-14 21:22pm

R Harshal

Updated 15-May-14 10:42am

Nelek

v3

Add a Solution

Comments

R Harshal 15-May-14 5:03am

Is anyone can help me.

Thanks
Harshal

R Harshal 15-May-14 5:21am

In Simple words if i have two records with same CellId then i want to read only the cellID which contains value in other columns as there are number of columns
with cellID,if value is not present in other column then neglect that record.how to implement this in if condition.
Thanks
Harshal

R Harshal 15-May-14 6:33am

In other words,if we found the two record with same cellID then read the cellid record in which other
columns are not null,dont consider the record in which other columns are null.
as simple as that.this I want to implement in my IF Condition.Please anyone can guide me.
very thanks
Harshal

R Harshal 15-May-14 6:58am

i will make it more easier to understand 
it has 5 columns say (CellID, A1, A2, B1, B2) If CellID is 1 ,then i want to read the value for CellId 
in which other columns are not null. Secondily,no 2 rows will have same CellID but no value in other columns.In this senario,I want to read the value in which 
other column values are not null , even though cellId are same ,Ignore the cellid in which other columns are null . 
this what i want to perform in If condition.I hope everyone can understand what i Required. 
CellID| A1 | A2 | B1 | B2 | 
-------------------------- 
1 | 123 | XY | | | 
1 | | | | | 

In first Row, CellID = 1,A1 = 123,A2 = XY
In Second Row,CellID = 1,A1 = null,A2 = null
Thanks 
Harshal

Matt T Heffron 15-May-14 17:02pm

What if the two rows were in the other order?
How do you expect to know when you read the first CellID==1 row that another row exists that has non-null values, and so this shouldn't be processed, but the other one should?
What if you have two rows with the same CellID but one row has values for A1, A2 with B1, B2 null AND the other row has A1,A2 null and B1, B2 with values?
It seems that the only thing you can do is, for each CellID found, keep a copy of the associated row and then if another row with the same CellID is found, then compare the presence/absence of values and keep the "correct" one. Finally, at the end, then process the "kept" rows.

R Harshal 16-May-14 2:59am

yes you are absolutely right .please can you guide me in my code .it will helpful to me .

Thanks
Harshal

Matt T Heffron 16-May-14 12:51pm

First, you need to COMPLETELY define WHAT you want the behavior to be.
You have a decent start with the statements above.
Now define what should happen with the "edge cases" like I pointed out.
Think carefully about any other conditions with special behavior.
Write them all down (so you have a checklist you can verify against).
These are your requirements.
At this point you can start to work out HOW to accomplish these.
If you need to change the way you work through the data, perhaps as I suggested above, then walk through the process manually (on paper?) with some hypothetical data that covers all of the cases in the requirements. (You shouldn't code this yet, you're just checking the strategy. Writing out a simple data table as you have above is fine!)
Once you have determined the strategy, then code it. It should be pretty straight forward at this point.
Now test the code!

R Harshal 15-May-14 7:14am

I want to use for loop and get one item at a time compare it with all other
items in next for loop for same CellId....as will get it match with any other just break from the loop and return the value in which columns are not null

2 solutions

Solution 1

I'd suggest to use ADO.NET (OLEDB), which enables to use SQL queries to insert, update and delete Excel data. Have a look here: Accessing Microsoft Office Data from .NET Applications[^].

Posted 15-May-14 8:29am

Maciej Los

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

idle63 · Accepted Answer · 2014-05-15T11:09:00

Solution 2

Maybe it is worth that you first get some knowledge about such simple boolean logics!
Sorry for that.....Downvotes expected!
Regards, Bruno

Posted 15-May-14 11:09am

idle63

Comments

Maciej Los 16-May-14 1:40am

Downvotes? No! +5!

[no name] 16-May-14 4:13am

Thank you Maciej. Rgeards, Bruno