How do I implement an error checking!

Question

0.00/5 (No votes)

See more:

Hi guys I have this app that does printing based on items on a listbox.
by commatching those items with that in a directory :\slim\slimyyyy
I want to put an "ERROR CHECKING" that would give me a message that in item
on the listbox is not present in the directory .
For instance if there are 8 items or more is not in the said directory give message with the item thats not in the directory.
Find below is my code ,but my try catch does nothing.Any help is very welcome
Thanks in advance.

C#

{
     //var printList = new List();
     try
     {
         var printList = new List();
         string dir = @"C:\slim\slimyyyy";
         if (Directory.Exists(dir))
         {
             string[] pdf_specFiles = Directory.GetFiles(dir);
             if (pdf_specFiles.Length > 0)
             {
                 foreach (object item in listBox1.Items)
                 {
                     foreach (string file in pdf_specFiles)
                     {
                         string fileName = Path.GetFileName(file);
                         if (fileName == item.ToString())
                         {
                             printList.Add(Path.GetFullPath(file));
                         }
                     }
                 }
                 foreach (string file in printList)
                 {
                     PrintDocument(file);
                     System.Threading.Thread.Sleep(10000); // wait 10 second say
                     Application.DoEvents(); // keep UI responsive if Windows Forms app
                 }
             }
         }
     }
     catch (Exception)
     {
         MessageBox.Show("You are missing Item(s).", "ERROR");
     }
 }>

Posted 6-Mar-15 7:05am

Ekona_Pikin

Add a Solution

2 solutions

Solution 2

Without seeing your PrintDocument code, we can't tell if your code will even throw an exception when a file doesn't exist - this could be why this does nothing...

Rather than relying on exceptions to tell you what is going on, I would prefer to explicitly check for the existence of the file in the code, and not issue the PrintDocument request in the first place.

C#

foreach (string file in printList)
{
    if (File.Exists(file))
    {
        PrintDocument(file);
        System.Threading.Thread.Sleep(10000); // wait 10 second say
        Application.DoEvents(); // keep UI responsive if Windows Forms app
    }
    else
        ...
}

And why are you using Sleep and DoEvents in the loop anyway?
If you need to do DoEvents to maintain your UI, then you should have moved all this code onto a background thread to keep your UI clear - which means you don;t need DoEvents at all; and using Sleep on your UI thread for ten seconds is just going to mean that your UI thread stops and becomes unresponsive...

Posted 6-Mar-15 8:22am

OriginalGriff

Comments

Ekona_Pikin 6-Mar-15 15:12pm

Hey thanks OriginalGriff,but I used the solution above it was just what I wanted

BillWoodruff 6-Mar-15 19:27pm

+5 ridiculous down-votes countered.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Ramza360 · Accepted Answer · 2015-03-06T08:20:00

Hello again Ekona, This would be quite simple, well depending on how you want them to be notified.

C#

----- inside method
if (pdf_specFiles.Length > 0) {
    // Only partial code from your solution above.
    bool itemFound = false;
    foreach (object item in listBox1.Items)
    {
        foreach (string file in pdf_specFiles)
        {
            string fileName = Path.GetFileName(file);
            if (fileName == item.ToString())
            {
                printList.Add(Path.GetFullPath(file));
                itemFound = true;
            }
        }
    
        // Send an message for every item unless you want to send one large out put message.
        if (!itemFound) {
            OutputErrorMessage(item.ToString());
        }
    }
}
---- outside method
    
void OutputErrorMessage(string message) {
    MessageBox.Show(message);
}

Keep in mind that would output an error message for each missing file.
This may not be so good, perhaps send one message for all missing files at the end.
You can use a string and keep += to it, though this is not an efficient way if there are many missing files. The alternative is using a StringBuilder.

C#

----- Inside the method
if (pdf_specFiles.Length > 0) {
    // Only partial code from your solution above.
    StringBuilder builder = new StringBuilder();
    
    // The flag
    bool itemFound = false;
    
    foreach (object item in listBox1.Items)
    {
        foreach (string file in pdf_specFiles)
        {
            string fileName = Path.GetFileName(file);
            if (fileName == item.ToString())
            {
                printList.Add(Path.GetFullPath(file));
                itemFound = true;
            }
        }
        
        // Add the item to the list of missing items.
        if (!itemFound) {
            // Append to the builder
            if (builder.Length == 0) {
                builder.AppendLine("Missing Files");
            }
            builder.AppendLine(item.ToString());
        }
    }
    foreach (string file in printList)
    {
        PrintDocument(file);
        System.Threading.Thread.Sleep(10000); // wait 10 second say
        Application.DoEvents(); // keep UI responsive if Windows Forms app
    }
    
    if (builder.Length > 0) {
        OutputErrorMessage(builder.ToString());
    }
}

------- Outside the method

public void OutputErrorMessage(string messages) {
    MessageBox.Show(messages, "You are missing files");
}