How to solve the best overloaded method match for has some invalid arguments dataset

Question

0.00/5 (No votes)

See more:

I work with data set and I did every thing correctly, the fields as the Database fields

but always this message appears to me:

Compilation Error

Description: An error occurred during the compilation of a resource required to service this request. Please review the following specific error details and modify your source code appropriately.

Compiler Error Message: CS1502: The best overloaded method match for 'KutubDataSetTableAdapters.BooksTableAdapter.InsertBook(string, string, decimal?, int?, int?, ref int?)' has some invalid arguments

C#

 int InsertBook(string BookName, string Description, int Price, int Publisher, int Category, int PublishDate)
    {

        KutubDataSetTableAdapters.BooksTableAdapter Bta = new KutubDataSetTableAdapters.BooksTableAdapter();

        return Bta.InsertBook(BookName, Description, Price, Publisher, Category, PublishDate);}
}

I tried to use this:

C#

int InsertBook(string BookName, string Description, decumal? Price, int? Publisher, int? Category,ref int? PublishDate)

And it didn't success..

Posted 22-May-15 6:22am

Y.Ahmad

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Answer 1 · 2015-05-22T07:33:00

Solution 1

You need to specify the ref modifier when you pass the parameter in, but you don't re-state the argument types.

Also, arguments passed as ref or out must match the declared type exactly. You can't pass a ref int to a ref int? parameter, so you'll to use need a temporary local variable.

Try this:

C#

int? thePublishDate = PublishDate;
return Bta.InsertBook(BookName, Description, Price, Publisher, Category, ref thePublishDate);

Posted 22-May-15 7:33am

Richard Deeming

Comments

Y.Ahmad 22-May-15 13:57pm

Yes, there's output parameter, but if I wrote this:

return Bta.InsertBook(BookName, Descpn, Price, Publisher, Category, PublishDate,ref BookID);

This error will appear!

CS1501: No overload for method 'InsertBook' takes 7 arguments

Richard Deeming 22-May-15 13:59pm

And why do you think that is?

The signature you posted in the question has six arguments. The code you've just posted is trying to pass seven arguments.

Y.Ahmad 22-May-15 14:05pm

Because Publishdate isn't nullable, and isn't output!

Richard Deeming 22-May-15 14:07pm

No; because you can't pass seven arguments to a function which only accepts six arguments!

Y.Ahmad 22-May-15 14:06pm

This's my procedure

CREATE procedure InsertBook

@BookName nvarchar(50) ,
@Description nvarchar(500),
@Price int,
@Publisher int,
@Category int,
@PublishDate int,

@BookID int Output
AS
INSERT INTO Books
VALUES (@BookName,@Description,@Price,@Publisher ,@Category,@PublishDate);
set @BookID=@@Identity

Richard Deeming 22-May-15 14:08pm

Your stored procedure is irrelevant. You're getting the error from the C# compiler, because you're trying to pass too many arguments to a C# method.

Y.Ahmad 22-May-15 14:11pm

I know this, but if I put just 6 arguments, without the output parameter, like this:
return Bta.InsertBook(BookName, Description, Price, Publisher, Category, PublishDate);

This message will appear!

Compiler Error Message: CS1502: The best overloaded method match for 'KutubDataSetTableAdapters.BooksTableAdapter.InsertBook(string, string, decimal?, int?, int?, ref int?)' has some invalid arguments

Richard Deeming 22-May-15 14:14pm

Because you have to specify the ref modifier when you pass a value to a ref parameter, and the type of the value you pass in has to be exactly the same as the type of the parameter!

The last parameter in that method is declared as ref int? - that means you need to pass an int? value to it (not an int), and you need to specify the ref modifier.

As I showed you in my answer, 40 minutes ago.

Y.Ahmad 22-May-15 14:23pm

I tried what you showed to me in your answer, 40 minutes age..

int? thePublishDate = PublishDate;
return Bta.InsertBook(BookName, Descpn, Price, Publisher, Category,ref thePublishDate);

In this case this error appears:

Compiler Error Message: CS0266: Cannot implicitly convert type 'object' to 'int'. An explicit conversion exists (are you missing a cast?)

Y.Ahmad 22-May-15 14:16pm

This's my table

CREATE TABLE [dbo].[Books] (
[BookID] INT IDENTITY (1, 1) NOT NULL,
[BookName] NVARCHAR (50) NOT NULL,
[Description] NVARCHAR (500) NOT NULL,
[Price] INT NOT NULL,
[Publisher] INT NOT NULL,
[Category] INT NOT NULL,
[PublishDate] INT NOT NULL,
CONSTRAINT [PK_Books] PRIMARY KEY CLUSTERED ([BookID] ASC),
CONSTRAINT [FK_Books_Categories] FOREIGN KEY ([Category]) REFERENCES [dbo].[Categories] ([CategoryID]) ON DELETE CASCADE ON UPDATE CASCADE,
CONSTRAINT [FK_Books_Publishers] FOREIGN KEY ([Publisher]) REFERENCES [dbo].[Publishers] ([PublisherID]) ON DELETE CASCADE ON UPDATE CASCADE
);

Richard Deeming 22-May-15 14:18pm

YOUR TABLE IS IRRELEVANT!!!!

The error messages you are getting are ABSOLUTELY NOTHING to do with your database, your stored procedure, or the price of cheese.

You CANNOT pass seven parameters to a method which only has six parameters.
You CANNOT pass an int to a ref int? parameter.

It's not rocket science!

Y.Ahmad 22-May-15 14:27pm

I just give you more info to help me!!! :\

Y.Ahmad 22-May-15 14:30pm

If I wrote this:

int? thePublishDate = PublishDate;
return Bta.InsertBook(BookName, Descpn, Price, Publisher, Category,ref thePublishDate);

This error will appear:

Cannot implicitly convert type 'object' to 'int'. An explicit conversion exists (are you missing a cast?)

Richard Deeming 22-May-15 14:37pm

Not from the code you've posted.

That error is probably occurring further up the stack - you're trying to pass an object to one of the int parameters.

This is a good sign - it means you've fixed the problem in your question, and now you have a different problem to solve.

Y.Ahmad 22-May-15 14:48pm

Thank you very much..
But as you saw in my procedure and table.. there's no any difference in types..

Richard Deeming 22-May-15 14:52pm

The different types are not in your stored procedure or table.

The difference is between the type of parameter in your InsertBook method - an int - and the type declared on the KutubDataSetTableAdapters.BooksTableAdapter.InsertBook method - an int?, also known as a Nullable<int>.

Normally, this wouldn't matter - you can pass an int variable to an int? parameter, because there is an implicit conversion.

However, when you're dealing with parameters declared as either ref or out, the type of the variable you pass in has to be exactly the same as the type of the parameter.

Again, this is in your C# code; it has nothing to do with your database.

Y.Ahmad 27-May-15 18:45pm

I saw this now..
Forget my statement, in instead.. Could you write a statement that could do an insert operation from this procedure, please?!

<pre>
CREATE procedure InsertBook

@BookName nvarchar(50) ,
@Description nvarchar(500),
@Price int,
@Publisher int,
@Category int,
@PublishDate int,

@BookID int Output
AS
INSERT INTO Books
VALUES (@BookName,@Description,@Price,@Publisher ,@Category,@PublishDate);
set @BookID=@@Identity
</pre>

Y.Ahmad 28-May-15 11:20am

I solved it.. thanks..

Y.Ahmad 22-May-15 14:51pm

Thanks for your time..

AnvilRanger · Answer 2 · 2015-05-22T07:43:00

Solution 2

Look at your variable Price in your outer procedure you are passing an int datatype but your other method is expecting a nullable decimal, decimal?. You cannot interchange an int for a nullable.

And the same logic applies to several of your other parameters, specifically the int and the int?. These are not the same data type.

http://stackoverflow.com/questions/6389437/explanation-of-int-vs-int[^]

Posted 22-May-15 7:43am

AnvilRanger

Comments

Y.Ahmad 22-May-15 14:02pm

There's no any nullable value, and the I defined price as int to know where's the wrong.. and I didn't success,

This's my procedure:

CREATE procedure InsertBook

@BookName nvarchar(50) ,
@Description nvarchar(500),
@Price int,
@Publisher int,
@Category int,
@PublishDate int,

@BookID int Output
AS
INSERT INTO Books
VALUES (@BookName,@Description,@Price,@Publisher ,@Category,@PublishDate);
set @BookID=@@Identity