Catch block does not catch the exception Why?

Question

1.00/5 (1 vote)

See more:

my code is....

C#

public static bool SaveChitGroupDetails(ChitGroup obj)
  {
  try
  {
   _dal = DataLayer.GetInstance();
   _dal.Sql = StoredProcedures.SaveChitGroupDetails;
  _dal.CommandType = CommandType.StoredProcedure;
  _dal.AddParameter("_grcode",obj.GrpCode, DbType.String,ParameterDirection.Input);
              _dal.AddParameter("_brid", obj.Brid, DbType.Int16, ParameterDirection.Input);
              _dal.AddParameter("_prdcode", obj.Prdcode, DbType.String, ParameterDirection.Input);
              _dal.AddParameter("_valuecode", obj.Valuecode, DbType.String, ParameterDirection.Input);
              _dal.AddParameter("_companychit", obj.Companychit, DbType.Boolean, ParameterDirection.Input);
              _dal.AddParameter("_series", obj.Series, DbType.String, ParameterDirection.Input);
              _dal.AddParameter("_status", obj.Status, DbType.String, ParameterDirection.Input);
              _dal.AddParameter("_bylawnumber", obj.Bylawnumber, DbType.String, ParameterDirection.Input);
              _dal.AddParameter("_registrationdate", obj.RegistrationDate, DbType.Date, ParameterDirection.Input);
              _dal.AddParameter("_commencedate", obj.CommenceDate, DbType.Date, ParameterDirection.Input);
              _dal.AddParameter("_terminatedate", obj.TerminateDate, DbType.Date, ParameterDirection.Input);
              _dal.AddParameter("_maxdiscount", obj.MaxDiscount, DbType.Int16, ParameterDirection.Input);
              _dal.AddParameter("_active", obj.Active, DbType.Boolean, ParameterDirection.Input);
              _dal.AddParameter("_userid",obj.Userid,DbType.String,ParameterDirection.Input);
              _dal.AddParameter("_amndmntdate", obj.AmendmentDate, DbType.Date, ParameterDirection.Input);
              _dal.AddParameter("_amndtrmntdate", obj.AmendTerminateDate, DbType.Date, ParameterDirection.Input);
              
int rtrnid = _dal.ExecuteNonQuery();
              return true;
          }
          
catch (Exception ex)
          {
              throw ex;
              return false;
          }
      
    finally
          {
              if (_dal.Connected)
                  _dal.Connection.Close();
              //return true;
          }
      }

Posted 11-Sep-15 23:40pm

User-11630313

Updated 11-Sep-15 23:42pm

v2

Add a Solution

Comments

Richard MacCutchan 12-Sep-15 5:49am

What exception do you expect it to catch?
You also have some rather bad code there:


int rtrnid = _dal.ExecuteNonQuery();
              return true;

You should not return true without checking the value of rtrnid.
And when you catch an exception you should do something with it rather than just throw it again.

User-11630313 12-Sep-15 5:55am

if in case database error occurred it does not go to catch block it directly go to final block and returns true..if i did any mistake pls explain clearly

Richard MacCutchan 12-Sep-15 6:22am

A database error does not necessarily produce an exception. Fix the parts of your code that are broken first, and add someting in your catch block to examine any exception that is thrown. You can then trap that with your debugger to see exactly what is happening.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2015-09-12T00:12:00

That code won't work: it (correctly) gives a warning that you are ignoring:

Unreachable code detected

This is because your method can never return false - the throw of the exception transfers control to the "closest" catch block immediately, without needing to return to the calling method directly.

Put a breakpoint in your method, and follow exactly what happens: when your database activity fails, execution will move to the catch block, and then leave the method without ever returning to where it was called from. It will not return true if an error occurs.

[edit]Typos[/edit]