Program freezes after some time

Question

0.00/5 (No votes)

See more:

Hello guys, I have been working on my university assignment that was to write a program to get the input of no of employees working in a company from user and then get the input of their salaries from user. The objective was to calculate the net salaries (subtracting the tax amount, explain in the coding below) and then finding the unlucky people who had higher salary but lower net salary, below is the coding I have written. Now, the problem is when I run the program, it runs fine and ask the no of employees from user, after I give number, it runs fine again and ask their salaries, after I have given salaries then it does not do anything and just freezes and the dash keep blinking. Please help me out, what is the problem? This is the coding:

C++

#include <iostream>
using namespace std;

void getInput(double [][2], int);
void calcSal(double [][2], int);
void locUnLucky (double [][2], int [], int);
void displayOutput (double [][2], int [], int);

int main()
{
	const int arraySize= 100;
	int totalEmps;
	int lucky[] = {0};
	double sal[arraySize][2];
	
	cout << "Please enter the total number of employees working in your company: ";
	cin >> totalEmps;

	getInput(sal, totalEmps);
	
	calcSal(sal, totalEmps);
	
	locUnLucky(sal, lucky, totalEmps);
	
	displayOutput(sal, lucky, totalEmps);
	
}

void getInput(double sal[][2], int totalEmps)
{
    for (int i = 0; i < totalEmps; i++)
    {
        cout << "Please enter the gross salary in dollars for employee #" << i << ": ";
        cin >> sal[i][0];
    }
}

void calcSal(double sal[][2], int totalEmps)
{
	for (int i = 0; i < totalEmps; i++)
	{
		if (sal[i][0] <= 5000)
		{
			// no tax deduction
			sal[i][1] = sal[i][0];
		}
		
		else
		{
			if(sal[i][0] <= 10000)
			{
				// 5% tax deduction
				sal[i][1] = sal[i][0] - (0.05 * sal[i][0]);
			}
			
			else
			{
				if(sal[i][0] <= 20000)
				{
					// 10% tax deduction
					sal[i][1] = sal[i][0] - (0.1 * sal[i][0]);
				}
				
				else
				{
					// 15% tax deduction
					sal[i][1] = sal[i][0] - (0.15 * sal[i][0]);
				}
			}
		}
	}
}

void locUnLucky (double sal[][2], int lucky[], int totalEmps)
{
	int i, j, grossSalary, netSalary;
	
	for (i = 0; i < totalEmps; i++)
	{
		grossSalary = sal[i][0];
		netSalary = sal[i][1];
		
		for (j = 0; i < totalEmps; j++)
		{
			if(grossSalary > sal[i][0] && netSalary < sal[i][1])
			{
				lucky[i] = 1;
			}
		}
	}
}

void displayOutput (double sal[][2], int lucky[], int totalEmps)
{
	for (int i = 0; i < totalEmps; i++)
	{
		if (lucky[i] == 1)
		{
			cout << "Enmployee #" << i+1 << " is unlucky with $" << sal[i][0] << " as gross salary whereas $" << sal[i][1] << "as net salary" << endl;
		}
	}
}

What I have tried:

As I can't understand that what the problem could be, I have not tried anything

Posted 3-Dec-16 8:06am

Khubaib Khawar

Updated 3-Dec-16 10:23am

Add a Solution

Comments

RedDk 3-Dec-16 14:52pm

The program looks very logical but just glancing at the basic nature would be a lot easier if there were some breakpoints set (pick a couple) and the whole thing was run through the debugger.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Accepted Answer · 2016-12-03T08:50:00

You should learn to use the debugger as soon as possible. Rather than guessing what your code is doing, It is time to see your code executing and ensuring that it does what you expect.

The debugger allow you to follow the execution line by line, inspect variables and you will see that there is a point where it stop doing what you expect.
Debugger - Wikipedia, the free encyclopedia[^]
Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]

The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't find bugs, it just help you to. When the code don't do what is expected, you are close to a bug.

CPallini · Accepted Answer · 2016-12-03T10:23:00

Using the debugger, as suggested by ppolymorphe I was able to spot the bug, your are messing with loop indices (i, j) in the locUnLucky function. It should be:

C++

void locUnLucky (double sal[][2], int lucky[], int totalEmps)
{
	int i, j;
	double grossSalary, netSalary;
	
	for (i = 0; i < totalEmps; i++)
	{
		grossSalary = sal[i][0];
		netSalary = sal[i][1];
		
		for (j = 0; j < totalEmps; j++)
		{
			if(grossSalary < sal[j][0] && netSalary > sal[i][1])
			{
				lucky[i] = 1;
			}
		}
	}
}

However, even with such a fix, your code has a logical flaw: you should compare each employee salary with the average salary, in order to get meaningful info.

Program freezes after some time

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0