May I know with this code where will the files be stored to? and is the logging code workable?

Question

0.00/5 (No votes)

See more:

May I know with this code where will the files be stored to? and is the logging code workable? Thanks for your help:)

public void log(String message)
{

    String oFileName = "Log_" + datetime.ToString("dd-MM-yyyy_hh-mm-ss") + ".txt";
    if (!File.Exists(oFileName))
    {
        System.IO.FileStream f = File.Create(oFileName);
        f.Close();
    }

    try
    {
        System.IO.StreamWriter writter = File.AppendText(oFileName);
        writter.WriteLine(datetime.ToString("dd-MM-yyyy_hh-mm-ss") + " > " + message);
        writter.Flush();
        writter.Close();
    }
    catch (SqlException ex)
    {
        Console.WriteLine("SQL Error: " + ex.Message);
    }

    catch (Exception e)
    {
        Console.WriteLine(e.Message.ToString());
    }
}

Posted 2-Aug-15 16:37pm

Member 11878313

Add a Solution

2 solutions

Solution 2

No, from this fragment of code, you don't know exact location of the file. It is "working directory" (also called "current directory"), and this directory depends on where you start the application. If you simply click on the .exe file, it is equivalent to "cd" command wiuth the directory where the executable file is located, followed by the executable file name as the next command, which starts the application. So, in this case, working directory would be the same as executable directory. This is not so in general case; you can start the same executable from any other directory. Such directory can even be read-only for the current user, which would make this kind of logging impossible.

This is "naive" logging which can help you in some simple cases, but is not robust enough to be practical. Recommended way of logging is through the use System.Diagnostics.EventLog:
https://msdn.microsoft.com/en-us/library/system.diagnostics.eventlog%28v=vs.110%29.aspx[^].

This is a whole logging system, which allows you, in addition to default logging to the system event log, create your own custom sinks for logging data, or classify your logging information in the system log according to the application. Please see my past answers on logging customization:
MsBuild OutPut to the TextBox on the fly in Windows Application[^],
How to create event log under a folder[^].

Another recommended way of logging in .NET applications would be open-source using Apache log4net: https://logging.apache.org/log4net[^].

—SA

Posted 2-Aug-15 16:59pm

Sergey Alexandrovich Kryukov

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

DamithSL · Accepted Answer · 2015-08-02T16:50:00

There is only the file name, no directory path provided. so your log file will create same place where your exe file executing.
I wonder why there is SqlException catch in your code, there is no code related to SQL in the given code block. So there is no point of having SqlException catch block.
apart from that your code seems to be OK. just try yourself first and check the log files created in the same location where your exe file located.