 |
|
try
{
account.Save();
}
catch { ; }
|
|
|
|
|
At least there are comments.
|
|
|
|
|
I can think of a few comments myself...
The universe is composed of electrons, neutrons, protons and......morons. (ThePhantomUpvoter)
|
|
|
|
|
Guess programmer was hungry thats why he "ate" the exception 
Always Keep Smiling.
Yours Pankaj Nikam
|
|
|
|
|
Relax.
This is just sweeping under the rug.
It could be worse.
Mislim, dakle jeo sam.
|
|
|
|
|
I'm impressed they wasted the energy on a surplus semicolon.
Software Zen: delete this;
|
|
|
|
|
They might have a style rule that enforces:
"catch block cannot be empty"
Warning: Empty catch block.
ftfy: ";"
|
|
|
|
|
... which just demonstrates how misleading style enforcement can be.
Software Zen: delete this;
|
|
|
|
|
What kills me is the comment. It would have taken the same effort to say Logger.Log(ex);
|
|
|
|
|
I'm trying (in vain so far) to think up any scenario where the context around this might make this o.k. For example, something like:
int pageIndex = 0;
try {
pageIndex = int.TryParse(Request[pageNum])
} catch (Exception e) {
Logger.info("Page Index of " + Request[pageNum] + " invalid, using " + pageIndex.ToString());
}
(Of course, I'd use Int.TryParse instead and null-check the request variable)
But, you get the idea--some scenario where you can continue to operate with default data given an unexpected condition. I can't think of any situation where the missing context makes it o.k. to swallow an exception trying whatever a Save operation does.
|
|
|
|
|
In this case it's just plain sloppy, lazy, and wrong. It should log and throw, allowing the error to propagate to the global error handler. The object's been validated so if the save fails it's a critical failure somewhere in the system, like the database is down. Eating the error when a save fails is never the right thing to do. The user blissfully goes about their business because the save "worked" but it didn't. Wrong, wrong, wrong.
|
|
|
|
|
I can think of situations where it might be appropriate to do something like that.
For instance, suppose you are implementing a "like" button or something similar. It's not critical that it works and let's assume that it's unreliable for reasons beyond the programmer's control, like maybe it depends on an external service which is not always available.
So in that case maybe it's OK to swallow the exception since it's not unusual and nothing will really break if it fails, so you just silently fail and the user can try again if they want. There aren't many situations like this in programming though, and you still should probably log the exceptions.
I'm pretty sure that something like account.Save() is a bit too important to treat this way, though.
|
|
|
|
|
Looks to me like the original programmer was too lazy to handle an exception, and another programmer came along and added the helpful "Not good!" comment, and left it like that. I don't know which programmer to hate more.
Five bucks says that account.Save() has a return value indicating success.
|
|
|
|
|
Well if saving doesn't work now, it could work later... 
|
|
|
|
|
I notice that a fair few of the recent posts here seem out of place.
Can't people read?
ps. I guess that by posting this, I now have to include myself in that category, but I'm hoping to be indulged.
"If you don't fail at least 90 percent of the time, you're not aiming high enough."
Alan Kay.
|
|
|
|
|
Two wrongs don't make a right. 
|
|
|
|
|
But three lefts do.
(well, someone had to do it!)
Quidquid latine dictum sit, altum viditur.
|
|
|
|
|
I resisted doing it myself.
|
|
|
|
|
And remember that there will always be a future in computer maintenance...
Assuming you were quoting the Deteriorata.
Psychosis at 10
Film at 11
Those who do not remember the past, are doomed to repeat it.
Those who do not remember the past, cannot build upon it.
|
|
|
|
|
It was better when it was the Hall of Shame, if you ask me.
|
|
|
|
|
Most of the time I just click the links from the main page to get to various threads, having no idea which forum they're in or what on earth the forum description is if any 
|
|
|
|
|
Apparently some people can't even spell forum anymore let alone read a description about its purpose...
Rhys
"If you ever start taking things too seriously, just remember that we are talking monkeys on an organic spaceship flying through the Universe"
|
|
|
|
|
Well I had to have some kind of horror in their to justify posting to this forum 
"If you don't fail at least 90 percent of the time, you're not aiming high enough."
Alan Kay.
|
|
|
|
|
He was expecting the Intellisense to complete it for him.
Rhys Gravell wrote: Apparently some people can't even spell forum
Psychosis at 10
Film at 11
Those who do not remember the past, are doomed to repeat it.
Those who do not remember the past, cannot build upon it.
|
|
|
|
|
Quote: Can't people read?
I'm fine, how are you?
There are only 10 types of people in the world, those who understand binary and those who don't.
|
|
|
|
|
Apologies if this subject has already been discussed before.
After stumbling upon last September's Best C# Article NET-CLR-Injection-Modify-IL-Code-during-Run-time and learning about endless security issues with the Java Runtime.
Are these platforms actually safer than conventional compiled executables?
Isn't the whole point of Data Execution Prevention (DEP) meant to stop run-time modification of running code? The CLR/JAVA Runtime engines have the only *native* code that DEP has any direct control of, but they are allowed to run without question, because of some dubious assumption that code for a virtual cpu/machine can do no real damage.
Maybe I'm wrong, but I can't help thinking that code under direct control of the 'real' cpu is safer than these virtualized runtime environments. 
I'm not fully versed in .NET or Java coding. Anyone care to shed more light on the subject.
modified 9 May '13 - 20:02.
|
|
|
|
|
dusty_dex wrote: The CLR/JAVA Runtime are the only executable code DEP has any direct control of
Nope not true at all. It has full control over native code too. Also, don't forget that these runtimes are written in native code.
Just as a point of interest, some CPU's have a hardware based DEP[^]
.-.
|o,o|
,| _\=/_ .-""-.
||/_/_\_\ /[] _ _\
|_/|(_)|\\ _|_o_LII|_
\._. |\_/|"` |_| ==== |_|
|_|_| ||" || ||
|-|-| ||LI o ||
|_|_| ||'----'||
/_/ \_\ /__| |__\
|
|
|
|
|
Sorry, my wording could have been clearer. 
[I've made a minor modification to the original post]
I know that the DEP handles *all* native code, but that's what I was getting at. The runtimes are native code but I wanted to know whether the MSIL code/ Java Bytecode is kept in the dcache or icache along with native code.
I thought native code, unless specifically marked as shared would otherwise be read-only and not modifiable at runtime. Which led me to wonder about the location .NET/Java bytecodes and the whole self-modifying code (code injection) problem, with the apparent side-stepping of DEP protection.
|
|
|
|
|
|
So which forum?
I based my decision on the WORST/BEST PRACTICES which is mentioned at the top.
|
|
|
|
|
I think the life of software developer is a nothing but "The journey between LOGIN & LOGOUT"
What is your opinion??
eNJOY c0ding....
|
|
|
|
|
it's just a job, and it doesn't count as life 
d{^__^}b - it's time to fly
|
|
|
|
|
I agree it doesn't count life but it is not a part of life??
eNJOY c0ding....
|
|
|
|
|
it's a waste of life, mostly coding useless stuff
d{^__^}b - it's time to fly
|
|
|
|
|
I think you had something bad experience about cOding.
eNJOY c0ding....
|
|
|
|
|
i don't see whats so 'enjoyable', it's sunny warm day, and it's wasted sitting in the office...
d{^__^}b - it's time to fly
|
|
|
|
|
Take a break and spend time with friends and family.
it will remove your stress as you mentioned in you trailing message!!!
eNJOY c0ding....
|
|
|
|
|
it would, but too bad i have to be in the office, your solution doesn't work, 8h still to waste and thats it for today 
d{^__^}b - it's time to fly
|
|
|
|
|
Hey...Leave this job if you are not happy with it.
do whatever which gives you happiness otherwise be happy with whatever you are doing.... 
eNJOY c0ding....
|
|
|
|
|
i need the money, can't leave ;/
d{^__^}b - it's time to fly
|
|
|
|
|
Then don't be upset...
eNJOY your work,it's an only single way to keep yourself happy.
BTW you do have so many options to earn money except development & coding 
eNJOY c0ding....
|
|
|
|
|
Its all about creativity.
You can reach destination in several ways but which one is shortest and flexible that is where good developer involved.
Life is all about share and care...
|
|
|
|
|
so when they enter into management (without coding) does that mean they logout??
if that is the case then you have to allow for multiple logins. I did the management route a few years back and after a couple of years I realized I was miserable and wanted to program.
as if the facebook, twitter and message boards weren't enough - blogged
|
|
|
|
|
|
Will you please explain why it is wrong forum?
eNJOY c0ding....
|
|
|
|
|
...from the top of the page...
The Weird and The Wonderful forum is a place to post Coding Horrors, Worst Practices, and the occasional flash of brilliance.
We all come across code that simply boggles the mind. Lazy kludges, embarrasing mistakes, horrid workarounds and developers just not quite getting it. And then somedays we come across - or write - the truly sublime.
Post your Best, your worst, and your most interesting. But please - no programming questions . This forum is purely for amusement and discussions on code snippets. All actual programming questions will be removed.
Peter
Software rusts. Simon Stephenson, ca 1994. So does this signature. me, 2012
|
|
|
|
|
you have copied all thing from the top of the page...
eNJOY c0ding....
|
|
|
|
|
But have you read it yet? Do you understand it?
|
|
|
|
|
Ya sir.and i don't think i have posted some wrong forum.shall i delete it?
eNJOY c0ding....
|
|
|
|
|
Leave it now, but in future pay attention to what the purpose of the forum is that you are posting in to. This forum is purely for code.
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Rant 
Admin 
Submit an article or tip
Post your Blog
