help me to to configure excute scaller in that code

Question

0.00/5 (No votes)

See more:

i am getting error in this code. i am trying to execute scalar.. to check if dere is not record in the database table then add a record.. but not corretly able to implement it.. more over i will eleminate the sql injection issue lator.
the errors are :-

Error	1	Cannot implicitly convert type 'object' to 'int'. An explicit conversion exists (are you missing a cast?)	C:\Users\Farooq\Desktop\my project codes\logincontrol\Default2.aspx.cs	41	19	C:\...\logincontrol\

Error	2	Only assignment, call, increment, decrement, and new object expressions can be used as a statement	C:\Users\Farooq\Desktop\my project codes\logincontrol\Default2.aspx.cs	48	17	C:\...\logincontrol\

check is that query i have written is correct.

C#

MAcmd.CommandText = "SELECT Count(UserId) FROM roles Select UserId,GroupID from Users,Groups WHERE name = '" + TextBox2 + "' AND username = '" + TextBox1.Text + "'";

C#

try
       {
           MAconn = new SqlConnection();
           MAconn.ConnectionString = sConnectionString;
           MAconn.Open();

           MAcmd = MAconn.CreateCommand();
           // MAcmd.CommandText = "INSERT INTO db VALUES(" + textBox1.Text + ",'" + textBox2.Text + "','" + textBox3.Text + "','" + a + "')";
           MAcmd.CommandText = "SELECT Count(UserId) FROM roles Select UserId,GroupID from Users,Groups WHERE name = '" + TextBox2 + "' AND username = '" + TextBox1.Text + "'";
           int c=MAcmd.ExecuteScalar();
           if (c==0)
           {
               Label1.Text = "o yes";
           }
           else
           {
               Label1.Text + "record already exits";
           }



           MAcmd.CommandText = "INSERT INTO ROLES (UserId,GroupId) SELECT UserId,GroupId FROM Users, Groups WHERE username= '" + TextBox1.Text + "' AND name='" + TextBox2.Text + "'";

           MAcmd.ExecuteNonQuery();
           //MessageBox.Show("Inserted Sucessfully");
           Label1.Text = "inserted";
           MAconn.Close();
       }
       catch (Exception ex)
       {
           Label1.Text = "not" + ex;
       }

Posted 8-Sep-11 0:54am

codegeekalpha

Add a Solution

2 solutions

Solution 1

To solver first error use

C#

int c=(int)MAcmd.ExecuteScalar();

instead of

C#

int c=MAcmd.ExecuteScalar();

And second error is

C#

Label1.Text + "record already exits";

you are missing a "=" operator. Use this

C#

Label1.Text += "record already exits";

OR

C#

Label1.Text = "record already exits";

And it is a compile time error, so it would show a red line under it.
Don't why you cant figure out these simple error.s

Posted 8-Sep-11 1:30am

Suresh Suthar

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

md_refay · Accepted Answer · 2011-09-08T01:40:00

Solution 2

i think your problem is in your query look

SELECT Count(UserId) FROM roles Select UserId,GroupID from Users,Groups WHERE name = '" + TextBox2 + "' AND username = '" + TextBox1.Text + "'";
u have 2 select statement in the same query 1 in bold & the other underline
please take the out print of your sql statement & execute it in sql & check iy's result

Posted 8-Sep-11 1:40am

md_refay

Comments

codegeekalpha 8-Sep-11 7:59am

can u pls help me to correct it??

[no name] 8-Sep-11 8:31am

it 'll be
string x="Select Count(UserId) FROM roles inner join users on roles.userid=users.userid inner join groups on users.groupid =groups.groupid where name ='"TextBox2.Text + "' AND username = '" + TextBox1.Text + "'";
hope it be helpfull