4 Digit Combination With C#. Please Fix My Sample Code

Question

1.00/5 (2 votes)

See more:

Hi Codeproject. I find a code in VB for generate all possible 4 Digit combination
and i tried to convert it to C#. It seems work well. but not eliminate the same combination. can anybody here fix my code...

C#

#region

using System;
using System.Collections;
using System.Windows.Forms;

#endregion

namespace WindowsFormApplication1
{
    public partial class Permutation : Form
    {
        private string _temporaryOutputString;

        private ArrayList _temporaryOutputArrayList;
        public Permutation()
        {
            InitializeComponent();
        }
        private void StoreCurrentNumericCode(ref ArrayList numericCodeArrayList)
        {
            _temporaryOutputString = numericCodeArrayList[0].ToString();
            _temporaryOutputString += numericCodeArrayList[1].ToString();
            _temporaryOutputString += numericCodeArrayList[2].ToString();
            _temporaryOutputString += numericCodeArrayList[3].ToString();
            _temporaryOutputString += Environment.NewLine;
            _temporaryOutputArrayList.Add(_temporaryOutputString);
        }

        private void RemoveNumericCodeDuplicates(ref ArrayList storedNumericCodeArrayList)
        {
            string currentlyEvaluatedElementText = "";
            bool IsReadLoopOfArraylistComplete = false;
            bool IsDuplicateRemovalLoopOfArraylistComplete = false;
            int storedNumericCodeElementIndex = 0;
            int duplicateSearchElementIndex = 0;

            while (!(storedNumericCodeElementIndex >= storedNumericCodeArrayList.Count))
            {
                currentlyEvaluatedElementText = storedNumericCodeArrayList[storedNumericCodeElementIndex].ToString();
                duplicateSearchElementIndex = storedNumericCodeElementIndex + 1;
                if (Convert.ToInt32(currentlyEvaluatedElementText) == 9139)
                {
                    int i = 1;
                }
                while (!(duplicateSearchElementIndex >= storedNumericCodeArrayList.Count))
                {
                    if ((storedNumericCodeArrayList[duplicateSearchElementIndex] == currentlyEvaluatedElementText))
                    {
                        storedNumericCodeArrayList.RemoveAt(duplicateSearchElementIndex);
                        duplicateSearchElementIndex = duplicateSearchElementIndex - 1;
                        if (!(storedNumericCodeElementIndex == 0))
                        {
                            storedNumericCodeElementIndex = storedNumericCodeElementIndex - 1;
                        }
                    }
                    duplicateSearchElementIndex += 1;
                }
                storedNumericCodeElementIndex += 1;
            }
        }
        private void OutputUniqueNumericCodes(ref ArrayList storedNumericCodeArrayList)
        {
            for (int storedNumericCodeElementIndex = 0; storedNumericCodeElementIndex <= storedNumericCodeArrayList.Count - 1; storedNumericCodeElementIndex++)
            {
                richTextBox1.Text += storedNumericCodeArrayList[storedNumericCodeElementIndex];
                //TextBox1.Text &= Environment.NewLine
            }
        }

        private void button1_Click(object sender, EventArgs e)
        {
            ArrayList numericCodeOutputArrayList = new ArrayList();
            string[] numericCodeInitArray = new string[4];
            numericCodeInitArray[0] = "9";
            numericCodeInitArray[1] = "1";
            numericCodeInitArray[2] = "3";
            numericCodeInitArray[3] = "9";

            numericCodeOutputArrayList.Add(numericCodeInitArray[0]);
            numericCodeOutputArrayList.Add(numericCodeInitArray[1]);
            numericCodeOutputArrayList.Add(numericCodeInitArray[2]);
            numericCodeOutputArrayList.Add(numericCodeInitArray[3]);

            string firstOutputElementText = "";
            string secondOutputElementText = "";
            string thirdOutputElementText = "";
            _temporaryOutputArrayList = new ArrayList();

            for (int repositionFirstIndex = 0; repositionFirstIndex <= 3; repositionFirstIndex++)
            {
                for (int repositionSecondIndex = 0; repositionSecondIndex <= 2; repositionSecondIndex++)
                {
                    for (int repositionThirdIndex = 0; repositionThirdIndex <= 1; repositionThirdIndex++)
                    {
                        StoreCurrentNumericCode(ref numericCodeOutputArrayList);

                        thirdOutputElementText = numericCodeOutputArrayList[2].ToString();
                        numericCodeOutputArrayList.RemoveAt(2);
                        numericCodeOutputArrayList.Add(thirdOutputElementText);
                    }

                    secondOutputElementText = numericCodeOutputArrayList[1].ToString();
                    numericCodeOutputArrayList.RemoveAt(1);
                    numericCodeOutputArrayList.Add(secondOutputElementText);
                }

                firstOutputElementText = numericCodeOutputArrayList[0].ToString();
                numericCodeOutputArrayList.RemoveAt(0);
                numericCodeOutputArrayList.Add(firstOutputElementText);
            }

            RemoveNumericCodeDuplicates(ref _temporaryOutputArrayList);
            OutputUniqueNumericCodes(ref _temporaryOutputArrayList);
        }
    }
}

For any attention from Codeproject and any member

Thx a Lot

Posted 17-Dec-11 1:49am

SunLucDong

Add a Solution

Comments

AmitGajjar 17-Dec-11 8:09am

hi,

can you show us some sample output you want to generate ? it will take time to understand existing code better to know about your desired output.

thanks
-amit

SunLucDong 17-Dec-11 14:34pm

this is The output i want to generate
9139
9193
9391
9319
9913
9931
1399
1399
1993
1939
1939
1993
3991
3919
3919
3991
3199
3199
9913
9931
9139
9193
9391
9319

But it show two time a same number..
i want to eliminate the same number

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2011-12-17T02:16:00

Solution 1

2 points:
1) Did the VB original do what you wanted? If so, then your translation is faulty - try http://www.developerfusion.com/tools/convert/vb-to-csharp/[^] It's an on-line translator which handles valid code pretty well.
2) Calling it "your code" when you got it elsewhere is a bit like calling it "my car" because I sat in it in the showroom...

Posted 17-Dec-11 2:16am

OriginalGriff

Comments

Sergey Alexandrovich Kryukov 18-Dec-11 18:41pm

Good points, a 5.
--SA

#realJSOP · Accepted Answer · 2011-12-17T02:58:00

Are you aware that regular permutations don't do duplicates? Your data set of 9,1,3,9 will generate 16 permutations from an actual possible 24. If that's indeed what you're expecting, your permutation code can be just 14 lines of code (accounting for proper code formatting techniques). Further, you can put the results into a HashSet to avoid duplicate checking (although, even that isn't really necessary).

Here's some code I found with google:

C#

public static class ExtensionMethods
{
    public static IEnumerable<T[]> Permute<T>(this T[] xs, params T[] pre)
    {
        if (xs.Length == 0)
        {
            yield return pre;
        }
        for (int i = 0; i < xs.Length; i++)
        {
            foreach (T[] y in Permute(xs.Take(i).Union(xs.Skip(i+1)).ToArray(), pre.Union(new[] { xs[i] }).ToArray()))
            {
                yield return y;
            }
        }
    }
}

And here's how to use it:

C#

int[] values = {9,1,3,9};
HashSet<int[]> permutations = new HashSet<int[]>();
foreach(int[] perm in values.Permute())
{
    permutations.Add(perm);
}

This will yield 16 permutations. If you change the last digit to an 8, you'll get 24 permutations.