fast image processing c#

Question

1.00/5 (2 votes)

See more:

please help me to process it more faster..
here's my code..

C#

int height = pictureBox1.Image.Height;
int width = pictureBox1.Image.Width;

for (int i = 0; i < height; i++)
{

    for (int j = 0; j < width; j++)
    {

         if ((bmp.GetPixel(j, i) == bmp1.GetPixel(22, 16))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(50, 17))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(89, 16))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(116, 18))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(157, 21))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(185, 17))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(216, 17))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(258, 16))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(289, 19))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(23, 54))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(51, 52))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(85, 51))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(126, 48))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(159, 51))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(191, 52))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(223, 50))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(259, 50))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(288, 49))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(26, 82))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(56, 82))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(89, 85))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(125, 85))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(154, 82))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(186, 85))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(214, 83))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(248, 83))
             || (bmp.GetPixel(j, i) == bmp1.GetPixel(285, 81)))
        {
             MessageBox.Show("color found");
             break;
        }
                          
    }
                       if (IsColorFound == true)
                       {
                           break;
                       }
                   }

                   if (IsColorFound == false)
                   {
                       listBox1.Items.Add("None");
                       // MessageBox.Show("No color found.");
                   }

               }
               else
               {
                   MessageBox.Show("Image is not loaded");
               }

Posted 23-Jan-13 1:59am

ned27ruth

Updated 23-Jan-13 2:38am

CHill60

v2

Add a Solution

5 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CHill60 · Answer 1 · 2013-01-23T02:40:00

Solution 2

You're not setting IsColorFound when you find the colour so the outer loop never breaks

Posted 23-Jan-13 2:40am

CHill60

Dave Kreskowiak · Answer 2 · 2013-01-23T04:22:00

Solution 3

HTe problem is that you're using GetPixel, which is extremely slow. I suggest searching the articles for a series of them written by Christian Graus, "Image processing for dummies". They'll show you a MUCH faster way of looking at individual pixels.

Posted 23-Jan-13 4:22am

Dave Kreskowiak

Andreas Gieriet · Answer 3 · 2013-01-23T07:41:00

Solution 4

You might seek for a C++ solution?
Cheers
Andi

Posted 23-Jan-13 7:41am

Andreas Gieriet

Nick Fisher (Consultant) · Answer 4 · 2013-01-23T11:23:00

You are calling GetPixel way too many times, as others have pointed out.

Instead of calling it twice on every line of your IF statement, try:

C#

for (int i = 0; i < height; i++)
{

    for (int j = 0; j < width; j++)
    {

         Color x = bmp.GetPixel(j, i);         // get it once and store it here

         if ((x == bmp1.GetPixel(22, 16))
             || (x == bmp1.GetPixel(50, 17))
             || (x == bmp1.GetPixel(89, 16))
             || (x == bmp1.GetPixel(116, 18))
             || (x == bmp1.GetPixel(157, 21))

         ...etc

        {
             MessageBox.Show("color found");
             break;
        }
                          
    }

..which will improve it significantly.

ned27ruth · Answer 5 · 2013-01-23T02:00:00

Solution 1

bmp1 = picturebox2...tnx
Godbless :)

Posted 23-Jan-13 2:00am

ned27ruth

Comments

CHill60 23-Jan-13 8:32am

Why have you answered your own question? I'm not even sure I understand the solution