About insert value in database

Question

1.00/5 (2 votes)

See more:

C#

public partial class Home : System.Web.UI.Page
{
   SqlConnection con = new SqlConnection("Data Source=LENOVO-PC\\SQLEXPRESS;Initial Catalog=employee;Integrated Security=True");
   
   protected void Page_Load(object sender, EventArgs e){}
   protected void Button1_Click(object sender, EventArgs e)
   {
      con.Open();
      string s = "insert into employee values('" + TextBox1.Text + "', '" + TextBox2.Text + "', " + " '" + TextBox3.Text + "') ";
      SqlCommand comm = new SqlCommand(s, con);
      com.ExecuteNonQuery();
      con.Close();

Posted 25-Jan-13 3:33am

Member 9785676

Updated 25-Jan-13 4:29am

fjdiewornncalwe

v2

Add a Solution

Comments

Member 9581488 25-Jan-13 9:40am

what is the error??

PIEBALDconsult 25-Jan-13 10:06am

Please put all the database access code in its own class -- a Data Access Layer -- rather than in your form class.
Please use parameters rather than using concatenation to form the statement.
Please use try/finally for ExecuteNonQuery and Close.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard C Bishop · Answer 1 · 2013-01-25T03:48:00

Solution 1

The SqlCommand calling the ExecuteNonQuery() method only has 1 "m" while you declared it with 2.

com.ExecuteNonQuery() should be comm.ExecuteNonQuery()

Also, I would declare your SqlConnection in the same scope your other code is in.

Posted 25-Jan-13 3:48am

Richard C Bishop

Updated 25-Jan-13 3:49am

v2

Mike Meinz · Answer 2 · 2013-01-25T03:53:00

Your INSERT statement is missing the names of the columns. Best practice is to include the names of the columns so that your SQL statements will work should someone later add one or more columns to the database table.

INSERT INTO EMPLOYEE (col1,col2,col3) Values(val1,val2,val3);

Also, when you put values directly from a TextBox into a SQL statement, your software is vulnerable to SQL Injection attacks. Best practice is to use SQLParameter Class to pass values to a parameterized SQL statement. It also performs better than when the variable value is embedded within the SQL statement.

INSERT INTO EMPLOYEE (col1,col2,col3) Values(@valName1,@valName2,@valName3);

Read this article: Use SQL Parameters to Overcome Ad Hoc Performance Issues[^]