Additional information: The connection was not closed. The connection's current state is open.

Question

0.00/5 (No votes)

See more:

give me this type error again and again:
Additional information: The connection was not closed. The connection's current state is open.
in the following code.

public void store_detailinsertion()
        {

            try
            {
                ConnectionString.cnn.Open();
                cmd.Parameters.Clear();
                cmd = new SqlCommand("Insert into store_detail (prdid,quantity,itemtotal) Values (@prdid,@quantity,@itemtotal)", ConnectionString.cnn);
                cmd.Parameters.Add("@prdid", SqlDbType.VarChar).Value = mtbprdid.Text.ToString();
                cmd.Parameters.Add("@quantity", SqlDbType.VarChar).Value = txtqty.Text.ToString();
                cmd.Parameters.Add("@itemtotal", SqlDbType.VarChar).Value = txttotalstkqty.Text.ToString();
                cmd.ExecuteNonQuery();
                cmd.Connection.Close();
            }
            catch (Exception)
            {
                throw;
            }
            finally
            {

                ConnectionString.cnn.Close();
                ConnectionString.cnn.Dispose();
            }


        }

public void store_detailUpdation()
      {

          try
          {
              ConnectionString.cnn.Open();

              cmd.Connection = ConnectionString.cnn;
              ConnectionString.cnn.Open();
              cmd.CommandText = "Update store_detail set itemtotal='" + txttotalstkqty.Text + "',quantity='" + txtqty.Text + "' Where prdid='" + mtbprdid.Text + "'";

              cmd.ExecuteNonQuery();
              cmd.Connection.Close();
          }
          catch (Exception)
          {
              throw;
          }
          finally
          {
              ConnectionString.cnn.Close();
              ConnectionString.cnn.Dispose();
          }

      }

 private void store_detailOperation()
        {
            try
            {
                ConnectionString.cnn.Open();
                DataSet ds = new DataSet();
               

                SqlDataAdapter da = new SqlDataAdapter("select * from store_detail where prdid='" + mtbprdid.Text + "'", ConnectionString.cnn);
                int s = (da.Fill(ds));
                if (s >= 1)
                {
                    store_detailUpdation();
                    //DisableTextBoxs();
                    //EnableButtons();
                    //btnsave.Enabled = false;
                    //ConnectionString.cnn.Close();
                }
                else
                {

                    store_detailinsertion();
                    //DisbleTextBoxs();
                    //EnableButtons();
                    //btnsave.Enabled = false;
                }

            }
            catch (Exception)
            {
                throw;
            }
            finally
            {
                ConnectionString.cnn.Close();
                ConnectionString.cnn.Dispose();
            }
        }

Plzzz, Anyone Can Help Me

Posted 25-Jan-13 6:33am

Zain -Ul- Arifeen

Updated 25-Jan-13 6:47am

Abhishek Pant

v3

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mike Meinz · Answer 1 · 2013-01-25T06:42:00

With this code in store_detailUpdation, you set a Connection object to an already open Connection object. This is probably the source of the error message.

cmd.Connection = ConnectionString.cnn;
ConnectionString.cnn.Open();

In store_detailUpdation, you are closing the connection twice. Once in the Try block and once in the Finally block.

These both close the database connection:

cmd.Connection.Close();

ConnectionString.cnn.Close();

See the documentation for try-finally (C# Reference)[^]

BC @ CV · Answer 2 · 2013-01-25T06:48:00

If at all possible its best to use a using block with your command and connection objects.

C#

public void store_detailinsertion(string connectionString, string sqlText)
{ 
    using(SqlConnection conn = new SqlConnection(connectionString))
    {
        conn.Open();
        using(SqlCommand cmd = new SqlCommand(sqlText,conn))
        {
             cmd.Parameters.Add("@prdid", SqlDbType.VarChar).Value = mtbprdid.Text.ToString();
             cmd.Parameters.Add("@quantity", SqlDbType.VarChar).Value = txtqty.Text.ToString();
             cmd.Parameters.Add("@itemtotal", SqlDbType.VarChar).Value = txttotalstkqty.Text.ToString();
             cmd.ExecuteNonQuery();
        }
     }
}

Jibesh · Answer 3 · 2013-01-25T14:10:00

The problem starts from this method

C#

private void store_detailOperation()

You opened a connection here and performed a database operation and leaving the connection open in here

C#

ConnectionString.cnn.Open();
DataSet ds = new DataSet();
               
SqlDataAdapter da = new SqlDataAdapter("select * from store_detail where prdid='" + mtbprdid.Text + "'", ConnectionString.cnn);
int s = (da.Fill(ds));

so after this invoking 'store_detailUpdation()' or store_detailinsertion() inside these method you are trying to open the connection again which is already opened for above select statement. and It's very obvious from the error message.

it's a common and best practice to add a Connection state checking before you try to open database connection again.

i.e add the conneciton state checking inside the 'store_detailUpdation,store_detailinsertion methods as shown below

C#

public void store_detailUpdation()
{
   try
   {
        if(ConnectionString.cnn.State == ConnectionState.Open)
        {
          ConnectionString.cnn.Close();
        }
        ConnectionString.cnn.Open();
        ....
        ....
        ....

Additional information: The connection was not closed. The connection's current state is open.

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0