|
Pretty? Pretty?
You'd need a very large magnet and a flare gun to make that code pretty! 
The universe is composed of electrons, neutrons, protons and......morons. (ThePhantomUpvoter)
|
|
|
|
|
Obviously the old code is a hideous display of incompetence what with the gratitious use of cursors (not even FAST_FORWARD at that) and temp tables in dynamic SQL no less, but I think the new code is missing an ORDER BY Graphic_number ASC, Dept_code DESC (with matching nonclustered indexes on the table) and probably could be improved by an inline table valued function with a CROSS APPLY in place of dbo.func_grOrder_GetAssigned(Order_id) and a FULLTEXT index for the Description column to avoid the non-SARGable wildcard prefix.
modified 14-Apr-13 2:54am.
|
|
|
|
|
|
And now? When your boss tells you that the application is slow, where will you find some lines for easy improvements?
|
|
|
|
|
What would you suggest to do?
TOMZ_KV
|
|
|
|
|
Sprinkle WAITFOR DELAY '00:00:01' (or a more appropriate value, do a performance analysis first; it should run faster than the old unoptimized version) judiciously across your newly optimized SPs, so you still have room for improvement.
|
|
|
|
|
How can you be sure that both procedures are doing the same? I mean in all cases, not just on a few test cases.
|
|
|
|
|
The old one had been in production for a long while. Users knew that it returned correct results but just took too much time to run. They got timeout messages from time to time. Instead of fixing it, it was easier and quicker to write a new one.
TOMZ_KV
|
|
|
|
|
Just came across that code comment above a function. Not sure what it means. Maybe they got fed up and decided that they were finished working (though the task itself was incomplete)? Or maybe the code is complete, but never got put to use?
|
|
|
|
|
 
Gryphons Are Awesome! Gryphons Are Awesome!
|
|
|
|
|
Or does it refer only to the comment which is technically finished but proper explanation isn't implemented 
|
|
|
|
|
I suspect the code worked and they ended up doing something else. I would have commented out the function as well if that were the case.
<sig notetoself="think of a better signature">
<first>Jim
<last willyoudomyhomeworkforme="false">Meadors
|
|
|
|
|
1. May be the poor soul was forced to do VB and was just frustrated.
2. Coding finished. Comments never implemented.
3. Finished may be an event and the handler was never implemented.
4. It's a clue to treasure. Could be anagram. I can think of mine, eleventh and prism as the words.
5. May be it's Dave showing off his CCC skills.
"Bastards encourage idiots to use Oracle Forms, Web Forms, Access and a number of other dinky web publishing tolls.", Mycroft Holmes[ ^]
|
|
|
|
|
C++ code.
This is either brilliant, or just bloody awful. I'm coming down on the side of "bloody awful":
recv in the curr structure below is declared as:
BYTE recv[64];
DWORD verb;
...
verb = (upper[curr->recv[0]] << 24) + (upper[curr->recv[1]] << 16) + (upper[curr->recv[2]] << 8) + 0x20;
switch (verb)
{
case 'CMD ':
...
break;
case 'MON ':
...
break;
case 'END ':
...
break;
case 'EXT ':
...
break;
default:
...
break;
}
WE ARE DYSLEXIC OF BORG. Refutance is systile. Your a$$ will be laminated.
There are 10 kinds of people in the world: People who know binary and people who don't.
|
|
|
|
|
Gryphons Are Awesome! Gryphons Are Awesome!
|
|
|
|
|
I guess this was used to circumvent the restriction that a switch statement can't be used on unmanaged strings.
|
|
|
|
|
A very smart way of circumventing the restrictions of C--!
|
|
|
|
|
I did similar in C about twenty years ago, but I could only fit two characters into a character literal.
If you'll pardon my rusty C:
char* s ;
// read a line from a file into s
short* i = s ;
switch ( *i ) ...
This enabled me to easily parse some reports. I wish I still had the code. 
|
|
|
|
|
PIEBALDconsult wrote: I did similar in C about twenty years ago, but I could only fit two characters into a character literal.
If you'll pardon my rusty C:
char* s ;
// read a line from a file into s
short* i = s ;
switch ( *i ) ...
On most hardware platforms, this will cause some alignment indigestion for every second pair of chars. Assigning a short off of an even byte boundary will usually cause a lot of work for the processor, perhaps involving exceptions and retries.
I like the thinking though...
--
Harvey
|
|
|
|
|
I only did it with the first two characters per line.
|
|
|
|
|
For a string, that could still be at an odd address.
--
Harvey
|
|
|
|
|
It's ugly, yes.
But it also has the potential to be fast. By loading the three characters and one space into a machine word, it is a single machine instruction to compare each value, and if the compiler spots that - and it damn well should - then it can use a machine-word look up table and index into a machine-word jump table. And you can't get much faster than that!
If this is in time-critical code, then it could be justified. Provided it was well commented. If it's in user input handling, then the author needs to meet Mr Firing Squad for being too "clever".
The universe is composed of electrons, neutrons, protons and......morons. (ThePhantomUpvoter)
|
|
|
|
|
It's in a thread where it's listening for something from a TCPIP connection (sort of a command channel). It's low-volume, and as such, I don't think the "cleverness" is warranted. And no, it's not commented at all.
It's not that I don't understand what he was doing. I just think he was being too clever for his own good. And in the (unlikely?) event that the code is ever ported to a big-endian system, it would be completely broken.
WE ARE DYSLEXIC OF BORG. Refutance is systile. Your a$$ will be laminated.
There are 10 kinds of people in the world: People who know binary and people who don't.
|
|
|
|
|
Perhaps not a meeting with Mr Firing Squad than, but a meeting with Mr Big Stick seems warranted.
The universe is composed of electrons, neutrons, protons and......morons. (ThePhantomUpvoter)
|
|
|
|
|
I don't think it would, as it's doing the + and shift manually. If it was just switch(recv[0]) then it would be endian vulnerable.
In the absence of language or framework features that allow you to switch on a string, I have no problem with this.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
