|
I have the following set-up:
1. ViewModel:
...
public ICommand LoadSomeViewCommand;
public SomeViewModel(IRegionManager regionManager, IUnityContainer container)
{
this._regionManager = regioinManager;
this._container = container;
LoadCommand = new RelayCommand(new Action<object>(LoadSomeViewExecute), new Predicate<object>(CanLoadExecute));
}
...
private void LoadSomeViewExecute(object obj)
{
IRegion mainRegion = _regionManager.Regions[RegionNames.MainRegion];
foreach (var v in mainRegion.Views)
{
mainRegion.Remove(v);
}
_regionManager.RegisterViewWithRegion(RegionNames.MainRegion, typeof(SomeNewView));
}
private bool CanLoadExecute(object obj)
{
return true;
}
in the View.cs:
public SomeView(IRegionManager regionManager, IUnityContainer container)
{
InitializeComponent();
this.DataContext = new SomeViewModel(regionManager, container);
}
public SomeViewModel ViewModel
{
get { return (SomeViewModel)this.DataContext; }
}
and in xaml:
...
<StackPanel grid.Row="2">
<Button Content="Load"
Command="{Binding LoadCommand}"/>
...
</StackPanel>
When I click the button to load another component, the LoadCommand has been set in the constructor but never seems to be called on the button click.
I have been converting a VB project to C# to try and learn the language and maybe I have missed something in the translation.
I have other containers injecting into the shell that don't use Command calls that are working fine.
I don't speak Idiot - please talk slowly and clearly
"I have sexdaily. I mean dyslexia. Fcuk!"
Driven to the arms of Heineken by the wife
|
|
|
|
|
Dunno if you want these kinds of comments, so feel free to ignore them if you are offended , but your question IS answered below.
1) Bad practice to litter your code with 'this'. It's not needed as its implied.
2) Bad practice to use an interface to reference a concrete class inside of the class itself (public ICommand LoadSomeViewCommand)... its a RelayCommand, not an ICommand. You should only pass it around externally as an ICommand.
3) Your implementation of RelayCommand isn't correct. You should not need all that new Action, new Predicate garbage.
4) Your non-generic RelayCommand should not take any params. RelayCommand<T> is the one that takes a param and that one should be type safe. Don't pass in an object, pass in the real type.
5) *THE ANSWER TO YOUR QUESTION* You can't databind to a variable. Only properties.
6) If you are using UnityContainer, or any other DI container. USE IT. In your SomeView contructor, you have the unity container reference, but aren't using it to create the object.
7) Better to use an attached property to set your data context, so you get rid of all the hand wiring with a code behind.
8) Stop using var's for simple types. This isn't JavaScript . Vars have specific uses, this isn't one of them.
|
|
|
|
|
Cheers, i am not easily offended and want to learn this the correct way - very hard without someone to bounce off. As I said, this is from a VB project I am converting to try nd get the hang of the language.
You have given me a few things to work on,and probably learn from.
Thanks
I don't speak Idiot - please talk slowly and clearly
"I have sexdaily. I mean dyslexia. Fcuk!"
Driven to the arms of Heineken by the wife
|
|
|
|
|
SledgeHammer01 wrote: 1) Bad practice to litter your code with 'this'. It's not needed as its implied.
One of the default rules in FXCop or style cop or some such horror dictates the use of this. EVERYWHERE, I do find it useful for limiting the scope of intellisense but it really feels like using the VB me. which I still cringe at!
Oh and if I remember correctly Andy is a Kiwi living in Oz, the bugger has to have a thick skin and anyone using VB grows one naturally!
Never underestimate the power of human stupidity
RAH
|
|
|
|
|
Mycroft Holmes wrote: Andy is a Kiwi living in Oz, the bugger has to have a thick skin
Yes, and I know Mick Martin to drink with!
I don't speak Idiot - please talk slowly and clearly
"I have sexdaily. I mean dyslexia. Fcuk!"
Driven to the arms of Heineken by the wife
|
|
|
|
|
Andy_L_J wrote: I know Mick Martin to drink with
Having not yet had this experience and only dealt with his pleasantly abrasive online personality I do look forward to the opportunity when I next hit Sydney. As I now visit Cairns instead I don't know when this will happen though.
I have an ebook (somewhere) I used when moving from VB to C#, it helped with the syntax differences, let me know if you are interested.
Never underestimate the power of human stupidity
RAH
|
|
|
|
|
Sometimes I'll type "this" if I don't remember the prop name, but I'll delete the this afterwards. I use a leading underscore (which Andy did) on class member variables. That differentiates member variables from local variables. I think very few people agree on formatting / style issues . In my last job, my team lead insisted everybody format the code with 3 spaces. It took me a while to convince him that nobody else likes 3 spaces and if he went to tabs, then everybody could have it how they wanted without affecting the code. He still put up a fight. Only once I showed him that practice in action and how SCC still saw it as exactly the same did the light bulb finally come on.
|
|
|
|
|
My pet hates are underscores, capitalisation and anyone not using TAB set you = 2 spaces (SSMS uses 8 ).
Even if you use tabs and the size of the tabs are different it can totally screw up the formatting when changing developer, irritating to say the least.
Never underestimate the power of human stupidity
RAH
|
|
|
|
|
Mycroft Holmes wrote: My pet hates are underscores
+5 on that one. I think it makes code so unreadable.
When I was a coder, we worked on algorithms. Today, we memorize APIs for countless libraries — those libraries have the algorithms - Eric Allman
|
|
|
|
|
So how do you easily differentiate between local variables, method parameters and class members?
|
|
|
|
|
A common trick with VMs is to apply lazy-loading to your commands. What you do is
private RelayCommand loadCommand;
public RelayCommand LoadCommand
{
get
{
if (loadCommand == null)
loadCommand = new RelayCommand((o)=> LoadSomeViewExecute, new Predicate<object>(CanLoadExecute));
return loadCommand;
}
}
|
|
|
|
|
Cheers Pete, I have used lazy loading with CSLA and will definitely take a look at this.
I am quickly getting around C# syntax and 'un-learning' some VB hacks!
I don't speak Idiot - please talk slowly and clearly
"I have sexdaily. I mean dyslexia. Fcuk!"
Driven to the arms of Heineken by the wife
|
|
|
|