Click here to Skip to main content

C / C++ / MFC

Re: Is there any memory leak in this code?

SRKSHOME22-Sep-08 20:49

22-Sep-08 20:49

Thanks for your reply. But if you look at the main function I have called set("123456"). I have never called set(..) for second time. Second time this functin is called from destructor and NULL is passed to Set(). Hence I cannot see memory leak here. Please correct me if I am wrong.

Re: Is there any memory leak in this code?

User 21559722-Sep-08 21:46

22-Sep-08 21:46

I see the above as obvious memory leak in code. Also Sarath (in the reply below) pointed to the same problem. Try fixing the problem and then see if there is still memory leak.

You may also want to re-think about how m_name is deallocated when object lifetime ends.

modified 21-Apr-21 21:01pm.

Re: Is there any memory leak in this code?

Sarath C22-Sep-08 20:46

22-Sep-08 20:46

The program will be having memory leak, if you call set twice. You can rewrite the code better.

class test
{
	char* m_name;
public:
	test():m_name(NULL)
	{}
	void Set(const char* name)
	{
		// Leave the data untouched on invalid input
		if( name == NULL || 0 == strlen(name))
			return;

		if( m_name )
			delete []m_name;

		// Validate the pointer after allocating if necessary or put try/catch if exception enabled
		m_name = new char[strlen(name)+1]; 
		strcpy(m_name,name);
	}
	~test()
	{
		if( m_name ) 
                     delete [] m_name;
	}
	void display()
	{
		cout<<m_name<<endl;
	}
};

-Sarath.
"Great hopes make everything great possible" - Benjamin Franklin

My blog - Sharing My Thoughts, An Article - Understanding Statepattern

Re: Is there any memory leak in this code?

SRKSHOME22-Sep-08 20:53

22-Sep-08 20:53

Thanks for your better code reply.

problem in copy .exe file

vcprog22-Sep-08 18:56

22-Sep-08 18:56

Hi All

I have a problem to copy .exe file.I am useing

GetLastError()

then found error no.32 and 3.
error No. 3 show

The system cannot find the path specified.

And Error no. 32 show

The process cannot access the file because it is being used by another process.

Code is

void On_FileAdded(const CString & strFileName)
{

    USES_CONVERSION;

    CString CStrfilename=strFileName;

    char* charfilename;

    charfilename=CStrfilename.GetBuffer();

    LPCTSTR lp;

    //lp=charfilename;

    lp=CStrfilename;

    PathSkipRoot(lp);

    CString cs = "C:\\Backup\\";
    cs += PathSkipRoot(lp);
    CString st;

//  CopyFile(st, cs,TRUE);
    //AfxMessageBox(st);

if ( CopyFile(strFileName, cs, TRUE) != TRUE)
{
    DWORD dwError = GetLastError();
    CString szMsg;
    szMsg.Format("Error number %d", dwError);
    AfxMessageBox(szMsg);
}
else
{
    AfxMessageBox("Success");
}

    CopyFile(strFileName, cs,TRUE);

}

Plz help me

Re: problem in copy .exe file

_AnsHUMAN_ 22-Sep-08 19:01

22-Sep-08 19:01

vcprog wrote:
if ( CopyFile(strFileName, cs, TRUE) != TRUE)

Did you check the contents of strFileName and cs when you use them in CopyFile.

vcprog wrote:
else
{
AfxMessageBox("Success");
}
CopyFile(strFileName, cs,TRUE);

}

BTW why do you wan't to do CopyFile again?

Somethings seem HARD to do, until we know how to do them.
Wink | ;-)

Wink | ;-)

_AnShUmAn_

Re: problem in copy .exe file

vcprog22-Sep-08 19:22

22-Sep-08 19:22

Thx's for reply

yes i check the contents of strFileName and cs both are right.

And when comment these line

CopyFile(strFileName, cs,TRUE);

then file is not not copy..

Plz help me

Re: problem in copy .exe file

Hamid_RT22-Sep-08 19:34

22-Sep-08 19:34

Did you try with SHFileOperation?

Re: problem in copy .exe file

vcprog22-Sep-08 19:38

22-Sep-08 19:38

No i have no idea about SHFileOperation..

Can you give me example..

Plz help me

Re: problem in copy .exe file

Mahesh Kulkarni22-Sep-08 19:49

Mahesh Kulkarni

22-Sep-08 19:49

ShFileOperation Demo[^]

The secret of life is not enjoyment
but education through experience.
- Swami Vivekananda.

Re: problem in copy .exe file

Hamid_RT22-Sep-08 19:50

22-Sep-08 19:50

Like this:

TCHAR m_Files[256];
    sfo.wFunc = FO_COPY;
    sfo.hwnd = NULL;
    sfo.pFrom = m_Files;
    sfo.pTo = "c:\\Pics";
    sfo.fFlags = FOF_SILENT | FOF_NOCONFIRMATION | FOF_NOCONFIRMMKDIR;

    hr = SHFileOperation(&sfo);

Re: problem in copy .exe file

Rajesh R Subramanian22-Sep-08 19:44

Rajesh R Subramanian

22-Sep-08 19:44

vcprog wrote:
The process cannot access the file because it is being used by another process.

Which part of this error message do you not understand? Roll eyes | :rolleyes:

Roll eyes | :rolleyes:

Many are stubborn in pursuit of the path they have chosen, few in pursuit of the goal - Friedrich Nietzsche

.·´¯`·->Rajesh<-·´¯`·.
[Microsoft MVP - Visual C++]

Re: problem in copy .exe file

vcprog22-Sep-08 19:47

22-Sep-08 19:47

yes you are right i am not understand where is error showing?Can you help me?

Re: problem in copy .exe file

Rajesh R Subramanian22-Sep-08 19:56

Rajesh R Subramanian

22-Sep-08 19:56

The error means that this particular file is being exclusively locked by another process. So, until that process would release this lock, you will not be able to copy this file. You may try copying some other file to verify this.

See if this[^] helps.

Many are stubborn in pursuit of the path they have chosen, few in pursuit of the goal - Friedrich Nietzsche

.·´¯`·->Rajesh<-·´¯`·.
[Microsoft MVP - Visual C++]

Re: problem in copy .exe file

vcprog22-Sep-08 20:19

22-Sep-08 20:19

Sir it's not help me..Plz tell me how can i solve that problem..

Plz help me

Re: problem in copy .exe file

Hamid_RT22-Sep-08 20:43

22-Sep-08 20:43

BTW I found this article for you.Copy, Move and Delete files and directories without using SHFileOperation[^]. Wink | ;)

Wink | ;)

Re: problem in copy .exe file

Rajesh R Subramanian22-Sep-08 20:48

Rajesh R Subramanian

22-Sep-08 20:48

There is no point in all that, because the problem is that the OP is trying to copy a file which is being exclusively locked by another process.

The problem is not in choosing the method to copy a file, but with copying the file itself, as it is locked. Smile | :)

Smile | :)

Many are stubborn in pursuit of the path they have chosen, few in pursuit of the goal - Friedrich Nietzsche

.·´¯`·->Rajesh<-·´¯`·.
[Microsoft MVP - Visual C++]

Re: problem in copy .exe file

Hamid_RT22-Sep-08 21:34

22-Sep-08 21:34

Yeah thats right I forgot what was problem! Laugh | :laugh:

Laugh | :laugh:

Re: problem in copy .exe file

vcprog24-Sep-08 0:57

24-Sep-08 0:57

Hi Can i send you code.How can i attached the code here plz tell me or give me mail Id i will send you code..Plz help me

Re: problem in copy .exe file

Rajesh R Subramanian24-Sep-08 1:23

Rajesh R Subramanian

24-Sep-08 1:23

There is no problem with your code. The problem is, that the file is locked for copying. You may try copying some other file and see if that works first, to confirm what I say.

Many are stubborn in pursuit of the path they have chosen, few in pursuit of the goal - Friedrich Nietzsche

.·´¯`·->Rajesh<-·´¯`·.
[Microsoft MVP - Visual C++]

Re: problem in copy .exe file

vcprog24-Sep-08 2:35

24-Sep-08 2:35

Sir how can i solve that problem.I need some vital help from forum side..

Re: problem in copy .exe file

Rajesh R Subramanian24-Sep-08 2:58

Rajesh R Subramanian

24-Sep-08 2:58

By all means, I hope that you are understanding the problem at least.

May be you could tell toxcct in the following thread that you have a very similar problem and ask him how to find out the process that is locking your file.

The thread is here: http://www.codeproject.com/script/Forums/View.aspx?fid=1647&msg=2715438[^]

Many are stubborn in pursuit of the path they have chosen, few in pursuit of the goal - Friedrich Nietzsche

.·´¯`·->Rajesh<-·´¯`·.
[Microsoft MVP - Visual C++]

Re: problem in copy .exe file

vcprog24-Sep-08 21:05

24-Sep-08 21:05

Hi Rajesh R Subramanian

I ask to Mr. toxcct but i havn't got any reply from toxcct side.

Re: problem in copy .exe file

Rajesh R Subramanian24-Sep-08 23:24

Rajesh R Subramanian

24-Sep-08 23:24

What did I ask you to do and what have you done?

"Hello sir plz i need help" Is that a query? Help you with what? Did you explain him the problem? Did you tell that you are facing a similar situation and you need help with exactly "this X thing"? It would be impossible to help you.

That, you've just posted it 2 hours back and you write to me because he hasn't replied? If you don't have the manners and social skills, there is zero chance of getting any help from a community.

Many are stubborn in pursuit of the path they have chosen, few in pursuit of the goal - Friedrich Nietzsche

.·´¯`·->Rajesh<-·´¯`·.
[Microsoft MVP - Visual C++]

Re: problem in copy .exe file

vcprog24-Sep-08 23:49

24-Sep-08 23:49

Before any thing to say plz check all things.
Plz see it..

<a href="http://www.codeproject.com/script/Forums/View.aspx?fid=1647&msg=2738614">http://www.codeproject.com/script/Forums/View.aspx?fid=1647&msg=2738614</a>[<a href="http://www.codeproject.com/script/Forums/View.aspx?fid=1647&msg=2738614" target="_blank" title="New Window">^</a>]

General News Suggestion Question Bug Answer Joke Praise Rant Admin

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.