C / C++ / MFC Discussion Boards

Re: Repainting of dialog box takes time.

Le@rner8-Mar-10 22:08

Le@rner

8-Mar-10 22:08

if i use application without CBitmapButton code,its still behave like this.

Re: Repainting of dialog box takes time.

R@jeev K R8-Mar-10 22:20

R@jeev K R

8-Mar-10 22:20

That means, the problem is not from the CBitmapButton. Now check your dialog skinning code.Just like commenting the code for coloring the dialog or controls.

This way you can find out the exact problem...

Re: Repainting of dialog box takes time.

Le@rner9-Mar-10 0:22

Le@rner

9-Mar-10 0:22

i use this for color

CBrush m_brush;
m_brush.CreateSolidBrush(RGB(241,244,250));//in OnInitDialog

HBRUSH CTest::OnCtlColor(CDC* pDC, CWnd* pWnd, UINT nCtlColor) 
{
	HBRUSH hbr = CDialog::OnCtlColor(pDC, pWnd, nCtlColor);
	
	switch (nCtlColor)
	{
		case CTLCOLOR_EDIT:
			pDC->SetTextColor(RGB(0,0,0));
			pDC->SetBkColor(RGB(255,255,255));
			return hbr;

		case CTLCOLOR_STATIC:			
			LOGBRUSH logbrush;
			m_brush.GetLogBrush( &logbrush );
			pDC->SetTextColor(RGB(0,0,0));
			pDC->SetBkColor(logbrush.lbColor);
			return m_brush;
			

		case CTLCOLOR_BTN:
		case CTLCOLOR_MSGBOX:
		case CTLCOLOR_DLG:
			return m_brush;
		
		default:
			return m_brush;
	}
}

BOOL CTest::OnEraseBkgnd(CDC *pDC)
{
	CPen myPen,hpenOld;
	CRect rect;
	GetClientRect(&rect);
	for(int i=0;i<rect.bottom;)
	{	myPen.CreatePen(PS_SOLID,1,RGB(241,244,250));
		pDC->SelectObject(&myPen);
		pDC->MoveTo(0,i);
		pDC->LineTo(rect.right,i);
		i++;
		myPen.DeleteObject();
	}
	return 1
}

Re: Repainting of dialog box takes time.

R@jeev K R9-Mar-10 0:44

R@jeev K R

9-Mar-10 0:44

I cant find any problem in your code... Any way just comment your code in the OnEraseBkgnd and try to sort out the problem... If the problem is still there then we can avoid this one also from the problem list...

Re: Repainting of dialog box takes time. [modified]

Mohan Ramachandra9-Mar-10 1:54

Mohan Ramachandra

9-Mar-10 1:54

Le@rner wrote:
BOOL CTest::OnEraseBkgnd(CDC *pDC)
{
CPen myPen,hpenOld;
CRect rect;
GetClientRect(&rect);
for(int i=0;i<rect.bottom;)
{="" mypen.createpen(ps_solid,1,rgb(241,244,250));
="" pdc-="">SelectObject(&myPen);
pDC->MoveTo(0,i);
pDC->LineTo(rect.right,i);
i++;
myPen.DeleteObject();
}
return 1
}

Actually you are filling dialog with RGB(241,244,250) color.

Change the OnEraseBkgnd

BOOL CTest::OnEraseBkgnd(CDC *pDC)
{
	CRect rect;
	GetClientRect(&rect);	
	pDC->FillSolidRect(rect,RGB(241,244,250));	
	return TRUE;
}

to avoid for loop, unnecessary creation and destroying of pen,and filling dialog background color using LineTo and MoveTo functions.

This one can make you drawing bit faster.

modified on Tuesday, March 9, 2010 8:00 AM

Re: Repainting of dialog box takes time.

Le@rner9-Mar-10 2:00

Le@rner

9-Mar-10 2:00

thanks it works

Re: Repainting of dialog box takes time.

Eugen Podsypalnikov9-Mar-10 0:40

Eugen Podsypalnikov

9-Mar-10 0:40

Could you post your BitmapButton.cpp here ? Smile | :)

Check your definition of Irrationality[^] Smile | :)

1 - Avicenna
5 - Hubbard
3 - Own definition

Re: Repainting of dialog box takes time.

Le@rner9-Mar-10 0:42

Le@rner

9-Mar-10 0:42

CBitmapButton is a Visual studio class.

Re: Repainting of dialog box takes time.

Eugen Podsypalnikov9-Mar-10 0:56

Eugen Podsypalnikov

9-Mar-10 0:56

Do you have the following in all used *.cpp ?

#ifdef _DEBUG
#define new DEBUG_NEW
#endif

What output comes now after the exiting ?

Check your definition of Irrationality[^] Smile | :)

1 - Avicenna
5 - Hubbard
3 - Own definition

Re: Repainting of dialog box takes time.

Le@rner9-Mar-10 1:01

Le@rner

9-Mar-10 1:01

yes i add this in all *.cpp

'Test.exe': Loaded 'C:\Windows\System32\ntdll.dll'
'Test.exe': Loaded 'C:\Windows\System32\kernel32.dll'
'Test.exe': Loaded 'C:\Windows\System32\user32.dll'
'Test.exe': Loaded 'C:\Windows\System32\gdi32.dll'
'Test.exe': Loaded 'C:\Windows\System32\advapi32.dll'
'Test.exe': Loaded 'C:\Windows\System32\rpcrt4.dll'
'Test.exe': Loaded 'C:\Windows\System32\msimg32.dll'
'Test.exe': Loaded 'C:\Windows\System32\comdlg32.dll'
'Test.exe': Loaded 'C:\Windows\System32\msvcrt.dll'
'Test.exe': Loaded 'C:\Windows\System32\shlwapi.dll'
'Test.exe': Loaded 'C:\Windows\winsxs\x86_microsoft.windows.common-controls_6595b64144ccf1df_6.0.6002.18005_none_5cb72f96088b0de0\comctl32.dll'
'Test.exe': Loaded 'C:\Windows\System32\shell32.dll'
'Test.exe': Loaded 'C:\Windows\System32\winspool.drv'
'Test.exe': Loaded 'C:\Windows\System32\oledlg.dll'
'Test.exe': Loaded 'C:\Windows\System32\ole32.dll'
'Test.exe': Loaded 'C:\Windows\System32\oleaut32.dll'
'Test.exe': Loaded 'C:\Windows\System32\winmm.dll'
'Test.exe': Loaded 'C:\Windows\System32\oleacc.dll'
'Test.exe': Loaded 'C:\Windows\System32\imm32.dll'
'Test.exe': Loaded 'C:\Windows\System32\msctf.dll'
'Test.exe': Loaded 'C:\Windows\winsxs\x86_microsoft.windows.gdiplus_6595b64144ccf1df_1.0.6002.18005_none_9e50b396ca17ae07\GdiPlus.dll'
'Test.exe': Loaded 'C:\Windows\System32\lpk.dll'
'Test.exe': Loaded 'C:\Windows\System32\usp10.dll'
'Test.exe': Loaded 'C:\Windows\System32\uxtheme.dll'
'Test.exe': Loaded 'C:\Windows\System32\dwmapi.dll'
'Test.exe': Unloaded 'C:\Windows\System32\dwmapi.dll'
Detected memory leaks!
Dumping objects ->
{235} normal block at 0x00286728, 145 bytes long.
 Data: < %  d           > C0 25 C9 01 64 00 00 00 80 00 00 00 01 00 00 00 
{227} normal block at 0x002866D8, 20 bytes long.
 Data: < %              > C0 25 C9 01 03 00 00 00 03 00 00 00 01 00 00 00 
{226} normal block at 0x00286640, 85 bytes long.
 Data: < %  D   D       > C0 25 C9 01 44 00 00 00 44 00 00 00 01 00 00 00 
{225} normal block at 0x00286598, 103 bytes long.
 Data: < %  V   V       > C0 25 C9 01 56 00 00 00 56 00 00 00 01 00 00 00 
Object dump complete.
The program '[3536] Test.exe: Native' has exited with code 0 (0x0).

Re: Repainting of dialog box takes time.

Eugen Podsypalnikov9-Mar-10 1:05

Eugen Podsypalnikov

9-Mar-10 1:05

1) Try to create, select and delete your background pen outside the drawing loop.

2) Could you post your *.cpp here ? Smile | :)

Check your definition of Irrationality[^] Smile | :)

1 - Avicenna
5 - Hubbard
3 - Own definition

Re: Repainting of dialog box takes time.

Le@rner9-Mar-10 1:41

Le@rner

9-Mar-10 1:41

Eugen Podsypalnikov wrote:
Try to create, select and delete your background pen outside the drawing loop.

thanks its works

How to allocate memory for 2-D integer array in one line?

Nilesh Hamane8-Mar-10 18:35

Nilesh Hamane

8-Mar-10 18:35

I have this code for allocating memory for 2-d int array.

int **p = (int **)malloc(MAXROW*sizeof(int *));

for(int i = 0; i < MAXROW; i++)
{

	p[i] = (int *)malloc(MAXCOL*sizeof(int));
}

How can i optimize this code in one line?

http://nnhamane.googlepages.com/

Re: How to allocate memory for 2-D integer array in one line?

Avi Berger8-Mar-10 19:23

Avi Berger

8-Mar-10 19:23

Nilesh Hamane wrote:
How can i optimize this code in one line?

It is unclear to me what your are asking here. Do you mean by using just one dynamic memory allocation? What aspect of the situation are you trying to optimize - code size or speed; initial setup or use?

I am presuming that you are using C and not C++.

There are a variety of options that you can use. If this is really critical for your application, you will probably have to run some tests to see what is best in your situation.

A second possible approach is to do one allocation of col * row ints and explicitly calculate the offset into this array for each access.

A third approach is to keep your first allocation of row pointers to int, supplement it by a second allocation of col * row ints and set each row pointer to a subsequent group of col ints in the second block.

Please do not read this signature.

Re: How to allocate memory for 2-D integer array in one line?

Cool_Dev8-Mar-10 19:59

Cool_Dev

8-Mar-10 19:59

as Avi told.. here is how it goes..

//FIRST approacc

int* p[MAXROW];

//allocate col*row ints to base ptr
p[0] = (int*)malloc(MAXROW*MAXCOL*sizeof(int));

//explicitly calculate the offset into this array 
for(int i=1; i<MAXROW; ++i)
   p[i] = p[i-1] + MAXCOL;

//SECOND approach

//first allocation of row pointers to int
int **p = (int **)malloc(MAXROW*sizeof(int *));

//second allocation of col*row ints
p[0] = (int *)malloc(MAXCOL*MAXROW*sizeof(int));

//set each row pointer to a subsequent group of col ints in the second //block.
for(int i = 1; i<MAXROW; i++)
  p[i] = p[i-1] + MAXCOL;

both aproach seems better since all memory allocation is done at once..

Re: How to allocate memory for 2-D integer array in one line?

CPallini8-Mar-10 20:50

CPallini

8-Mar-10 20:50

what's wrong with

int * p = (int *) malloc(COLS * ROWS * sizeof(int));

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.

This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke

[My articles]

Re: How to allocate memory for 2-D integer array in one line?

Eugen Podsypalnikov8-Mar-10 20:54

Eugen Podsypalnikov

8-Mar-10 20:54

Just make a function void Make2DInt(int**& ppToCreate, int iWidth, int iHeight)

and then call it at one line... Smile | :)

Check your definition of Irrationality[^] Smile | :)

1 - Avicenna
5 - Hubbard
3 - Own definition

Re: How to allocate memory for 2-D integer array in one line?

LunaticFringe9-Mar-10 3:18

LunaticFringe

9-Mar-10 3:18

Remove all the white space and new lines?
Wink | ;)

L u n a t i c F r i n g e

Re: How to allocate memory for 2-D integer array in one line?

Nilesh Hamane26-Jan-11 22:34

Nilesh Hamane

26-Jan-11 22:34

Don't die, until you do.

random numbers

MsmVc8-Mar-10 18:22

MsmVc

8-Mar-10 18:22

Hi All

How to random numbers between 0 t0 1000000?Please help me

Re: random numbers

Rajesh R Subramanian8-Mar-10 18:31

Rajesh R Subramanian

8-Mar-10 18:31

rand()[^]

“Follow your bliss.” – Joseph Campbell

Re: random numbers

MsmVc8-Mar-10 18:49

MsmVc

8-Mar-10 18:49

Thanks for reply
i use this way

int iSecret, iGuess;

 srand ( time(NULL) );
  /* generate secret number: */
  for(int x=0;x<;5;x++)
  {
  iSecret = rand() % 10 + 1;

  }

Then i am getting duplicate number.Sorry sir i want to generate random unique number.
Please help me

Re: random numbers

Rajesh R Subramanian8-Mar-10 19:00

Rajesh R Subramanian

8-Mar-10 19:00

What do you mean you get "duplicate" values? The numbers generated are random. Take a look at another example[^]

“Follow your bliss.” – Joseph Campbell

Re: random numbers

MsmVc8-Mar-10 19:16

MsmVc

8-Mar-10 19:16

Duplicate values means generated random number repeated.
Now i see example given by you.But result is different.

int i, j, goAhead, timeSeed ; 

	timeSeed = (int) time(0) ;
	printf("Setting seed to be: %d\n", timeSeed) ; 
	srand(timeSeed) ;
	i = 0 ;
	for (; i < 10 ; i++)
	{
		for (j = 0 ; j < 5 ; j++) 
		{
			printf("%d ", rand() ) ; 
		//	int iSecret = rand() % 10 + 1;
		//add.Format("%d",iSecret);
		//m_list.InsertItem(0,add);
			break;
		}
		
		printf("\n") ;
	}

Result show more than 10 times.

Re: random numbers [modified]

Cool_Dev8-Mar-10 19:18

Cool_Dev

8-Mar-10 19:18

you can't generate random numbers between 0 and 1000000 because rand() returns integer less than RAND_MAX which is defined as 32767. So the values returned will be in between 0 and 32767. So the better way is to perform some bit shift operations on the returned random number to make it in the range of 0 to 1000000.

To avoid duplication, suppose if you want to generate 10 unique random numbers from 1 to 10..

int num[10];
//assign numbers from 1 to 10
for(int i=0; i<10; ++i)
  num[i] = i+1;

//generate random numbers
srand ( time(NULL) );

for(int i=0; i<10; ++i)
{
  int index = rand() % 10; //an index in array

  //exchange numbers in array
  int temp = num[i];
  num[i] = num[index];
  num[index] = temp;

}
//print random numbers in array here

modified on Tuesday, March 9, 2010 7:39 AM

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.