|
Great minds think alike?  
M.D.V. 
If something has a solution... Why do we have to worry about?. If it has no solution... For what reason do we have to worry about?
Help me to understand what I'm saying, and I'll explain it better to you
Rating helpful answers is nice, but saying thanks can be even nicer.
|
|
|
|
|
My arachnophobia is not to bad, but
What is the phobia name for fear that the Large Hadron Collider will create a black hole and end all life on (and around) earth?
I think I have that, hence the delays in my projects.
|
|
|
|
|
maze3 wrote: What is the phobia name for fear that the Large Hadron Collider will create a black hole and end all life on (and around) earth
Don't know, but it is a matter for conCERN
|
|
|
|
|
Had the examiner said your mother-in-law was in the next room, pissed as hell, you'd be distracted too.
Presence of your telephone only distracts if you allow it to. Same goes for email. Turn of the notification and do them in bulk. Most of them don't require immediate attention anyway.
Bastard Programmer from Hell 
If you can't read my code, try converting it here[^]
|
|
|
|
|
My smartphone distracts me a lot... when I want to be distracted.
* CALL APOGEE, SAY AARDWOLF
* GCS d--- s-/++ a- C++++ U+++ P- L- E-- W++ N++ o+ K- w+++ O? M-- V? PS+ PE- Y+ PGP t++ 5? X R++ tv-- b+ DI+++ D++ G e++>+++ h--- ++>+++ y+++* Weapons extension: ma- k++ F+2 X
* Never pay more than 20 bucks for a computer game.
* I'm a puny punmaker.
|
|
|
|
|
maze3 wrote: "Don't think about a pin, elephant! What you thinking about?"
Well, I'm certainly not thinking about a pin! (And don't call me "elephant".) 
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
OMG - went back to fix that
"Don't think about a pink, elephant!"
then went back to finish your commnet, and realised I still had not fixed the issue. 
|
|
|
|
|
maze3 wrote: commnet
An NSA term?
"the debugger doesn't tell me anything because this code compiles just fine" - random QA comment
"Facebook is where you tell lies to your friends. Twitter is where you tell the truth to strangers." - chriselst
"I don't drink any more... then again, I don't drink any less." - Mike Mullikins uncle
|
|
|
|
|
Spiders are much more intelligent than smart-phones.
«Beauty is in the eye of the beholder, and it may be necessary from time to time to give a stupid or misinformed beholder a black eye.» Miss Piggy
|
|
|
|
|
For the arachnophobia, or the person telling that?
"If you don't fail at least 90 percent of the time, you're not aiming high enough."
Alan Kay.
|
|
|
|
|
"The horn of Adam" is an example of this type of game?
(5, 6, 7)
modified 26-Jun-17 5:01am.
|
|
|
|
|
First Person Shooter
Adam = first person
and his horn is his hooter - First Person's Hooter.
Andy B
|
|
|
|
|
|
|
![Rose | [Rose]](https://codeproject.freetls.fastly.net/script/Forums/Images/rose.gif)
#SupportHeForShe
Government can give you nothing but what it takes from somebody else. A government big enough to give you everything you want is big enough to take everything you've got, including your freedom.-Ezra Taft Benson
You must accept 1 of 2 basic premises: Either we are alone in the universe or we are not alone. Either way, the implications are staggering!-Wernher von Braun
|
|
|
|
|
At my new work they like each new commit to go through a code review in a shelveset before making it to the dev branch.
Unfortunately code review are done very slowly, sometimes taking up to 2 weeks, and that cause me a lot of trouble when merging back since incompatible change have been introduce since then...
How do you tackle that problem?
One idea which just strikes me is that maybe I could delay my own reviews of my team mate's code, until my own code has been reviewed... this way I prevent introduction of incompatible change...
|
|
|
|
|
Is it supposed to take up to 2 weeks? In general if you're forced to make yourself and by proxy the project less efficient to conform to the standards, the standards are wrong and need to be addressed. Best of luck though!
EDIT: Less efficient within reason, obviously. But if the standard operating procedure leads to constant merge conflicts and a two week delay, that's definitely not within reason in my opinion.
|
|
|
|
|
Code reviews should not take 2 weeks. Your "new work" is doing it wrong.
Super Lloyd wrote: How do you tackle that problem?
If they are doing code reviews in 2 weeks, then what other things are they doing wrong? Talk to the right person about this, I guess, and let them know what you are thinking.
It sounds to me as if your branching methodology may not be correct either, but I have very little to go on here. Remember, if someone else got there code review done before you and there work is QA tested clean and accepted, then you could merge there changes into yours, so that your code "works".
Also, why can't you fix the merge conflicts? It is not a good idea to have multiple people working on separate tasks that revolve around the same code base or bases. That never ends well and is the product of poor project management.
|
|
|
|
|
Taking 2 weeks is just bad. Either your review process way too slow/under-prioritized. Or your commits are way to big. Smaller commits are easier to review. If you have a rule saying "Only 100% functional units can be committed to master" then that rule is counter-productive.
... such stuff as dreams are made on
|
|
|
|
|
megaadam wrote: Smaller commits are easier to review.
|
|
|
|
|
You should re-balance your workload for such intervalls. Do someprototyping classes and functions for the next move.
Maybe I would think about this company is the right for me and my future. 
Press F1 for help or google it.
Greetings from Germany
|
|
|
|
|
Super Lloyd wrote: code review are done very slowly, sometimes taking up to 2 weeks
Two things - 1) that's just stupid, 2) how stupid are the people you work with to tolerate this?
Sorry about my bluntness. 
Marc
Latest Article - Create a Dockerized Python Fiddle Web App
Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny
Artificial intelligence is the only remedy for natural stupidity. - CDP1802
|
|
|
|
|
Super Lloyd wrote: sometimes taking up to 2 weeks
Super Lloyd wrote: How do you tackle that problem?
Change the process or get a new job. You can't possibly keep dealing with conflicts like that.
There are two kinds of people in the world: those who can extrapolate from incomplete data.
There are only 10 types of people in the world, those who understand binary and those who don't.
|
|
|
|
|
How often have these code reviews revealed anything worthwhile?
I'm asking as someone who's never gone through a code review.
|
|
|
|
|
To make a blanket statement that 2 weeks to do a code review is wrong is, well... wrong.
What if it is an a nuclear or other critical environment?
Having said that, the code review time frame should be as fast or faster than the development environment. If the code review is taking longer, then management needs to adjust priorities.
I am working on a project that has multiple event based calculations; the process was falling behind because the calculations could to be processed as fast as they were received. We had to rework the calculations to get them processed in a more efficient manner... you have the same situation; your 'events' are code waiting to be reviewed; your 'review' is your calculation... something needs to be adjusted.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
