|
i don't think a couple of spurious enumerator creations are the real perf bottleneck here. 
When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.
|
|
|
|
|
I've said it before and I'll copy/paste it again:
"
always remember and never forget that the readability of foreach comes at the cost of being slower than for -- that really is a 20x difference
"
YMMV
|
|
|
|
|
in my experience the 20x difference comes when you're doing lots and lots of nested foreach operations, like doing a ton of functional style queries, due to the heap pressure of all those object creation and destructions.
in truth, that function was whipped together in a few minutes so I just didn't bother with for loops.
I only think about performance in terms of linear vs log times - basically mathematical complexity of functions.
Beyond that, I profile. So for code like this it gets changed if and when it needs to be.
However, given the nested nature of this call it is probably best to change it to for loops early on.
When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.
|
|
|
|
|
One quick improvement: pre-allocate the inner List<string> to the correct size:
var finalList = new List<string>(leftList.Count + rightList.Count);
That way, it doesn't have to dynamically reallocate the backing array every time it runs out of space. 
(It probably won't make a huge difference when you're calling AddRange with something that implements ICollection<T>, but every little helps.)
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
i tried that, and it didn't change things. I think it's because the list sizes are usually only one or two elements and the min starting capacity is higher than that.
At least with ArrayList i remember it being something like 16 but I don't remember looking at List's sourcecode or disassembly so I couldn't say.
When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.
|
|
|
|
|
Add a Thread.Sleep in the inner loop to cool things down a bit.
|
|
|
|
|
I think my better option is to reduce the number of times I'm calling it. =)
and probably split it across multiple cores
When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.
|
|
|
|
|
Your biggest sin is not using brackets around your (now single line) if and for statements...
It's a bug waiting to happen (learned this the hard way) 
BURN THE WICKED WITCH!!! 
|
|
|
|
|
ugh i hate extra brackets
When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.
|
|
|
|
|
Was the French Revolution a European Ferris wheel?
Sent from my Amstrad PC 1640
Never throw anything away, Griff
Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
No, a French Revolution is what riders in Le Tour make millions of.
Whenever you find yourself on the side of the majority, it is time to pause and reflect. - Mark Twain
|
|
|
|
|
Eye don't think so since it ended up in London.
Socialism is the Axe Body Spray of political ideologies: It never does what it claims to do, but people too young to know better keep buying it anyway. (Glenn Reynolds)
|
|
|
|
|
I'm betting it was nowhere near as fun. Depending on who you might have been.
|
|
|
|
|
OTOH:
defending your castle with boiling oil/tar,
pouring it onto the revolting peasants below,
who knew 2 horrible items could be combined into something so nice:
french fries.
Message Signature
(Click to edit ->)
|
|
|
|
|
Then this upcoming (December) movie may be just the ticket to your own funeral you've been saving up for: [^].
Think how satisfied you will be with the precious gift of life, as you depart this vale of sorrows in which so many kittens die every day, knowing your cats are well provided for after your exit, and that Sekhmet, the protective aspect of Bastet, will guard you through your passage in the underworld as you move toward judgement in the Hall of Maat.
This sweet satisfaction: consider how even more honeyed it shall be knowing that you will never see the abomination known as Taylor Swift degrading the sacred nature of Catness with her dreadful mixture of botox, off-key singing, spastic dancing, and paparazzi fueled sneering self-intoxication !
Surely your soul will pass the test of being weighed against the feather of Maat, and you will be allowed rebirth.
Meow !
«Where is the Life we have lost in living? Where is the wisdom we have lost in knowledge? Where is the knowledge we have lost in information?» T. S. Elliot
|
|
|
|
|
Sorry, but I'm a staunch member of the Young Men's Reformed Cultists of the Ichor God Bel-Shamharoth.
Sent from my Amstrad PC 1640
Never throw anything away, Griff
Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
You deny, then, that you worship cats, and abjure Taylor Swift ?
«Where is the Life we have lost in living? Where is the wisdom we have lost in knowledge? Where is the knowledge we have lost in information?» T. S. Elliot
|
|
|
|
|
Of course! Worship is Herself's job ...
Sent from my Amstrad PC 1640
Never throw anything away, Griff
Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
The good thing is that nowadays you don't need to paint all that stuff on the walls of your burial chamber - you just need to slip a copy of Mr. E. A. Wallis Budge's eminent tome in your coffin for future reference.
|
|
|
|
|
Interesting, the many post-death manuals were for the living, as preparation for the deceased's bewildering encounter with the underworld (Duat), as well as the dead. It was believed that the family of the deceased could help the deceased through their understanding of these texts.
But, the use of Texts as decorations in tombs was limited to Pharaohs (who had a unique after-death journey), and the powerful. The "Pyramid Texts" were, originally only for Pharaohs.
Other classes got coffins, and these were usually decorated with spells, as well as excerpts from post-death guides.
The "Book of the Dead" is a later mix of spells and how-to's: an evolved collection from many sources, shaped by unknown editors/compilers, as most so-called "sacred scriptures" are. Its spells were used by all classes.
Alas, Budge, the despicable looter, stole the "Papyrus of Ani" from the Egyptians, cutting it into pieces to ship back to England. I am sure Anubis bites his head off daily.
«Where is the Life we have lost in living? Where is the wisdom we have lost in knowledge? Where is the knowledge we have lost in information?» T. S. Elliot
|
|
|
|
|
BillWoodruff wrote: Alas, Budge, the despicable looter, stole the "Papyrus of Ani" from the Egyptians, cutting it into pieces to ship back to England. I am sure Anubis bites his head off daily.
Stealing it wasn't so bad - after all, the very best of folks have stolen stuff from time to time, but cutting it up was a truly transcendent crime.
Anyway, forget Anubis, he was Greekified and therefore a bit more civilised. The original - Anpu - could summon up far, far nastier things than a mere biting off of the head.
|
|
|
|
|
@Chris-C-BChris C-B wrote: Stealing it wasn't so bad - after all, the very best of folks have stolen stuff from time to time,
Please leave your door unlocked, and your credit cards in plain sight, and let me know when you are not home, so I can improve myself  Chris C-B wrote: forget Anubis, he was Greekified
The use of the commonly used spelling of today should not distract an informed reader from the clear meaning of my statement in the context of the millenia of pre-Ptolemaic Egyptian religion where Anubis was known as "a God who swallows millions."
The "casting" of the golden wolf of Africa (mistakenly identified as a 'jackal') [^], a feared scavenger of the buried dead, as Anubis, divine protector of the dead, is a very interesting example of what I call "paradoxical juxtaposition of antipodes" in myth.
«Where is the Life we have lost in living? Where is the wisdom we have lost in knowledge? Where is the knowledge we have lost in information?» T. S. Elliot
|
|
|
|
|
Bast was shown as a lioness, especially in earlier periods, known for laying the hearts of evil ones at the feet of the king. "Can I haz offendr hartz?" Her city was in the delta, while Sekhmet was more of a southern goddess originally.
Budge's books were bad when written and are worse now, but keep getting reprinted because they're public domain. Mention Budge to an Egyptologist and watch for fun reactions (be ready to duck).
Ihy would be the god to call on for defense against bad singing. Add his mom Hathor for a double-whammy!
|
|
|
|
|
@PaulKemner @User-10966534
The real problem I have with ancient Egypt is that I wasn't there 
My impression is that Sekhmet is the leonine aspect of Bast/et, or vice-versa.
In reality, even with the best archaeological evidence, it is often hard to discern how/when/where the overdetermined multiple layers of iconic representations originated, and which were salient for different social classes in different periods.
There is often a continuity in "little tradition" iconography that is probably "lost to us" forever in the shadows of "great tradition" semiotics.
Ancient geo-politics, trade routes, unique cultural contacts, top-down re-formulations of iconography (as, for example, the Mesopotamian priest of Bel-Marduk, Berosus, performed for Ptolemy I Soter of Egypt) ... it's a soup for nuts I always find tasty
btw, the image of a male human-lion chimera is of great interest to me, going back to the ivory Löwenmensch figurine of the Hohlenstein-Stadel circa 40,000 BCE [^] ... and its many later manifestations, as in the headgear of Herakles, the lion-headed man encircled by twining serpents in the Mithraic tradition, etc.
«Where is the Life we have lost in living? Where is the wisdom we have lost in knowledge? Where is the knowledge we have lost in information?» T. S. Elliot
modified 25-Jul-19 14:44pm.
|
|
|
|
|
If your significant other asks you to do an unpleasant chore and you botch it up bad enough they'll never ask you to do it again.
Technician
1. A person that fixes stuff you can't.
2. One who does precision guesswork based on unreliable data provided by those of questionable knowledge.
JaxCoder.com
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
