C / C++ / MFC

softwaremonkey2-Jan-09 4:20

softwaremonkey

2-Jan-09 4:20

Its OK, I figured it out. It was nothing to do with the DECLARE_SERIAL and IMPLEMENT_SERIAL macros

DUH!
Wink | ;)

CPallini2-Jan-09 4:43

CPallini

2-Jan-09 4:43

Good to know.
IMHO object serialization is one of most appealing features of MFC.

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.

This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke

[My articles]

Iain Clarke, Warrior Programmer

Iain Clarke, Warrior Programmer2-Jan-09 11:25

2-Jan-09 11:25

CPallini wrote:
IMHO object serialization is one of most appealing features of MFC.

I've never used it after initial learning. I'm too much of a file format control freak...

Iain.

WM_LBUTTONDOWN not working with CListCtrl class!!

CPallini2-Jan-09 20:55

CPallini

2-Jan-09 20:55

I like to have control on file format too. Anyway, automatic object (re-)creation is too appealing to me.
Smile | :)

SanjaySMK2-Jan-09 3:28

Re: WM_LBUTTONDOWN not working with CListCtrl class!!

2-Jan-09 3:28

Hello,
I have some code which has a dialog box and a list control placed on it, and I handled the WM_LBUTTONDOWN message on it, which perfectly executed when the code was compiled in Visual C++ 6.0. But the same code, when ported to VS 2005, does not respond to this message at all, although the code compiles and links fine in VS 2005. I tried to handle the notification message, NM_CLICK also, on the List Control which is on the dialog box, but to no avail. What must be the problem?

Please suggest the remedy.

Thanks,

Software Developer
Sanjay Khapre

Nibu babu thomas2-Jan-09 4:52

Nibu babu thomas

2-Jan-09 4:52

From whatever you've said looks like it should work and can't guess anything else, we need more information on how you are calling/showing this dialog.

Nibu babu thomas
Microsoft MVP for VC++

Code must be written to be read, not by the compiler, but by another human being.

Programming Blog: http://nibuthomas.wordpress.com

Re: WM_LBUTTONDOWN not working with CListCtrl class!!

Mark Salsbery2-Jan-09 5:50

Re: WM_LBUTTONDOWN not working with CListCtrl class!!

2-Jan-09 5:50

Where are you handling (or trying to handle) these messages....in the dialog class or
a CListCtrl-derived class?

Mark

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

SanjaySMK3-Jan-09 21:48

Re: WM_LBUTTONDOWN not working with CListCtrl class!!

3-Jan-09 21:48

I am handling WM_LBUTTONDOWN message in a CListCtrl-derived class, but not getting why it's not working. When this project was in Visual C++ 6.0, it was running fine, but now that I have converted this to Visual C++ 2005, it is failing to run, although it compiles fine, and creates the DLL.

Software Developer
Sanjay Khapre

Mark Salsbery4-Jan-09 6:09

Re: WM_LBUTTONDOWN not working with CListCtrl class!!

4-Jan-09 6:09

This works for me - all the message/notification handlers get called:

//
// ReflectedListCtrl.h
//

#pragma once

class CReflectedListCtrl : public CListCtrl
{
	DECLARE_DYNAMIC(CReflectedListCtrl)

public:
	CReflectedListCtrl();
	virtual ~CReflectedListCtrl();

protected:
	DECLARE_MESSAGE_MAP()
public:
	afx_msg void OnLButtonDown(UINT nFlags, CPoint point);
	afx_msg void OnNMClick(NMHDR *pNMHDR, LRESULT *pResult);
	afx_msg void OnNMRClick(NMHDR *pNMHDR, LRESULT *pResult);
};




//
// ReflectedListCtrl.cpp
//

#include "stdafx.h"
#include "MyApp.h"
#include "ReflectedListCtrl.h"


// CReflectedListCtrl

IMPLEMENT_DYNAMIC(CReflectedListCtrl, CListCtrl)

CReflectedListCtrl::CReflectedListCtrl()
{
}

CReflectedListCtrl::~CReflectedListCtrl()
{
}

BEGIN_MESSAGE_MAP(CReflectedListCtrl, CListCtrl)
	ON_WM_LBUTTONDOWN()
	ON_NOTIFY_REFLECT(NM_CLICK, &CReflectedListCtrl::OnNMClick)
	ON_NOTIFY_REFLECT(NM_RCLICK, &CReflectedListCtrl::OnNMRClick)
END_MESSAGE_MAP()


// CReflectedListCtrl message handlers

void CReflectedListCtrl::OnLButtonDown(UINT nFlags, CPoint point)
{
	CListCtrl::OnLButtonDown(nFlags, point);
}

void CReflectedListCtrl::OnNMClick(NMHDR *pNMHDR, LRESULT *pResult)
{
	// TODO: Add your control notification handler code here
	*pResult = 0;
}

void CReflectedListCtrl::OnNMRClick(NMHDR *pNMHDR, LRESULT *pResult)
{
	// TODO: Add your control notification handler code here
	*pResult = 0;
}

What are you doing different? If the message handlers don't get called,
does the constructor ever get called? Is the control being created successfully?

Mark

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

SanjaySMK4-Jan-09 21:33

Re: WM_LBUTTONDOWN not working with CListCtrl class!!

4-Jan-09 21:33

Yes Mark,
Thanks a ton for the code snippet. I have the same code snippet, and as you asked, the required no. of CListCtrl-derived class objects are also getting created successfully, but still the events, WM_LBUTTONDOWN and WM_LBUTTONDBLCLK for those objects are not getting invoked in Visual C++ 2005! I am puzzled, why is this happening!

Warm regards,

Software Developer
Sanjay Khapre

Mark Salsbery4-Jan-09 21:44

Re: WM_LBUTTONDOWN not working with CListCtrl class!!

4-Jan-09 21:44

SanjaySMK wrote:
the required no. of CListCtrl-derived class objects are also getting created successfully

Are you sure? How are you verifying that?

What code are you using to create your custom control class?

If the controls are in a dialog, how are you associating your
custom control class with a control on the dialog?

I tested on a dialog by adding this member to the dialog class

CReflectedListCtrl m_ListCtrl;

and associating it with a ListView control on the dialog resource by
adding this to the dialog class' DoDataExchange()

DDX_Control(pDX, IDC_LIST1, m_ListCtrl);

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

SanjaySMK4-Jan-09 22:16

Re: WM_LBUTTONDOWN not working with CListCtrl class!!

4-Jan-09 22:16

I called a message box from within the constructor of CListCtrl-derived class for which I declared two objects in its parent dialog class, and on both of their construction, I get this message box twice. That's how I ensured.

Software Developer
Sanjay Khapre

Mark Salsbery5-Jan-09 5:59

Re: WM_LBUTTONDOWN not working with CListCtrl class!!

5-Jan-09 5:59

That covers the C++ object....you also need the HWND object.

Again, how are you associating the control with the C++ object?

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

SanjaySMK5-Jan-09 21:24

Re: WM_LBUTTONDOWN not working with CListCtrl class!!

5-Jan-09 21:24

I am subclassing both CListCtrl-derived class and the Combo box objects.

Software Developer
Sanjay Khapre

Mark Salsbery6-Jan-09 5:03

Re: WM_LBUTTONDOWN not working with CListCtrl class!!

6-Jan-09 5:03

Still not answering my question however Smile | :)

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

SanjaySMK6-Jan-09 19:43

Re: WM_LBUTTONDOWN not working with CListCtrl class!! [modified]

6-Jan-09 19:43

Sorry if I haven't answered your last question. The thing is, that subclassing is used in case of CListCtrl-derived class, the reason why I don't see its varible entries inside DoDataExchange, hence the problem. That means the requirement is that of making LBUTTONDOWN and LBUTTONDBLCLK work with subclassed windows of CListCtrl-derived class. Can you help me out with this?

Thanks in advance.

Software Developer
Sanjay Khapre

Mark Salsbery6-Jan-09 20:33

Re: WM_LBUTTONDOWN not working with CListCtrl class!! [modified]

6-Jan-09 20:33

You have to add the entries to DoDataExchange if they are not there.

If the listview controls are in the dialog resource, you can use the wizard
to add a control variable. It will add an entry like

DDX_Control(pDX, IDC_LIST1, m_ListCtrl);

Change m_ListCtrl's type to your derived type in the header file.
Then the control will be subclassed.

From my previous working sample code:

// In the dialog class
	CReflectedListCtrl m_ListCtrl;


// The dialog class' DoDataExchange() override
void CMyDialog::DoDataExchange(CDataExchange* pDX)
{
	CDialog::DoDataExchange(pDX);
	DDX_Control(pDX, IDC_LIST1, m_ListCtrl);
}

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

modified on Wednesday, January 7, 2009 2:40 AM

SanjaySMK7-Jan-09 21:27

Re: WM_LBUTTONDOWN not working with CListCtrl class!! [modified]

7-Jan-09 21:27

In which case CWnd::SubclassWindow(HWND DocumentList) fails? Even though, the variable HWND DocumentList which I am using as its parameter is locally declared and initialized where I am calling SubclassWindow, still SubclassWindow is failing(Debug Assertion Failure!). What is its remedy? Could u please suggest?
DocumentList parameter is declared and initialized some lines before calling SubclassWindow, as following:

HWND DocumentList = CreateDocumentList(parenthandle, rect.left, rect.top, rect.Width(), rect.Height(), someflag) ;

Line 1
Line 2
Line 3

SubclassWindow(DocumentList) ; // which fails here, why?

Software Developer
Sanjay Khapre

modified on Thursday, January 8, 2009 5:24 AM

SanjaySMK8-Jan-09 1:26

Re: WM_LBUTTONDOWN not working with CListCtrl class!!

8-Jan-09 1:26

I got the answer of why SubclassWindow was failing, it was because I had DDX_Control entries inside DoDataExchange function, which shouldn't be there, otherwise the parameter to SubclassWindow will always be attached to the parent dialog box, which doesn't fit its criterion. But now after that, the messages WM_LBUTTONDOWN and WM_LBUTTONDBLCLK should run, which are not running. That means my question is, after calling CWnd::SubclassWindow function, why these two messages do not respond at all?Please suggest some remedy.

Software Developer
Sanjay Khapre

modified on Thursday, January 8, 2009 9:34 AM

Mark Salsbery8-Jan-09 4:35

Re: WM_LBUTTONDOWN not working with CListCtrl class!!

8-Jan-09 4:35

Why are you calling SubclassWindow?

If you're using MFC you very rarely need to explicitly call it.

Mark

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

Mark Salsbery8-Jan-09 4:42

Re: WM_LBUTTONDOWN not working with CListCtrl class!!

8-Jan-09 4:42

Where is this code called from? You really need to provide a context.
If SubclassWindow is the CWnd SubclassWindow method, then what's the class you are
calling it from?

SanjaySMK wrote:
which fails here, why?

Why don't you step into the function with the debugger and find out? Smile | :)

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

SanjaySMK8-Jan-09 18:18

Re: WM_LBUTTONDOWN not working with CListCtrl class!!

8-Jan-09 18:18

I have a method in CListCtrl-derived class, from where I am calling CWnd::SubclassWindow, and after calling that, WM_LBUTTONDOWN and WM_LBUTTONDBLCLK do not get called at all.

Software Developer
Sanjay Khapre

Mark Salsbery9-Jan-09 5:31

Re: WM_LBUTTONDOWN not working with CListCtrl class!!

9-Jan-09 5:31

You still haven't answered WHY you are calling SubclassWindow.

Where do the CListCtrl derived objects come from? Show some code.

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

SanjaySMK13-Jan-09 23:12