Refactor the code with loop?

Question

1.00/5 (1 vote)

See more:

I have a method.

C#

public void AddForegroundColor(ColoredConsoleTarget coloredConsoleTarget)
       {
           var consoleColors = _loggerModel.console_color;
           List<ConsoleOutputColor> consoleOutputColorList = new List<ConsoleOutputColor>();
           ConsoleOutputColor traceForegroundColor;
           ConsoleOutputColor infoForegroundColor;
           ConsoleOutputColor debugForegroundColor;
           ConsoleOutputColor warnForegroundColor;
           ConsoleOutputColor errorForegroundColor;
           ConsoleOutputColor fatalForegroundColor;
           ConsoleOutputColor.TryParse(consoleColors.TRACE, true, out traceForegroundColor);
           ConsoleOutputColor.TryParse(consoleColors.INFO, true, out infoForegroundColor);
           ConsoleOutputColor.TryParse(consoleColors.DEBUG, true, out debugForegroundColor);
           ConsoleOutputColor.TryParse(consoleColors.WARN, true, out warnForegroundColor);
           ConsoleOutputColor.TryParse(consoleColors.ERROR, true, out errorForegroundColor);
           ConsoleOutputColor.TryParse(consoleColors.FATAL, true, out fatalForegroundColor);
           consoleOutputColorList.Add(traceForegroundColor);
           consoleOutputColorList.Add(infoForegroundColor);
           consoleOutputColorList.Add(debugForegroundColor);
           consoleOutputColorList.Add(warnForegroundColor);
           consoleOutputColorList.Add(errorForegroundColor);
           consoleOutputColorList.Add(fatalForegroundColor);
           AddConsoleRowHighlightingRule(coloredConsoleTarget, consoleOutputColorList);
       }

I felt it is dirty, can we clean it? I guess using for loop or so?

Posted 6-Jul-15 10:28am

zhshqzyc

Add a Solution

Comments

[no name] 6-Jul-15 16:40pm

Not seeing where you think a loop would help anything. Using an object initializer for your list would but a loop...?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Philippe Mori · Accepted Answer · 2015-07-06T13:40:00

Assuming that consoleColors item are of type ConsoleColorType, something like that could be used:

C#

 public void AddForegroundColor(ColoredConsoleTarget coloredConsoleTarget)
{
    var consoleColors = _loggerModel.console_color;
    var colorTypes = new ConsoleColorType[]
    {
        consoleColors.TRACE,
        consoleColors.INFO,
        consoleColors.DEBUG, 
        consoleColors.WARN,
        consoleColors.ERROR,
        consoleColors.FATAL,
    };


    var consoleOutputColorList = new List<consoleoutputcolor>();

    foreach (var item in colorTypes)
    {
        ConsoleOutputColor traceColor;
        ConsoleOutputColor.TryParse(item, true, out traceColor);

        consoleOutputColorList.Add(traceColor);
    }

    AddConsoleRowHighlightingRule(coloredConsoleTarget, consoleOutputColorList);
}

Make any necessary adjustment depending on color types.

Update: Since strings are used, the following line

C#

var colorTypes = new ConsoleColorType[]

should be change for

C#

var colorTypes = new string[]