How to debug code effieciently

Question

1.00/5 (1 vote)

See more:

I'm currently trying to debug the return statement for my last line of code. I'm currently receiving a System.FormatExceptionError thrown there. I've been told that the return statement, as is currently, is attempting to accomplish 3 things. In order to know where the error is being thrown, I believe I need to execute those 3 things in separate return statements. Here's the code:

C#

public int UpdateConnectionType(int connectionTypeID, string lastUpdatedBy, string connectionTypeDesc, bool isDisabled )
        {
            var sqlStatement = new StringBuilder();

            sqlStatement.Append(" UPDATE dbo.ConnectionType");
            sqlStatement.Append("   SET");
            sqlStatement.Append(" LastUpdatedBy = @LastUpdatedBy, ");
            sqlStatement.Append(" ConnectionTypeDesc = @ConnectionTypeDesc,");
            sqlStatement.Append(" IsDisabled = @IsDisabled, ");
            sqlStatement.Append(" LastUpdatedDate = GetDate() ");
            sqlStatement.Append(" WHERE ");
            sqlStatement.Append("   ConnectionTypeID = @ConnectionTypeID");
            sqlStatement.Append(" SELECT @@Identity");

            SqlCommand sqlCommand = new SqlCommand(sqlStatement.ToString());
            var sqlParams = new List<SqlParameter>();

            sqlParams.Add(new SqlParameter() { ParameterName = "@ConnectionTypeID", SqlDbType = SqlDbType.Int, Value = connectionTypeID });
            sqlParams.Add(new SqlParameter(){ParameterName = "@IsDisabled", SqlDbType = SqlDbType.Bit, Value = isDisabled});
            sqlParams.Add(new SqlParameter() {ParameterName = "@LastUpdatedBy", SqlDbType = SqlDbType.VarChar, Size = 200, Value = lastUpdatedBy });
            sqlParams.Add(new SqlParameter() { ParameterName = "@ConnectionTypeDesc", SqlDbType = SqlDbType.VarChar, Size = 100, Value = connectionTypeDesc});

            sqlCommand.Parameters.AddRange(sqlParams.ToArray());

            //int result = DBAccess.SQLServer.GetInteger(DBAccess.SQLServer.GetConnectionString("AccountTracker"), sqlCommand);
            return DBAccess.SQLServer.GetInteger(DBAccess.SQLServer.GetConnectionString("AccountTrackerDB"), sqlCommand);
        }

My questions are:
1) What 3 things is my return statement trying to accomplish? (I believe it's attempting to get the ID, and then update the corresponding record within the database)
2)How would I write those 3 tasks into their own return statement? (I've taken one stab at it with the code that commented out) Thanks!

Posted 9-Jul-15 4:11am

Member 11820531

Add a Solution

Comments

[no name] 9-Jul-15 10:24am

Why are you using a StringBuilder? Just use a string. Use AddWithValue instead of your Adds
And your connection string is probably the culprit.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

phil.o · Answer 1 · 2015-07-09T04:21:00

Solution 1

I cannot see three but rather two actions that could be separated from the return statement:

C#

string connectionString = DBAccess.SQLServer.GetConnectionString("AccountTrackerDB");
int result = DBAccess.SQLServer.GetInteger(connectionString, sqlCommand);
return result;

This way you will have the ability to check the content of the variables before they are used and returned.

Posted 9-Jul-15 4:21am

phil.o

Comments

Member 11820531 9-Jul-15 10:38am

Thanks that works for debugging purposes. I know for sure the connection string is working fine and result is being set = to 0. However, I'm still getting the exception thrown and my IsDisabled field is not being updated. Thanks for the code though it helped confirm that some things are acting as I want.