How Do I Get A Button To Open A New Form But Only If Textboxes Are Filled In

Question

0.00/5 (No votes)

See more:

Hi all, okay so i have this layout/ a button and 2 textfields, my plan is when both text fields are empty and you click the button a error message opens up, my problem is that when i click the button i get the message , when i click ok the next form still opens. my code"

if (string.IsNullOrEmpty(txtPassword.Text) || (string.IsNullOrEmpty(textbox8.Text)))
                MessageBox.Show("field empty.", "Error", MessageBoxButtons.OK, MessageBoxIcon.Warning);
            Files mf = new Files();
            Hide();
            mf.ShowDialog();
            Close();

thanks,

Posted 16-Jul-15 22:39pm

jamesmc1535

Updated 16-Jul-15 23:00pm

Abhishek Pant

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Godhaniketan · Accepted Answer · 2015-07-16T22:58:00

Solution 1

//reffer below code......

C#

private void btn_Click(object sender, EventArgs e)
        {
            Files mf = new Files(); //form object
            if (string.IsNullOrEmpty(txtPassword.Text) || (string.IsNullOrEmpty(textbox8.Text)))
            {
                MessageBox.Show("field empty.", "Error", MessageBoxButtons.OK, MessageBoxIcon.Warning);
            }
            else
            {
                mf.ShowDialog(); //show dialog
            }
        }

Posted 16-Jul-15 22:58pm

Godhaniketan

Comments

jamesmc1535 17-Jul-15 5:02am

aah thanks man

[no name] 17-Jul-15 5:04am

you are most welcome please mark answer as solution..!
:)

jamesmc1535 17-Jul-15 6:06am

sorry uhm i used that code it works perfect but ive seen now that it diesnt close the 1st form, how do i make it close the form when i click the button?

OriginalGriff · Accepted Answer · 2015-07-16T22:59:00

Simple - add an else clause:

C#

if (string.IsNullOrEmpty(txtPassword.Text) || (string.IsNullOrEmpty(textbox8.Text)))
    MessageBox.Show("field empty.", "Error", MessageBoxButtons.OK, 
else
    {
    MessageBoxIcon.Warning);
    Files mf = new Files();
    Hide();
    mf.ShowDialog();
    Close(); 
    }

BTW: it's a good idea (especially when you are just starting out) to always add the curly brackets, even if it's just one line:

C#

if (string.IsNullOrEmpty(txtPassword.Text) || (string.IsNullOrEmpty(textbox8.Text)))
    {
    MessageBox.Show("field empty.", "Error", MessageBoxButtons.OK,
    }
else
    {
    MessageBoxIcon.Warning);
    Files mf = new Files();
    Hide();
    mf.ShowDialog();
    Close();
    }

That way, it's immediately obvious what is expected to happen.
And please, do yourself a favour, and stop using Visual Studio default names for everything - you may remember that "TextBox8" is the mobile number today, but when you have to modify it in three weeks time, will you then? Use descriptive names - "tbMobileNo" for example - and your code becomes easier to read, more self documenting, easier to maintain - and surprisingly quicker to code because Intellisense can get to to "tbMobile" in three keystrokes, where "TextBox8" takes thinking about and 8 keystrokes...