if form is open create picturebox

Question

1.00/5 (1 vote)

See more:

so i am making a program that requires me to check if a form is open and if that is true then create a picturebox. right now i have this code

VB

Private Sub MyBase_load(Sender As Object, E As EventArgs) Handles MyBase.Load

    For Each form In My.Application.OpenForms
        If (form.name = Me.Name) Then
            'form is loaded so can do work
            Dim Logo As New PictureBox
            Logo.BackgroundImage = My.Resources.ChangeWallpaperlogojpg
            Logo.Visible = True
            Logo.Width = 32
            Logo.Height = 32
            Logo.Location = New Point(72, 136)
            Controls.Add(Logo)

        End If
    Next
End Sub

But this doesnt work

Anyone know the answer?

Posted 27-Jul-15 7:11am

Member 11852402

Updated 27-Jul-15 7:24am

v3

Add a Solution

Comments

Aravindba 28-Jul-15 3:18am

Hi First check if break point reach the Dim Logo As New PictureBox line ?,increase width and height of picturebox.
or try like this

Private Sub MyBase_load(Sender As Object, E As EventArgs) Handles MyBase.Load

'form is loaded so can do work
Dim Logo As New PictureBox
Logo.BackgroundImage = My.Resources.ChangeWallpaperlogojpg 'This file name is correct ? without extension
Logo.Visible = True
Logo.Width = 32
Logo.Height = 32
Logo.Location = New Point(72, 136)
Controls.Add(Logo)

End Sub

without checking if condition,try to run

2 solutions

Solution 1

One obvious problem is that you create a picture box put you don't put it anywhere so it won't be visible. Try adding the picture box to the controls collection.

See Form.ControlCollection Class[^]

Another thing is that you're investigating the forms when the new form is already loading. BAsed on your requirements would it make more sense to investigate the existence before loading a new form?

Posted 27-Jul-15 7:16am

Wendelius

Updated 27-Jul-15 7:19am

v2

Comments

Member 11852402 27-Jul-15 13:20pm

it still doesnt work

Member 11852402 27-Jul-15 13:24pm

i added this:Controls.Add(Logo) and yet it doesnt show

Wendelius 27-Jul-15 13:32pm

Using debugger, have you checked that the code is executed correctly and that it is added on the correct forms collection?

Member 11852402 27-Jul-15 13:41pm

sorry, im quite new to vs. how would i do that?

Wendelius 27-Jul-15 13:53pm

In that case I suggest going through some tutorial in debugging, like http://www.visual-basic-tutorials.com/beginner/Debugging.html[^]

Knowing how to debug efficiently is going yo save you a lot of time in the future :)

Member 11852402 27-Jul-15 14:06pm

okay ive done it and everything is okay. but it still doesnt show :(.
I really appreciate your help

Wendelius 27-Jul-15 14:17pm

The code where you add the logo is the load of a form. Are you sure that this form is really shown at some point?

Member 11852402 27-Jul-15 14:23pm

yeah cause i can see it

Wendelius 27-Jul-15 14:55pm

I may be wrong but isn't the situation so that you have 2 of those forms, the one that was already open and the one that is opening. On which one the control is placed and do you see both of them?

Member 11852402 27-Jul-15 15:19pm

The control is placed on the One that is open and Yeah i see both

Wendelius 27-Jul-15 15:35pm

And you're sure nothing is blocking it in that position? Have a try with the following code fragment
Dim Logo As New PictureBox
Logo.BackgroundImage = My.Resources.ChangeWallpaperlogojpg
Logo.Visible = True
Logo.Width = 32
Logo.Height = 32
Logo.Location = New Point(72, 136)
Logo.BorderStyle = BorderStyle.Fixed3D 'add visible border
Controls.Add(Logo)
Logo.BringToFront() 'ensure that nothing is on top of logo

Member 11852402 27-Jul-15 15:44pm

i have the feeling somethings wrong with checking if the form has opened.i have created a new function to check that and yet it doesnt work

Member 11852402 27-Jul-15 15:46pm

there is something wrong with checking if the form is open. ive made a new function to check it and then i replace the if statement with a .show to see if it works but it doesnt so that is the problem

Wendelius 27-Jul-15 15:50pm

Place a breakpoint on line
Dim Logo As New PictureBox
does the program come to the breakpoint. If not, then the if condition isn't met.

Member 11852402 27-Jul-15 15:56pm

it doesnt come to it so it is the condition

Wendelius 27-Jul-15 16:01pm

In that case I suggest placing the breakpoint to the loop and investigate each of the form variables, what's the name of the form. This should clarify the behaviour.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Ralf Meier · Accepted Answer · 2015-07-27T20:17:00

I tested it by myself and this code is working :

VB

Private Sub MyBase_load(Sender As Object, E As EventArgs) Handles MyBase.load

    For Each form In Application.OpenForms
        If (form.name = Me.Name) Then
            'form is loaded so can do work
            Dim Logo As New PictureBox
             Logo.BackgroundImage = My.Resources.Resources.Desert
            Logo.Visible = True
            Logo.Width = 32
            Logo.Height = 32
            Logo.Location = New Point(72, 136)
            Controls.Add(Logo)
            'Logo.Parent = Me
        Else
        End If
    Next
End Sub

The difference I see is the name of the BackgroundImage. In my sample I don't use the Filename-Extension - perhaps you try it like this with your code (substrct the letters "jpg").

But this Logo is displayed ever. I think, you wish to see the Logo only if the Form is active. Therefore the code should have "some" modifications :

At first create the PictureBox called "Logo" as control on your Form.
Then insert this code to your Form (instead of the code seen above) :

VB

Protected Overrides Sub OnActivated(e As System.EventArgs)
    Logo.Visible = True
    MyBase.OnActivated(e)
  End Sub

Protected Overrides Sub OnDeactivate(e As System.EventArgs)
    Logo.Visible = False
    MyBase.OnDeactivate(e)
End Sub