How Would I Convert My For Loops To For Each Loop?

Question

0.00/5 (No votes)

See more:

I have made a diamond pattern program using for loop. I want to do it using foreach loop. Any one can please help me out how do i convert my for loops to foreach loop.

Here is code:

C#

Console.WriteLine("Program for displaying pattern of *.");

          Console.Write("Enter the maximum number of *: ");

          int n = Convert.ToInt32(Console.ReadLine());
          Console.WriteLine("\nHere is the Diamond of Stars\n");
          for (int i = 0; i <= (n - 1); i = i + 2)
          {
              for (int j = 0; j <= i; j++)
                  Console.Write("*");
              Console.WriteLine();
          }
          for (int i = n - 1; i >= 1; i = i - 2)
          {
              for (int j = 0; j < (i - 1); j++)
                  Console.Write("*");
              Console.WriteLine();
          }

Posted 4-Aug-15 0:20am

Member 11808002

Add a Solution

Comments

Tomas Takac 4-Aug-15 6:26am

Why do you want to use foreach when for works just fine?

Member 11808002 4-Aug-15 6:27am

for sake of practise.

F-ES Sitecore 4-Aug-15 6:36am

There is no direct foreach equivalent of what you're doing. You'd have to create a List<int> and add to the list the numbers 0, 2, 4, 6 etc etc, then do a foreach(int i in mylist) for the first loop, then reverse the list and do the same for the second loop. You could use an array of int[] rather than a List, I forget which out of arrays and List has a Reverse function.

Member 11808002 4-Aug-15 6:36am

Help me out please. I am stuck here

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2015-08-04T00:38:00

Solution 1

In those cases, it makes no sense to try: you aren't using a collection of objects, so there is no base for a foreach loop - these only work when you are iterating though a collection of objects that implements the IEnumerable or IEnumerable<T> interface.
Int32 doesn't do that, so you can't use a foreach to replace your for loops.

Posted 4-Aug-15 0:38am

OriginalGriff

Comments

Member 11808002 4-Aug-15 6:59am

You mean to say. I get value from user using array, and then i am able to do this task using foreach loop?

OriginalGriff 4-Aug-15 7:26am

Not realy - the user returns you a single number, not a collection of numbers. And there isn't really any way you can get the user to give you the "right" numbers as a collection without complicating your code horribly, and presuming that you hate your users! :laugh:

You could easily replace it with a while loop - but then you'd just be doing the three parts of the for loop manually instead of collected in a single place where it's easy to read.
The for loop is the right one for this exercise!
The change I would probably make would be to extract a method which printed a line "n" characters long, and call that in two places instead of your inner loops.

I'd also recommend that you always use curly brackets, even when you don't have to - until you are a little more experienced.
There is little more frustrating than trying to work out what is wrong because you add a line "inside" the loop or conditional and it doesn't get executed at the right time because there are no curly brackets! It's a little more typing - but hardly any - and it can save you hours of hair pulling followed by a "doh!" moment... :laugh: