how to prevent the thread throw exception?

Question

0.00/5 (No votes)

See more:

C#

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Text;
using System.Windows.Forms;
using System.Threading;

namespace ThreadTest
{
    public partial class Form1 : Form
    {
        Thread thTest;

        public Form1()
        {
            InitializeComponent();
            thTest = new Thread(new ParameterizedThreadStart(ThreadTest));
        }

        int i = 0;
        private void button1_Click(object sender, EventArgs e)
        {
            thTest.Abort();
            thTest = new Thread(new ParameterizedThreadStart(ThreadTest));

            i = 0;
            thTest.Start();
        }

        void ThreadTest(object oState)
        {
            while (true)
            {
                try
                {
                    Console.WriteLine((i++).ToString());
                    System.Threading.Thread.Sleep(0);
                }
                catch(Exception e)
                {
                    throw e;
                }
            }
        }
    }
}

when i first click the button,thread will run normal and the console output i++ value,when i second click the button ,the thread will throw exception.
how can i can immediately restart the thread and also prevent the thread throw exception ？

Posted 23-Aug-15 22:03pm

xuyunhai

Add a Solution

Comments

CPallini 24-Aug-15 4:59am

That's bad design, you should gracefully terminate the thread.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Andy Lanng · Accepted Answer · 2015-08-23T22:24:00

Ha - this age old issue.

As far as I can tell, there is no way to guarantee that a thread.abort() will ever actually be able to stop the thread process. It is much better to stop the threaded process yourself and wait for the thread to exit.

Something like this (this is how I do it atm):

C#

using System;
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Text;
using System.Windows.Forms;
using System.Threading;

namespace ThreadTest
{
    public partial class Form1 : Form
    {
        Thread thTest;

        public Form1()
        {
            thTest = new Thread(new ParameterizedThreadStart(ThreadTest));
        }

        int i = 0;
        private void button1_Click(object sender, EventArgs e)
        {
            //tell process to stop
            _cancelThread = true;

            //check process is running.  If so then wait
            if(_busy)
                _resetEvent.WaitOne();

            //start the new process
            thTest = new Thread(new ParameterizedThreadStart(ThreadTest));
            //reset the wait flag
            _resetEvent = new ManualResetEvent(false);

            i = 0;
            thTest.Start();
        }

        ManualResetEvent _resetEvent;  //Used to halt the calling thread until ThreadTest has finished
        bool _cancelThread; //Used to ask ThreadTest to stop
        bool _busy;  //Used to tell calling thread that ThreadTest is running

        void ThreadTest(object oState)
        {
            _busy = true;
            _cancelThread = false;
            while (!_cancelThread)
            {
                try
                {
                    Console.WriteLine((i++).ToString());
                    System.Threading.Thread.Sleep(0);
                }
                catch (Exception e)
                {
                    throw e;
                }
            }
            _busy = false;
            _resetEvent.Set();
        }
    }
}

Check out this article which goes over some of these principles:
Beginner's Guide to Threading in .NET: Part 3 of n[^]

Hope that helps ^_^
Andy