[Solved]Looping Linkbutton and Label using Data List

Question

1.00/5 (1 vote)

See more:

Hi,

I am trying to search the database using Data List and Item Template.

I just want to loop the data's from database in a linkbutton and a lable row by row.I am new to this.

C#

DataSet ds = new DataSet();
DataTable dt = new DataTable();
dt.Columns.Add(new DataColumn("Description", typeof(string)));
dt.Columns.Add(new DataColumn("Auctionno", typeof(string)));
dt.Columns.Add(new DataColumn("Location", typeof(string)));
SqlCommand cmd = new SqlCommand("select * from Auction_Upload where Keyword = '" + TextBox1.Text + "'", con);
con.Open();
SqlDataReader dr = cmd.ExecuteReader();
if(dr.Read())
{
DataRow dc = dt.NewRow();
dc["Description"] = dr["Description"].ToString();
dc["Auctionno"] = dr["Auctionno"].ToString();
dc["Location"] = dr["Location"].ToString();
dt.Rows.Add(dc);
}
DataList1.DataSource = dt;
DataList1.DataBind();

Please Help me in this
Thanks in advance

Posted 25-Aug-15 20:56pm

Prabhu92

Updated 26-Aug-15 1:12am

Sinisa Hajnal

v3

Add a Solution

Comments

DamithSL 26-Aug-15 3:08am

what is the issue with your code?

Prabhu92 26-Aug-15 3:10am

I just want to loop the linkbutton and lable using foreach. Need to display all the data's from database row by row

[no name] 26-Aug-15 4:35am

Do you want to create multiple linkbutton based on your result? Secondly you are looping over your results in code. Please describe when you display all data..

Prabhu92 26-Aug-15 4:55am

I want to display all the data from database. I mean all the rows

Prabhu92 26-Aug-15 5:03am

i have changed if condition to while and it worked. Thanks

Sinisa Hajnal 26-Aug-15 7:12am

Good for you. Please remove the question (delete) or mark it as solved (add [Solved] to the title) so that people don't stumble into it. Thank you

Richard Deeming 26-Aug-15 9:07am

Your code is vulnerable to SQL Injection[^].

NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Answer 1 · 2015-08-26T03:42:00

Please see the comment to the question by Richard Deeming.

Your approach is wrong from the very beginning. The query composed by concatenation with strings taken from UI. Not only repeated string concatenation is inefficient (because strings are immutable; do I have to explain why it makes repeated concatenation bad?), but there is way more important issue: it opens the doors to a well-known exploit called SQL injection.

This is how it works: http://xkcd.com/327.

Are you getting the idea? The string taken from a control can be anything, including… a fragment of SQL code.

What to do? Just read about this problem and the main remedy: parametrized statements: http://en.wikipedia.org/wiki/SQL_injection.

With ADO.NET, use this: http://msdn.microsoft.com/en-us/library/ff648339.aspx.

Please see my past answers for some more detail:
EROR IN UPATE in com.ExecuteNonQuery();,
hi name is not displaying in name?.

—SA