Hello, please help me with this program, I dont get it why it does not work.

Question

1.00/5 (2 votes)

See more:

C++

//Task : There is given square two-dimensional array: Find the biggest negative element and its array adress. 

#include < iostream>        
#include < iomanip>
#include < string>
using namespace std;
int main()
{
    int a[5][5];
    int did,n,m,i,j;

    cout<<"Type array measurements(max 5):" <<endl;
    cin>>m>>n;
    cout<<"Type array elements" <<endl;

    for(i=0;i<m;i++)
        for(j=0;j<n;++j)
            cin>>a[i][j];
    
    did = a[0][0];
    for (i=0; i < m; ++i)
    {
        for (j=0; j < n; ++j)
        {
            if (a[i][j] > did && a[i][j] < 0)
                did = a[i][j];
            i = m;
            j = n;
        }
    }

    cout <<"Biggest negative element is " << did << endl;
    cout <<"Its array adress: " << m <<";" << n <<endl;
    system("pause");
    return 0;
}

Posted 29-Nov-15 3:59am

Member 12174123

Updated 29-Nov-15 13:33pm

George Jonsson

v3

Add a Solution

Comments

Sergey Alexandrovich Kryukov 29-Nov-15 11:37am

Sorry, but this is not a question. Moreover, the formulation of the problem does not make sense. Without formulation of the the goals, a piece of code cannot be wrong or right; it can be wrong for one purpose and right for another one. If the behavior of your code does not match what you expected, use the debugger and fix it. If you failed to do so, describe what did you want to achieve, what's expected behavior, what is observed behavior, why do you feel it's wrong. If you have some exceptions, describe steps to reproduce, complete exception information. Comment the points in code related to exception throwing/propagation. Post all what's relevant. See also: http://www.sscce.org.
—SA

George Jonsson 29-Nov-15 19:38pm

I formatted the code so it is a bit more easy to read.
Now it should be pretty easy to find the problem.
Hint: How do you check if a number is more negative than another number?
Do you use < or >?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Member 10641779 · Answer 1 · 2015-11-30T23:55:00

You need to make a little change in your code.
First take two variable to save the Index.

C#

int nI,nJ;
if (a[i][j] < did && a[i][j] < 0){ //check if value less than did and 0.
      did = a[i][j];
      nI = i;        // save index of i.
      nJ = j;        //save index of j.
}

Earlier you were doing :
i = m; // here no matter what the condition is.
j = n; // it will always assign the same value of m and n every time.
As value of m and n are not changing in whole program so you will get the same value always.
as m and n are the size of array and you are assigning it to i and j respectively. it will reach end of the loop. so it comes out of the for loop.

Patrice T · Answer 2 · 2015-11-29T04:49:00

Your code do not behave the way you expect, and you don't understand why !

There is an almost universal solution: Run your code on debugger step by step.
Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]

The downside of this solution:
- It is a DIY, you are the one tracking the problem and finding its roots, which lead to the solution.
The upside of this solution:
- You see your code behaviour, you match it against your expectations.

secondary effects
- Your will be proud of finding bugs yourself.
- Your skills will improve.

You should find pretty quickly what is wrong.

Advices:
- Use braces {} everywhere it should be even if optional.
- use indentation, it makes your program easier to read and gives hints on what you intend to do.

Hello, please help me with this program, I dont get it why it does not work.

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0