Eh??? if(true)

Question

5.00/5 (1 vote)

See more:

Hi All,
I'm just refactoring some old code using ReSharper and it's suggested I change this:

var fileinfo = new FileInfo(file);
if(fileinfo != null)
{
}

to this:

var fileinfo = new FileInfo(file)
if(true)
{
}

I'm not sure I get this, I'm having a stupid moment but what is this actually evaluating? The lack of explicit reference to an object has confused me a bit.

Thanks,

Jammer

Posted 26-Nov-10 8:51am

Jammer

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Gregory Gadow · Answer 1 · 2010-11-26T09:08:00

Solution 1

Assigning a new object to a variable almost always means that the variable is non-null, which makes the if evaluation meaningless. If creating an object like this might fail, the proper way is to use a static method along the lines of

C#

var fileinfo = FileInfo.CreateNew(file);

Posted 26-Nov-10 9:08am

Gregory Gadow

Comments

Daniel Grunwald 26-Nov-10 15:17pm

To clarify: "almost always" means "always except in a weird case related to COM interop". There's no way "new" returns null in pure C# code.

Jammer 26-Nov-10 15:33pm

Thanks for this ...

Jammer

CPallini · Answer 2 · 2010-11-26T09:56:00

Solution 2

I'm with you on this.

if (true) is pretty silly.
What if some day, someone will insert fileinfo=null; between the two lines?

:)

Posted 26-Nov-10 9:56am

CPallini

Comments

fjdiewornncalwe 26-Nov-10 18:06pm

At that point Resharper will tell you to put the null reference check back in... LOL!!!