Unable to rectify Memory Leak in Visual C++ Code.

Question

4.00/5 (1 vote)

See more:

Hello,

I am working on a program which has a function(GetMyRecordsfrmDB()) which fetches data from Database and stores the records in a LIST object (User Defined - class MY_LIST). A pointer to this LIST object is then sent back as Return type. The LIST is created using 'new' but as we are sending pointer to this LIST as return type, its not getting 'delete'd in the function which (i guess) is responsible for Memory Leak in my program.

Note : The Code is from a program which uses CORBA Architechture (Client-Server model). This function is executed at Server Side and the function call is made from Client side.

MY_LIST* MyClass :: GetMyRecordsfrmDB ( someArgs1&, someArgs2&)
{
MY_LIST *pList = NULL;
 
pList = new MY_LIST;  

fillList (.., pList, ..); //some code which fetches data and store in pList;

return (pList);   // no 'delete' for *pList in whole function
}

Please tell me am i right to guess that there is memory leak in this funtion due to above mentioned reason, And if yes, then how can i rectify it ?

Any help would be highly appreciated.
Thanks in Advance

Posted 28-Mar-11 0:21am

Member 4243468

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Albert Holguin · Answer 1 · 2011-03-28T03:54:00

The delete doesn't necessarily have to be in the same function that called new, but it must take place either when you're done using that pList or upon the termination of the executable (whatever case is applicable).

If they are different apps, then you should probably manage the memory in a smarter way, as cpallini stated, either pass a pointer that the client will be able to delete or have some sort of memory management on your server (i.e. delete allocated memory based on some event).

CPallini · Answer 2 · 2011-03-28T00:27:00

Solution 1

You may ask the client to provide a pointer to valid (client allocated) MY_LIST object.

Posted 28-Mar-11 0:27am

CPallini

Updated 28-Mar-11 0:28am

v2

Comments

Olivier Levrey 28-Mar-11 11:24am

My 5. I agree with Cpallini. Let the client allocate the list and pass it to the function. Then the function can fill the list. The client will then be responsible for deleting the list.