access variable of main class

Question

0.00/5 (No votes)

See more:

File1.cs

C#

namespace TestApp
{
    public partial class MainWindow :Window 
    {    
    }
}

File2.cs

C#

namespace TestApp
{
    public partial class MainWindow
    {
        A ob = new A();
    }

    public class A
    {}
    public class B
    {
    }
}

new modification to file2.cs

C#

namespace TestApp
{
    public partial class MainWindow
    {
        init()
        {
            Exchange ob = new Exchange();
            ob.set_tb(textbox1);
        }
    }

    public class A
    {}
    public class B
    {}
    
    public class Exchange : Window
    {
        TextBox tb1;
        
   // some hack to get textbox access
        public void set_tb(TextBox tcontrol)
        {
            tb1=tcontrol;
        }
    }

}

similarly there are lot of function i have to add in Exchange class which uses lots of variable available in main class.

is it a good option to take exchange class in main class.

Posted 29-Dec-11 21:42pm

01.mandar

Updated 29-Dec-11 22:02pm

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Wendelius · Accepted Answer · 2011-12-29T22:03:00

Solution 1

Didn't quite follow the description, but as a general rule of thumb I'd avoid transferring UI objects between UI classes. Instead consider using properties and methods on your windows to transfer just needed information and to execute functionality. IMO even better if you could separate the UI from the data and from the logic to separate classes. This way the maintainability and robustness of the program would be better.

Posted 29-Dec-11 22:03pm

Wendelius

Comments

01.mandar 30-Dec-11 4:22am

i had created a application some what like

namespace TestApp
{
public partial class MainWindow
{
A ob = new A();
B ob2 = new B();
}

public class A
{}
public class B
{}
public class Exchange
{}
}

every thing was running fine..
now suddenly i have to add some functionality in Exchange class like access some UI element(which even was working fine) but it starting to become hectic to manage many elements and data structure as the dependency started to grow on main class

is it a better approach like

___placing all classes in main class
namespace
{
public partial class MainWindow
{
A ob = new A();
B ob2 = new B();

public class A
{}
public class B
{}
public class Exchange
{}

}
}

or make distribute class operation into small function

namespace
{
public partial class MainWindow
{
//// all share variables

void fun_A
{}
void fun_B
{}
void Exchange_fun1()
{}
void Exchange_fun2()
{}

}
}

which approach will be better ?

.

Wendelius 30-Dec-11 13:34pm

I would use the latter approach and pass only real values in the methods, not controls at all.