Qt and serial communication - unidentified crash

Question

0.00/5 (No votes)

See more:

I've written an application which sends a value (later this will be the value from QTextEdit) to an Arduino by clicking a button. I'm able to build it, but when I run the application, it crashes...

I can't seem to find the problem...

Thanks in advance!

main.cpp

C++

#include "serialcommunication.h"
#include <QtGui>
#include <qextserialport.h>

int main(int argc, char *argv[])
{
	QApplication a(argc, argv);
	SerialCommunication w;
	w.show();
	return a.exec();
}

serialcommunication.h

C++

#ifndef SERIALCOMMUNICATION_H
#define SERIALCOMMUNICATION_H

#include <QtGui>
#include "ui_serialcommunication.h"
#include <qextserialport.h>

class SerialCommunication : public QWidget
{
	Q_OBJECT

public:
	SerialCommunication();
	~SerialCommunication();
	QextSerialPort *port;
	void init_port();
	void transmitCmd(int value);

private slots:
	void clickclick();

private:
	Ui::SerialCommunicationClass ui;

	QTextEdit *textedit;
	QPushButton *pushbutton;
};

#endif // SERIALCOMMUNICATION_H

serialcommunication.cpp

<pre lang="c++">#include "serialcommunication.h"

SerialCommunication::SerialCommunication():QWidget()
{
	ui.setupUi(this);

	textedit = new QTextEdit;
	pushbutton = new QPushButton("PUSHBUTTON");

	init_port();

	connect(pushbutton, SIGNAL(clicked()), this, SLOT(clickclick()));

	QVBoxLayout *layout = new QVBoxLayout;
	layout->addWidget(textedit);
	layout->addWidget(pushbutton);

	setLayout(layout);
}

SerialCommunication::~SerialCommunication()
{
	
}

void SerialCommunication::clickclick()
{
	transmitCmd(123);	
}

void SerialCommunication::init_port()
{
    port = new QextSerialPort("COM4"); //we create the port

	port->open(QIODevice::ReadWrite | QIODevice::Unbuffered); //we open the port

    if(!port->isOpen())
    {
        QMessageBox::warning(this, "port error", "Impossible to open the port!");
    }
	else if(port->isOpen());

    //we set the port properties
    port->setBaudRate(BAUD9600);
    port->setFlowControl(FLOW_OFF);
    port->setParity(PAR_NONE);
    port->setDataBits(DATA_8);
    port->setStopBits(STOP_1);
}

void SerialCommunication::transmitCmd(int value)
{
  if(value < 0 || value >255)return; //if the value is not between 0 and 255
                                     //no transmission

  char *buf; //creation of a buffer
  *buf = value;

  //for messages longer than 1 character :
  /*
  char *buf[255]; //buffer size = 255char;
  sprintf(buf,"%c",value);
  */

  port->write(buf); //send the buffer
}

screenshot error
http://dl.dropbox.com/u/12844842/error.JPG[^]

Posted 2-Apr-12 9:19am

Tiemer

Add a Solution

Comments

[no name] 2-Apr-12 19:27pm

There is insufficient information here. This is not a forum to debug your code.
Have you used a debugger to step through this program and find out exactly where it is crashing.

Tiemer 3-Apr-12 17:00pm

I'm sorry if there is insufficient information. I thought that the screenshot pointed out where it crashes with a green arrow.

I think it crashes when it tries to open the port.

This is an example of which I found several alike on the internet, so I'm hoping that somebody who tried to use the same code can point out what's wrong with it...

If I can clearify my question even more, feel free to say so.

[no name] 3-Apr-12 18:18pm

Set a breakpoint at the first line of init_port() and step through.
Is port ever assigned a valid handle?

I would do something like:

port = NULL

port = new QextSerialPort("COM4"); //we create the port

if(port}
{

}
else
GetLastError()

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

User 59241 · Answer 1 · 2012-04-03T12:42:00

C#

port = new QextSerialPort("COM4"); //we create the port

port->open(QIODevice::ReadWrite | QIODevice::Unbuffered); //we open the port

if(!port->isOpen())
{
    QMessageBox::warning(this, "port error", "Impossible to open the port!");
}
else if(port->isOpen());

This is dangerous code.

It makes assumption COM4 exists and is not in use.

Also port->isOpen test is ignored.

It would be better to write:

C#

port = NULL;

port = new QextSerialPort("COM4"); //we create the port

if(port)
{

    port->open(QIODevice::ReadWrite | QIODevice::Unbuffered); //we open the port

    if(port->isOpen())
    {
     //we set the port properties
      port->setBaudRate(BAUD9600);
      port->setFlowControl(FLOW_OFF);
      port->setParity(PAR_NONE);
      port->setDataBits(DATA_8);
      port->setStopBits(STOP_1);
     }
	else
    {
 
       QMessageBox::warning(this, "port error", "Impossible to open the port!");
     }

}
else
 GetError()....

init_port() should not return void but an error value.