C# pass values from a method to a method

Question

1.00/5 (1 vote)

See more:

ok so what im trying to do is return a value from method 1 "public double calculateAmout(int age, string policyTypeId)" to another method "public string startQuote"

So currently the "public string startQuote" requires the user to input all data when its called

what i want to do is take the 'age' and 'policyTypeId' variables perform a calculation and return a value to the 'double amount' variable in "public string startQuote".

these methods are using other objects, but these are functioning correctly

this is for an insurance company project (if any one is interested)

my code is below

C#

public string startQuote(DateTime quoteDate, string policyTypeId, double amount, DateTime obtainedLicenseDate, int numberOfFines, string carRego, int age, string make, string model, DateTime regoExpiryDate, string additionalAccessories, string carUse)
        {
            

            Car newCar = new Car(additionalAccessories,model,regoExpiryDate,make,carRego,carUse);
            string newCarResult = createNewCar(ref newCar);

            PolicyType policy = new PolicyType();
            policy = policy.getPolicyType(policyTypeId);

            Quote newQuote = new Quote("", quoteDate, policy, amount, obtainedLicenseDate, numberOfFines, newCar, age);
            string newQuoteResult = createNewQuote(ref newQuote);


            if (newQuoteResult == "Success" && newCarResult == "Success")
            {
                return "Success";
            }
            else
            {
                return "Fail";
            }
               

        }


public double calculateAmout(int age, string policyTypeId)
        {

            double amount;

            PolicyType policy = new PolicyType();
            policy = policy.getPolicyType(policyTypeId);



            if (policyTypeId == "PT+1001" & age > 25)
            {
                amount = 1500 + 0;
            }

            if (policyTypeId == "PT+1002" & age > 25)
            {
                amount = 500;
            }

            if (policyTypeId == "PT+1003" & age > 25)
            {
                amount = 1000;
            }

            if (policyTypeId == "PT+1001" & age < 25)
            {
                amount = 2500;
            }

            if (policyTypeId == "PT+1002" & age < 25)
            {
                amount = 1500;
            }

            if (policyTypeId == "PT+1003" & age < 25)
            {
                amount = 2000;
            }

            return amount;

        }

i know a case statement should be used for the public double calculateAmout method ... but this is still being built :P

cheers

Posted 25-Apr-12 5:33am

sg_90

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Answer 1 · 2012-04-25T05:48:00

You don't return value from a method to a method. You return a value to a caller, which looks like assignment operator:

C#

SomeType someVariable = SomeMethod(someParameterValue, anotherParameterValue);

where SomeType is a return type of SomeMethod.

Another way is out parameters:

C#

SomeType SomeMethod(SomeParameterType byValueParameter, out SomeOtherType byReferenceOutParameter) { /* ... */ }

//...
SomeParameterType myInput = //...
SomeOtherType actualByReferenceOutParameter; //not initialized, perfectly OK, but only for out parameters
SomeType returnedValue = SomeMethod(myInput, out actualByReferenceOutParameter);
//at this point, actualByReferenceOutParameter is initialized and a value is assigned

If looks like you need to read about C# and programming nearly from the very beginning, it can greatly help you.

Your code has too many problems. Hard-coded immediate constants like "PT+1001", "PT+1002", 25, 2000, "Success" makes code practically unsupportable, design is very ad-hoc, instead of "", string.Empty should be used, too many parameters, all is public (why), no signs of OOP…

—SA

Pete O'Hanlon · Answer 2 · 2012-04-25T05:39:00

Solution 1

So what's the problem? I can't see it.

All you need to is something like:

C#

double output = calculateAmount(age, policyTypeId);

Now, it's normal practice to use Pascal casing for method names, and you have a redundant call to getPolicyType in calculateAmount.

Posted 25-Apr-12 5:39am

Pete O'Hanlon

sg_90 · Answer 3 · 2012-04-25T05:47:00

what i am trying to do is

use the 'age' and 'policyTypeId' variables in "public string startQuote".

and what ever value they have ... use that value and perform a calculation and return something to 'double amount'

getPolicyType returns the string policyTypeId

its like this

if your age is over 25 and choose a certian policy ... it will cost you x amount of dollars

thats what im trying to do

C# pass values from a method to a method

3 solutions

Solution 3

Solution 1

Solution 2

Add your solution here

Preview 0