incorrect syntax near ')' (sql exception)

Question

0.00/5 (No votes)

See more:

C#

UGIcon.Open();
                    cmd = new SqlCommand("update admin set name='" + textBox5.Text + "', age='" + numericUpDown1.Value.ToString() + "', phone='" + numericUpDown2.Value.ToString() + "', question='" + comboBox1.SelectedItem.ToString()+"', answer='" + textBox4.Text + "')", UGIcon);
                    
                       SqlDataReader sd;
                    sd = cmd.ExecuteReader(); i m getting error here 

                    MessageBox.Show("Thank You!!! Your Details updated", "Updation Window", MessageBoxButtons.OK, MessageBoxIcon.Information);
                    groupBox1.Visible = false;
                    UGIcon.Close();

Posted 9-Dec-12 23:34pm

selva_1990

Add a Solution

Comments

[no name] 10-Dec-12 5:38am

What is your condition ?? I'm talink about where clause and why do you need to close the brace in query ???

selva_1990 10-Dec-12 5:42am

i need to update entire table so i didnt use where condition

6 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

V Mohan · Accepted Answer · 2012-12-09T23:43:00

SQL

mylib.cmd = new SqlCommand("Update BUHeadMstr set Eid =@Eid, Bid=@Bid,CorpId=@CorpId,CreatedBy=@UId,CreatedOn=@Date where Buheadid =@buheadId    ", mylib.objDBConn);
            mylib.cmd.CommandType = CommandType.Text;

mylib.cmd.Parameters.AddWithValue("@Eid", objAdmin.Eid);
int i = mylib.cmd.ExecuteNonQuery();

Simon_Whale · Accepted Answer · 2012-12-09T23:47:00

Please use paramterised queries when writing inline SQL such as yours, below is an example of how to do this.

C# SqlParameter Example[^]

using this approach reduces / removes the chance of SQL Injection (decribed in the following article)

How do Parameterised queries help against SQL Injection[^]

This code project article highlights the ways to insert, update and delete data from a database using ADO.NET. As you can see when you read it. It uses the executeNonQuery as this returns the number of rows that have been effected by your query.

Simple ADO.NET Database Read, Insert, Update and Delete using C#.[^]

Kaushikhalvadiya · Accepted Answer · 2012-12-09T23:39:00

Solution 1

Hello,

Why u r using ExecuteReader() instead of use cmd.ExecuteNonQuery() method.

Posted 9-Dec-12 23:39pm

Kaushikhalvadiya

v2

Comments

[no name] 10-Dec-12 5:40am

post it as comment

Member 11388228 20-Jan-15 7:04am

how to solve this problem
i will write this coding
string strQuery = "insert into Purchase values('"+dateTimepurchasedate.Text+"','"+cBoxbrandnamepurchase.Text+"','"+cBoxproductnamepurchase.Text+"','"+txtMRPpurchase.Text+"',"+txtquntypurchase.Text+","+txtpurchaseprice.Text+","+txtvat.Text+","+txttotal.Text+","+txtdiscount.Text+",'"+result+"',"+txtnettotal.Text+",'"+cBoxsuppliername.Text+"')"

it will show error in incorrect syntax error how to solve this

sarathtamil · Accepted Answer · 2012-12-09T23:39:00

why to close the ')' in front of UGIcon(connection),remove the )...
and try this

cmd = new SqlCommand("update admin set name='" + textBox5.Text + "', age='" + numericUpDown1.Value.ToString() + "', phone='" + numericUpDown2.Value.ToString() + "', question='" + comboBox1.SelectedItem.ToString()+"',

answer='" + textBox4.Text + "'", UGIcon) and Give Where Clause...

Aarti Meswania · Accepted Answer · 2012-12-09T23:40:00

use it,

C#

UGIcon.Open();
                    cmd = new SqlCommand("update admin set name='" + textBox5.Text + "', age='" + numericUpDown1.Value.ToString() + "', phone='" + numericUpDown2.Value.ToString() + "', question='" + comboBox1.SelectedItem.ToString()+"', answer='" + textBox4.Text + "'    ", UGIcon); // error is at line wich is highlight by underscore at that place you have use closing bracket which cause error
                    
                       SqlDataReader sd;
                    sd = cmd.ExecuteReader(); i m getting error here 
 
                    MessageBox.Show("Thank You!!! Your Details updated", "Updation Window", MessageBoxButtons.OK, MessageBoxIcon.Information);
                    groupBox1.Visible = false;
                    UGIcon.Close();

Happy Coding!
:)

Kiran Susarla · Accepted Answer · 2012-12-09T23:42:00

I think your code should look like this:

C#

UGIcon.Open();
cmd = new SqlCommand("update admin set name='" + textBox5.Text + "', age='" + numericUpDown1.Value.ToString() + "', phone='" + numericUpDown2.Value.ToString() + "', question='" + comboBox1.SelectedItem.ToString()+"', answer='" + textBox4.Text + "'", UGIcon);
                    
SqlDataReader sd;
sd = cmd.ExecuteReader(); 
 
MessageBox.Show("Thank You!!! Your Details updated", "Updation Window", MessageBoxButtons.OK, MessageBoxIcon.Information);
groupBox1.Visible = false;
UGIcon.Close();

There is an unnecessary parenthesis after textbox4.Text.

incorrect syntax near ')' (sql exception)

6 solutions

Solution 5

Solution 6

Solution 1

Solution 2

Solution 3

Solution 4

Add your solution here

Preview 0