EROR IN UPATE in com.ExecuteNonQuery();

Question

1.00/5 (1 vote)

See more:

EROR IN UPATE in think in com.ExecuteNonQuery(); flagR = false;

C#

public bool UpDebitor(string Name, string PostNumber, string PhoneNumber,Guid ID)
{
    bool flagR = true;
    string query = string.Format("UPDATE Debitors SET  Name = '{0}' , PostNumber = '{1}', PhoneNumber '{2}' WHERE ID = '{3}'",
        Name, PostNumber, (PhoneNumber != String.Empty) ? PhoneNumber : null,ID);

    using (SqlConnection con = new SqlConnection(constring))
    {
        SqlCommand com = new SqlCommand(query, con);
        try
        {
            con.Open();
            com.ExecuteNonQuery();
            flagR = false;

        }
        catch
        {

        }
        return flagR;
    }
}

Posted 13-Dec-12 10:38am

the dark Knight

Add a Solution

Comments

Richard C Bishop 13-Dec-12 16:42pm

What does the error message say?

2 solutions

Solution 1

The major flaw of this code is that it is using string data to compose a query; and you should never ever do it because this is too dangerous from the security standpoint.

The data can come from anywhere, including user input. In this case, it can be anything, including… a fragment of SQL code. This simple idea explain a well-known exploit called SQL Injection:
http://en.wikipedia.org/wiki/SQL_injection[^].

This article also explain the importance of parameterized statements. You need to use them in your code. Please see:
http://msdn.microsoft.com/en-us/library/ms254953.aspx[^].

—SA

Posted 13-Dec-12 10:46am

Sergey Alexandrovich Kryukov

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

fjdiewornncalwe · Accepted Answer · 2012-12-13T10:50:00

Solution 2

1) You should really be using Paramaterized Queries.
2) PhoneNumber '{2}' should be PhoneNumber = '{2}'

Posted 13-Dec-12 10:50am

fjdiewornncalwe

Updated 13-Dec-12 10:51am

v2

Comments

Jibesh 13-Dec-12 16:54pm

Good Catch Marcus!!!

the dark Knight 13-Dec-12 17:04pm

thank you working now

[no name] 14-Dec-12 0:11am

Great Marcus....