error msg should apear only one time. but it is working with respect to loop. help me with this, thanX in Advance.

Question

0.00/5 (No votes)

See more:

C#

int i = dataGridView1.Rows.Count;
           for (i = 0; i <= dataGridView1.Rows.Count - 1; i++)
           {
               if (dataGridView1.Rows[i].Cells[1].Value.ToString() == txtcscnic1.Text + "-" + txtcscnic2.Text + "-" + txtcscnic3.Text)
               {
                   dataGridView1.Rows[i].Selected = true;
               }
               else
               {
                   MessageBox.Show("Customer with CNIC'" + txtcscnic1.Text + "-" + txtcscnic2.Text + "-" + txtcscnic3.Text + "' does not Exist", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
               }
           }

Posted 4-Jan-13 6:19am

zeshanazam

Add a Solution

2 solutions

Solution 1

First thing remove the message box out of the for loop.

Next try to build a string (preferablly using stringbuilder) that contains all customer codes with error.
Finally display this in the message box outside the for loop.

Posted 4-Jan-13 6:27am

Abhinav S

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

fjdiewornncalwe · Accepted Answer · 2013-01-04T06:28:00

Just make this modification and your MessageBox will only appear once.

C#

int i = dataGridView1.Rows.Count;
bool itemFound = false;
for (i = 0; i <= dataGridView1.Rows.Count - 1; i++)
{
   if (dataGridView1.Rows[i].Cells[1].Value.ToString() == txtcscnic1.Text + "-" + txtcscnic2.Text + "-" + txtcscnic3.Text)
   {
      dataGridView1.Rows[i].Selected = true;
      itemFound = true;
      break;
   }   
}
if( !itemFound )
{
   MessageBox.Show("Customer with CNIC'" + txtcscnic1.Text + "-" + txtcscnic2.Text + "-" + txtcscnic3.Text + "' does not Exist", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
}