calculate normal,average ,high using c# windows application

Question

0.00/5 (No votes)

See more:

hi all,

am developing c# windows application
by this i have got few suggestion my code below

my flow is:
am calculating normal,average,high.

if my textbox value <=12 means i need to get "you got an normal marks", message
if my textbox value between 13 to 20 means i need to get "you got an average marks",message
if my textbox value >=21 means i need to get "you got an high marks",message

but in this concept is not working in my code below ,
so please review the below my code and let me know where i would made mistake in my code,
so that i can able to recorrect my mistake.

my code :

C#

private void button2_Click(object sender, EventArgs e)
     {
         if (textBox1.Text <= "12")
         {
             label3.Text = "afected";
         }
         else if (textBox1.Text == "20")
         {
             label3.Text = "average";
         }
         else if (textBox1.Text >= "21")
         {
             label3.Text = "normal";
         }


     }

thanks in advance..

Posted 21-Mar-13 1:02am

stellus

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

phil.o · Accepted Answer · 2013-03-21T01:10:00

textBox1.Text <= "12"

This is incorrect. You have a string value (textBox1.Text), on which you are trying to make a number comparison with.

You have to transform your string value to an integer one to be able to compare.

So :

int value; // Here we decalre our integer variable

bool ok = int.TryParse(textBox1.Text, out value); // Here we try to get an integer value from the textbox

if (ok)
{
   if (value <= 12)
   {
      label3.Text = "afected";
   }
   else if (value <= 20) // Here you have to check for an inequality, not an equality to 20
   {
      label3.Text = "average";
   }
   else // Here will match the case where value > 20
   {
      label3.Text = "normal";
   }
}
else
   label3.Text = "textBox1.Text does not represent a valid integer";

Hope this helps