Try... Catch.. End Try or If... End IF

Question

4.00/5 (1 vote)

See more:

HI,
I'm working on my game loop and when disposing the graphics device form
I get 'ObjectDisposedException'. I put the code that draws the back buffer to
the target surface in 'try... end try' statements like this:

VB

Try
   _bbg = Me.CreateGraphics
   _bbg.DrawImageUnscaled(_bb, 0, 0)
Catch ex As ObjectDisposedException
End Try

and this solved the problem, but then I remember that I read somewhere
that 'try' statements are heavy and I've decided to replace them
with a simple boolean expression that checks whether the form is about to
be disposed or not:

VB

If booKill = False Then
   _bbg = Me.CreateGraphics
   _bbg.DrawImageUnscaled(_bb, 0, 0)
End If

That also do the trick without throwing exceptions, but now I'm wondering
which one of the both examples is faster?

Posted 22-Apr-13 0:49am

O.G.I.

Updated 22-Apr-13 0:50am

Sandeep Mewara

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

E.F. Nijboer · Accepted Answer · 2013-04-22T01:10:00

I would say both because booKill is boolean and doesn't really guarantee anything about _bb. Unless you cannot do anything to fix it, because then a try..catch is most of the time just useless.

If booKill = False Then
  Try
   _bbg = Me.CreateGraphics
   _bbg.DrawImageUnscaled(_bb, 0, 0)
  Catch ...
    Fix code...
  End Try
End If

Good luck!

CHill60 · Accepted Answer · 2013-04-22T01:27:00

You're confusing defensive programming (If booKill = False) with exception handling (Try ... Catch) ... Me.CreateGraphics might still throw an exception but with just the boolean check you wouldn't capture it.

But to answer your question about "fastest" ... try writing a small test program to process large volumes using both methods ... In simplistic terms, the boolean check is always executed whereas the Try-Catch processing only gets invoked if there's an exception, which implies that the latter would be "faster". I doubt you'll really notice the difference.

In terms of making it clear what's going on, writing defensively and handling exceptions properly then I would suggest something close to E.F. Nijboer's solution

Try... Catch.. End Try or If... End IF

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0