Unable to return the list values

Question

0.00/5 (No votes)

See more:

I am checking for a specific record in a list but when i enter the correct data the try block is not returning any value.....but it is working fine when there is no record.

C#

public List<Customer> get(string str)
       {
           //  var result = cutomerList.Find(x => x.CustomerName == str);

           try
           {

               var ss = cutomerList.Where(x => x.CustomerName == str).ToList();

               if (Convert.ToInt32(ss) == 0)
               {
                   Exception ex;

               }

               return ss;
           }

           catch (Exception ex)
           {

               MyFaultException fault = new MyFaultException();
               fault.Reason = "Record not found ";
               throw new FaultException<MyFaultException>(fault, new FaultReason(fault.Reason));
           }

Posted 9-Aug-13 4:26am

shacha

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Pascal-78 · Accepted Answer · 2013-08-09T04:35:00

I think your problem comes from the line :

C#

if(Convert.ToInt32(ss)==0)

when there is no record, ss may be null. and the Convert method works.
But when you have one or more records, ss is not null and cannot be converted to an int and an exception is thrown by the Convert.ToInt32 method.

You should use that kind of code instead:

C#

if(ss==null || ss.Count==0) throw new Exception();

I have successfully tried the following code :

C#

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;

namespace ConsoleApplication1
{
    class Customer
    {
        public string CustomerName { get; set; }
        public int CustomerId { get; set; }
    }
    class Program
    {
        static private List<Customer> customerList;
        static public List<Customer> get(string str)
        {
            try
            {
                var ss = customerList.Where(x => x.CustomerName == str).ToList();
                if (ss == null || ss.Count == 0)
                {
                    throw new Exception();
                }
                return ss;
            }
            catch (Exception ex)
            {
                throw ex;
            }
        }
        static void Main(string[] args)
        {
            customerList = new List<Customer>() { new Customer() { CustomerName = "Name1", CustomerId = 1 }, new Customer() { CustomerName = "Name2", CustomerId = 2 } };
            var s = get("Name1");
            var s2 = get("Name3");
        }
    }
}

no exception with get("Name1") ; exception with get("Name3") ;