save password to database

Question

2.33/5 (2 votes)

See more:

Hello,
Please help me with this

C#

public class Password
    {
        
        // method to generate random Password
        public static string GeneratePassword()
        {
            string PasswordLength = "5";
            string NewPassword = "";
            string allowedChars="";
            allowedChars = "1,2,3,4,5,6,7,8,9,0";
            allowedChars += "A,B,C,D,E,F,G,H,I,J,K,L,M,N,O,P,Q,R,S,T,U,V,W,X,Y,Z,";
            allowedChars += "a,b,c,d,e,f,g,h,i,j,k,l,m,n,o,p,q,r,s,t,u,v,w,x,y,z,";
            allowedChars += "~,!,@,#,$,%,^,&,*,+,?";
        
            // seperation of characters
            char[] sep = { ',' };
            string[] arr = allowedChars.Split(sep);

            string IDString = "";
            string temp = "";

            Random rand = new Random();
            for (int i = 0; i < Convert.ToInt32(PasswordLength); i++)
            {
                temp = arr[rand.Next(0, arr.Length)];
                IDString += temp;
                NewPassword = IDString;
               
            }
             return NewPassword;
        }

C#

    // Method to save NewPassword to Database's [Users table]

    public static void SavePasswordToDB()
    {
        SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["MyDBConnectionString"].ToString());

        string strNewPassword = GeneratePassword().ToString();
        SqlCommand cmd = new SqlCommand("INSERT INTO dbo.Users(UserPassword) Values(strNewPassword)", con);
        con.Open();
        cmd.ExecuteNonQuery();
        con.Close();
    }
}

I am getting the following error:

The name "strNewPassword" is not permitted in this context. Valid expressions are constants, constant expressions, and (in some contexts) variables. Column names are not permitted.

What should i pass in Values() ??

Thank you.

Posted 4-Sep-13 2:38am

saurabh kumar mahto

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Maarten Kools · Accepted Answer · 2013-09-04T02:47:00

Okay, two things.

One, you're passing this string:

C#

"INSERT INTO dbo.Users(UserPassword) Values(strNewPassword)"

So obviously it won't know what strNewPassword is.

To fix that, make sure you pass the values. But please, use parameters for that (disclaimer: I haven't compiled this, but it should work):

C#

try
{
    con.Open();
    using(SqlCommand cmd = new SqlCommand("INSERT INTO dbo.Users(UserPassword) Values(@password)", con))
    {
        cmd.Parameters.AddValue("@password", strNewPassword);
        cmd.ExecuteNonQuery();
    }
}
finally
{
    if (con != null) con.Close();
}

This is a much safer way than using a String.Format or something similar. Because that would leave you open to SQL injection (though perhaps not in this case, it's still good practice to do so). And it's a lot easier to use anyway in my opinion. More info on the subject[^]

But the second thing (and perhaps the most important): Why are you storing an unencrypted password in your database??

Rakesh Meel · Accepted Answer · 2013-09-04T02:45:00

you have to use these lines....

public static void SavePasswordToDB()
        {
            SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["MyDBConnectionString"].ToString());
 
            string strNewPassword = GeneratePassword().ToString();
            SqlCommand cmd = new SqlCommand("INSERT INTO dbo.Users(UserPassword) Values('" + strNewPassword + "')", con);
            con.Open();
            cmd.ExecuteNonQuery();
            con.Close();
        }
    }

save password to database

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0