Number of query values and destination fields are not the same error in C# ?

Question

0.00/5 (No votes)

See more:

Hi, am trying to store my textedit valued to MS Access Database but am getting error like this "Number of query values and destination fields are not the same". But my query values and destination fields are same. I try to inserting in two methods both method getting same error.

I tried this method first

C#

int invoicenumber = Convert.ToInt32(TXE_Invoice_Number.Text);
       string terms = CBL_Terms.Text;
       DateTime date = CBL_Date.DateTime;
       string ourquote = TXE_OurQuote.Text;
       string salesperson = CBL_Sales_Person.Text;
       string customername = CBL_Customer_Nmae.Text;
       string oderno = CBL_Order_Number.Text;
       string invoiceaddress = TXE_Invoice_Address.Text;
       string deliveryaddress = TXE_Delivery_Address.Text;

       decimal wholediscper = Convert.ToDecimal(TXE_FlatDiscountP.Text);
       decimal wholediscamt = Convert.ToDecimal(TXE_FlatDiscountA.Text);
       decimal shippingpercenatge = Convert.ToDecimal(TXE_ShippingPercentage.Text);
       decimal shippingamount = Convert.ToDecimal(TXE_ShippingAmount.Text);
       decimal unitprice = Convert.ToDecimal(TXE_SubTotal.Text);
       decimal discount = Convert.ToDecimal(TXE_Discount.Text);
       decimal tax = Convert.ToDecimal(TXE_Tax.Text);
       decimal shiping = Convert.ToDecimal(TXE_Shipping.Text);
       decimal grandtotal = Convert.ToDecimal(TXE_GrandTotal.Text);


       OleDbCommand top = new OleDbCommand(
           "INSERT INTO NewInvoice_1 (" +
           "InvoiceNumber,Terms,[InvoiceDate],OurQuote," +
           "SalesPerson,CustomerName,OrderNumber," +
           "InvoiceAddress,DeliveryAddress," +
           "WholeDiscountP,WholeDiscountA,ShippingP,ShippingA" +
           "Price,Discount,Tax" +
           "Shipping,GrandTotal" +
           ") VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)", conn);

       top.Parameters.AddWithValue("?", invoicenumber);
       top.Parameters.AddWithValue("?", terms);
       top.Parameters.AddWithValue("?", date);
       top.Parameters.AddWithValue("?", ourquote);
       top.Parameters.AddWithValue("?", salesperson);
       top.Parameters.AddWithValue("?", customername);
       top.Parameters.AddWithValue("?", oderno);
       top.Parameters.AddWithValue("?", invoiceaddress);
       top.Parameters.AddWithValue("?", deliveryaddress);

       top.Parameters.AddWithValue("?", wholediscper);
       top.Parameters.AddWithValue("?", wholediscamt);
       top.Parameters.AddWithValue("?", shippingpercenatge);
       top.Parameters.AddWithValue("?", shippingamount);
       top.Parameters.AddWithValue("?", unitprice);
       top.Parameters.AddWithValue("?", discount);
       top.Parameters.AddWithValue("?", tax);
       top.Parameters.AddWithValue("?", shiping);
       top.Parameters.AddWithValue("?", grandtotal);

       top.ExecuteNonQuery();

Second method

C#

int invoicenumber = Convert.ToInt32(TXE_Invoice_Number.Text);
        string terms = CBL_Terms.Text;
        DateTime date = CBL_Date.DateTime;
        string ourquote = TXE_OurQuote.Text;
        string salesperson = CBL_Sales_Person.Text;
        string customername = CBL_Customer_Nmae.Text;
        string oderno = CBL_Order_Number.Text;
        string invoiceaddress = TXE_Invoice_Address.Text;
        string deliveryaddress = TXE_Delivery_Address.Text;

        decimal wholediscper = Convert.ToDecimal(TXE_FlatDiscountP.Text);
        decimal wholediscamt = Convert.ToDecimal(TXE_FlatDiscountA.Text);
        decimal shippingpercenatge = Convert.ToDecimal(TXE_ShippingPercentage.Text);
        decimal shippingamount = Convert.ToDecimal(TXE_ShippingAmount.Text);
        decimal unitprice = Convert.ToDecimal(TXE_SubTotal.Text);
        decimal discount = Convert.ToDecimal(TXE_Discount.Text);
        decimal tax = Convert.ToDecimal(TXE_Tax.Text);
        decimal shiping = Convert.ToDecimal(TXE_Shipping.Text);
        decimal grandtotal = Convert.ToDecimal(TXE_GrandTotal.Text);

        OleDbCommand top = new OleDbCommand("INSERT INTO test_top(InvoiceNumber,Terms,[InvoiceDate],OurQuote,SalesPerson,CustomerName,OrderNumber,InvoiceAddress,DeliveryAddress,WholeDiscountP,WholeDiscountA,ShippingP,ShippingA,Price,Discount,Tax,Shipping,GrandTotal) VALUES (" + invoicenumber + ",'" + terms + "','" + date + "','" + ourquote + "','" + salesperson + "','" + customername + "','" + oderno + "','" + invoiceaddress + "','" + deliveryaddress + "',"+ wholediscper +","+ wholediscamt +","+ shippingpercenatge +","+ shippingamount +"," + unitprice + "," + tax + "," + grandtotal + ")", conn);

In Both method getting same error ? Whats wrong with my code ? Help me

Posted 14-Dec-13 20:00pm

srihari1904

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) · Accepted Answer · 2013-12-14T20:10:00

Solution 1

The discount and shiping values are missing in second method.
Try again by adding them.

Posted 14-Dec-13 20:10pm

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ)

ashok prajapati 11 · Accepted Answer · 2013-12-14T20:14:00

First is wrong as you need to name the parameters in query and when adding the values.
Second is correct except that you are defined 2 additional column for insert statement and not passing it's value.
First missing value is for Discount & Second is of Shipping.

So, correct code would be some thing like

C#

OleDbCommand top = new OleDbCommand("INSERT INTO test_top(InvoiceNumber,Terms,[InvoiceDate],OurQuote,SalesPerson,CustomerName,OrderNumber,InvoiceAddress,DeliveryAddress,WholeDiscountP,WholeDiscountA,ShippingP,ShippingA,Price,Discount,Tax,Shipping,GrandTotal) VALUES (" + invoicenumber + ",'" + terms + "','" + date + "','" + ourquote + "','" + salesperson + "','" + customername + "','" + oderno + "','" + invoiceaddress + "','" + deliveryaddress + "',"+ wholediscper +","+ wholediscamt +","+ shippingpercenatge +","+ shippingamount +"," + unitprice + "," + discount + "," +tax + "," + shipping + "," + grandtotal + ")", conn);

agent_kruger · Accepted Answer · 2013-12-14T20:15:00

its because here

OleDbCommand top = new OleDbCommand(
            "INSERT INTO NewInvoice_1 (" +
            "InvoiceNumber,Terms,[InvoiceDate],OurQuote," +
            "SalesPerson,CustomerName,OrderNumber," +
            "InvoiceAddress,DeliveryAddress," +
            "WholeDiscountP,WholeDiscountA,ShippingP,ShippingA" +
            "Price,Discount,Tax" +
            "Shipping,GrandTotal" +
            ") VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)", conn);

you have written 17 values and passing and passing 18 values. According to me "ShippingA,Price" should be written instead of "ShippingA" + "Price".

If your query is answered please click accept solution.

Number of query values and destination fields are not the same error in C# ?

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0