Help in Multiplayer Game in .net (C#) using TCP Socket

Question

0.00/5 (No votes)

See more:

I need to append # character on button2_Click event. If i try to print value of GameInfo.GameID
in the same form the # character is not appended. But in the next form if i send its value to the server the # character is sent to the server as second part of the string sent.
Can anyone explain the problem with my code? I

public partial class Form3 : Form
    {
        System.Net.Sockets.TcpClient clientSocket = new System.Net.Sockets.TcpClient();
        NetworkStream serverStream = default(NetworkStream);
       
        string readData = null;
        string USERNAME = null;
        string returndata = null;
        int LENGTH = 0;
        //TO CHECK IF FORM IS ALREADY SHOWN OR NOT
        bool CHECKINSTANCE = false;
        public Form3()
        {
            InitializeComponent();
        }
        private void Form3_Load(object sender, EventArgs e)
        {
      
            msg();
            clientSocket.Connect("127.0.0.1", 8888);
            serverStream = clientSocket.GetStream();

            byte[] outStream = System.Text.Encoding.ASCII.GetBytes("$DU" + LoginInfo.UserID + "$");
            serverStream.Write(outStream, 0, outStream.Length);
            serverStream.Flush();

            Thread ctThread = new Thread(getMessage);
            ctThread.Start();


        }
        private void getMessage()
        {
            string trim = null;
            try
            {
                while (true)
                {
                    readData = null;
                    returndata = null;
                    USERNAME = null;

                    LENGTH = 0;
                    int CUT = 0;
                    serverStream = clientSocket.GetStream();
                    int buffSize = 0;
                    byte[] inStream = new byte[10025];
                    buffSize = clientSocket.ReceiveBufferSize;
                    serverStream.Read(inStream, 0, buffSize);
                    returndata = System.Text.Encoding.ASCII.GetString(inStream);
                    serverStream.Flush();
                    readData = returndata;

                    trim = readData.Substring(0, 6);
                    if (trim == "$CHAT$")
                    {
                        readData = readData.Remove(0, 6);

                        for (int i = 0; i < readData.Length; i++)
                        {

                            if (readData[i] == '&')
                            {
                                USERNAME = readData.Substring(0, readData.IndexOf("&"));
                                CUT = i + 1;
                                break;
                            }
                        }
                        if (CUT != 0)
                        {
                            readData = readData.Substring(CUT);
                        }
                        if (USERNAME != null)
                        {
                            for (int i = 0; i < USERNAME.Length; i++) ;
                            {
                                LENGTH = LENGTH + 1;
                            }
                        }
                        msg();
                    }
                    else if (trim == "$GAME$")
                    {
                        gamemsg();
                    }

                }
            }
            catch
            {
            }
        }
        private void msg()
        {
            string temp=null;
            if (this.InvokeRequired)
                this.Invoke(new MethodInvoker(msg));
            else
            {   
               
                richTextBox1.ReadOnly = false;
                if (USERNAME == null)
                {
                    richTextBox1.Text = richTextBox1.Text + Environment.NewLine + readData;
          
                }
                else if (USERNAME == LoginInfo.UserID)
                {  
                    richTextBox1.Text = richTextBox1.Text + Environment.NewLine + "Me >> " + readData;
                          }
                else
                {
                    richTextBox1.Text = richTextBox1.Text + Environment.NewLine + USERNAME + " says>> " + readData;
          
                }

            }

        }

        private void gamemsg()
        {
            if (this.InvokeRequired)
                this.Invoke(new MethodInvoker(gamemsg));
            else
            {
                bool match = false;
                  readData = readData.Remove(0, 6);
                 USERNAME = readData;

                 USERNAME = readData.Substring(0, readData.IndexOf("&") - 1);
                 for (int i = 0; i < listBox1.Items.Count; i++)
                 {
                     if (listBox1.Items[i].ToString() == "Game Created by " + USERNAME)
                         match = true;
                 }
                 if (match == false)//to save from listing duplicate games
                     listBox1.Items.Add("Game Created by " + USERNAME);
               
            }
        }

        }

              private void button2_Click(object sender, EventArgs e)
        {
            if (listBox1.SelectedItem != null)
            {
                GameInfo.GameID = "$POINT$" + listBox1.SelectedItem.ToString().Substring(16) + "#";
              //  this.Close();
                textBox3.Text = GameInfo.GameID;
                Form4 form4 = new Form4();
                form4.Show();
            }
            else
            {
                label3.Text = "Please Select a Game";
            }
        }

}
    
    }

Here is the code i used in another winform to send it to the server

private void Form4_Load(object sender, EventArgs e)
        {
            string readData = null;
            int buffSize = 0;
            byte[] outStream = null;
            byte[] inStream = new byte[10025];
            int point = 0;
           
       
            clientSocket.Connect("127.0.0.1", 8888);
            serverStream = clientSocket.GetStream();
            // send code to get the card
            outStream = System.Text.Encoding.ASCII.GetBytes("$CARD$");
            serverStream.Write(outStream, 0, outStream.Length);
            serverStream.Flush();
            
            buffSize = clientSocket.ReceiveBufferSize;
            serverStream.Read(inStream, 0, buffSize);
            readData = System.Text.Encoding.ASCII.GetString(inStream);
            serverStream.Flush();
            assigncard(readData);
            point=assignpoints(Code1,Code2,Code3,Code4,Code5);
            Flush(Code1, Code2, Code3, Code4, Code5);

            
            outStream = System.Text.Encoding.ASCII.GetBytes(GameInfo.GameID + LoginInfo.UserID + "#" + point);
            serverStream.Write(outStream, 0, outStream.Length);
            serverStream.Flush();
             
            Thread pointThread = new Thread(getPoints);
            pointThread.Start();
        }

Posted 28-Jan-14 2:45am

Member 10016481

Updated 28-Jan-14 3:24am

v3

Add a Solution

Comments

bowlturner 28-Jan-14 9:04am

is the text box big enough to display the whole string?

Member 10016481 28-Jan-14 9:22am

Yeah its a multiline textBox

Richard MacCutchan 28-Jan-14 9:20am

You can easily check the contents of GameInfo.GameID with your debugger, or use some logging method to write it to a file. However, the most important part(s) of the code is where you send this message to the server, also where the server reads it, and you still have not shown that.

Member 10016481 28-Jan-14 9:25am

Sir i have included the code i used to send it to the server.

Richard MacCutchan 28-Jan-14 9:35am

You are not checking that you have read the complete message in your read process. See http://msdn.microsoft.com/en-us/library/system.net.sockets.networkstream.read(v=vs.110).aspx for how it should be done.

Member 10016481 28-Jan-14 9:45am

Sir i tried printing the data sent by the server and it all works fine. Ok i'll implement it too.

Member 10016481 28-Jan-14 9:30am

Sir the # character is not append if i select a dynamically added item from the listBox else everything works fine if the listBox selected item is static.

Richard MacCutchan 28-Jan-14 9:39am

There are too many unknowns here. You must do some tests with your debugger to see exactly what is going on. The code you have shown has one method (on a button click) for showing the string with the listbox item, and a different method for sending a different string to the server. You should redesign the program so you have a single method that reads all messages, and a single method that writes all messages.

Member 10016481 28-Jan-14 9:42am

Ok i'll modify that sir. Right now i have to make my code work somehow and the main problem is of appending # character.

Member 10016481 28-Jan-14 10:14am

Finally the problem got resolved sir thank you so much for your help :)
Actually on dynamically selecting an item from listBox '0\' is apppended which increases the size of string to 10027 so on sending to sever # charactr is at position 10028 and i thougth it is received as second part.

Richard MacCutchan 28-Jan-14 10:31am

No wonder I couldn't figure it out. The longest string you showed me was about 12 characters!

Member 10016481 28-Jan-14 11:04am

Actually sir when i select a dynamically added item from listbox then
GameInfo.Game="$POIN$xyz\0\0\0\0\0.................................#"
Its makes a string of 10028 length.
I just used
GameInfo.GameID=GameInfo.GameID.Replace("\0", string.Empty);
to remove '\0' character.

Richard MacCutchan 28-Jan-14 11:40am

That sounds like there is still something wrong in your code.

Member 10016481 28-Jan-14 12:10pm

Might be this is the way dynamically items are added in a listBox with \0 character in the end.

Richard MacCutchan 28-Jan-14 12:34pm

I don't think so, not in .NET classes. Also why would this make your messages over 10,000 characters long?

Richard MacCutchan 28-Jan-14 12:44pm

I think I know what may be causing this. In your read from the server above, you do the following:


int buffSize = 0;
byte[] inStream = new byte[10025];
buffSize = clientSocket.ReceiveBufferSize;
serverStream.Read(inStream, 0, buffSize);
returndata = System.Text.Encoding.ASCII.GetString(inStream);

So you read some number of bytes from the socket into the inStream array. You then encode that array into ASCII. But since that array has a length of 10,025, it will encode that number of bytes. You then pass that off as a string, but it still has that incorrect length. You need to adjust your code to convert only the number of bytes read into your final string buffer.

Member 10016481 29-Jan-14 3:52am

Actually Sir i've to append the # charcter also so if i delete the length of the string then # character would also get deleted. Thus i used the string.replace method to remove the \0 character.

Richard MacCutchan 29-Jan-14 4:30am

That is not the right answer; you need to fix the underlying bug in the first place. The Read method returns an integer giving the actual number of bytes read, and you should us that information to construct your string correctly.

Member 10016481 29-Jan-14 8:14am

Sorry I am not getting it sir.

Richard MacCutchan 29-Jan-14 8:43am

See my suggestion below.

Member 10016481 29-Jan-14 8:51am

Ok Thanks you sir

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Accepted Answer · 2014-01-29T02:42:00

Solution 1

You should use the return value from the Read method to build your string, based on the number of characters actually returned. Something like:

C#

int buffSize = clientSocket.ReceiveBufferSize;
byte[] inStream = new byte[buffSize];
int bytesRead = serverStream.Read(inStream, 0, buffSize);
returndata = System.Text.Encoding.ASCII.GetString(inStream, 0, bytesRead);

Posted 29-Jan-14 2:42am

Richard MacCutchan

Updated 29-Jan-14 2:51am

v2

Comments

Karthik_Mahalingam 29-Jan-14 8:52am

5

Richard MacCutchan 29-Jan-14 9:03am

Thank you; it took me while to figure it out, but now it seems so obvious ... :)

Karthik_Mahalingam 29-Jan-14 9:07am

yes,Richard
i saw the conversation..
Good job..