File ponter maintaince error please guide

Question

1.00/5 (1 vote)

See more:

, +

Hi All,

I have a file like this

I am a student xyz in university"|USA|" in first year.
I am a student abc in university"|America|" in first year.
I am a student asd in university"|Italy|" in first year.

I have to parse the file and extract only the university name from the file and also the xyz,abc,asd
so i have written the following code

C++

//#include <stdio.h>

#include <fstream>
#include <string>
#include <iostream>
bool ParseLine(const std::string& line, std::string& key, std::string& value);
 
class Demo
{
public:
    typedef struct _Data 
    {
        std::string university;
		std::string name;
        
    } Data;
 
    Data data;
};
 
int main()
{
    std::ifstream ifs("Ca.txt");
    std::string line;
    std::string key;
    std::string value;
    Demo obj;
    while(!ifs.eof())
    {
        std::getline(ifs, line);
        if (ParseLine(line, key, value))
        {
            if (0 == key.compare("student"))
            {
                obj.data.name = value;
            }
         
			 else if (0 == key.compare("university"))
            {
				obj.data.content = value;
            }
            else
            {
                std::cerr<<"Unknow key:" << key << std::endl;
            }
        }
    }
    return 0;
}
 
bool ParseLine(const std::string& line, std::string& key, std::string& value)
{
    bool flag = false;
    
if (line.find("//") != 0)
    {
        size_t pos = line.find("|");
        if (pos != std::string::npos)
        {
            key = line.substr(0, pos);
			 size_t pos1 = line.find(";");
            value = line.substr(pos + 1, pos1);
            flag = true;
        }
    }
	
    return flag;
}

Two problems
When extracting the university value i get every thing like "USA|" in first year" but i want only USA and name logic dosen't work

Please guide

Posted 22-Feb-14 1:01am

Robert Clove

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Quirkafleeg · Answer 1 · 2014-02-23T22:37:00

1) Not sure why you check for ";" in ParseLine, but you would need to check for the 2nd "|", e.g.

C++

size_t pos = line.find("|");
if (pos != std::string::npos)
{
  size_t pos1 = line.find("|", pos + 1);
  value = line.substr(pos + 1, pos1 - pos - 1);
}

2) The easiest solution to the student name is to produce similar logic as the university value, e.g.

C++

size_t pos = line.find("student ");
if (pos != std::string::npos)
{
  size_t pos1 = line.find(" ", pos + 8);
  key = line.substr(pos + 8, pos1 - pos - 8);
}

Following this would then simply have the following in the main function:

C++

if (ParseLine(line, key, value))
{
  obj.data.name = key;
  obj.data.content = value;
}

(You should probably create a function inside the if statement to validate the key and/or value to ensure they are acceptable values)