Msg 156, Level 15, State 1, Procedure UpdateCustomer, Line 29 Incorrect syntax near the keyword 'SELECT'.

Question

0.00/5 (No votes)

See more:

SQL-Server-2008

SQL

CREATE PROCEDURE UpdateCustomer
(
@CustomerID BIGINT
,@Name VARCHAR(40)
,@Address1 VARCHAR(20)
,@Address2 VARCHAR(20)
,@District VARCHAR(20)
,@State VARCHAR(20)
,@Country VARCHAR(20)
,@ZIPPIN VARCHAR(20)
,@Website VARCHAR(20)
,@email VARCHAR(20)
,@Telephone VARCHAR(12)
,@ContactPerson VARCHAR(20)
,@Mobile VARCHAR(12)
,@Reference_Name VARCHAR(20)
,@Naration VARCHAR(50)

)
AS
DECLARE @FIRSTNAME VARCHAR(20);
DECLARE @LASTNAME VARCHAR(20);


SELECT @FIRSTNAME=SELECT Item from dbo.SplitString(@Name,' ')where ItemIndex=0
SELECT @LASTNAME=SELECT Item from dbo.SplitString(@Name, ' ')where ItemIndex=1

UPDATE customers SET CustomerName=@FIRSTNAME,CustomerLName=@LASTNAME,Address1=@Address1,Address2=@Address2,District=@District,State=@State,Country=@Country,ZIPPIN=@ZIPPIN,Website=@Website,email=@email,Telephone=@Telephone,ContactPerson=@ContactPerson,Mobile=@Mobile,Reference_Name=@Reference_Name,Naration=@Naration WHERE CustomerID=@CustomerID

While gridbing i contactenate the first name and lastname as name but while i going for update i have to split the name in to last name and first name for that i used split function

SQL

SELECT Item from dbo.SplitString(@Name, ' ')where ItemIndex=0

but when i assaigning into arguments @FirstName it showing the error

SQL

SELECT @FIRSTNAME=SELECT Item from dbo.SplitString(@Name, ' ')where ItemIndex=0

any body have idea

i need to split the name parameter based on space and assaign in to last name and first name.

any body have any idea.

Posted 6-Mar-14 23:15pm

Mohammed Shamsheer

Updated 6-Mar-14 23:19pm

phil.o

v2

Add a Solution

3 solutions

Solution 3

Create below split function

CREATE FUNCTION [dbo].[split](
          @delimited NVARCHAR(MAX),
          @delimiter NVARCHAR(100)
        ) RETURNS @t TABLE (id INT IDENTITY(1,1), val NVARCHAR(MAX))
        AS
        BEGIN
          DECLARE @xml XML
          SET @xml = N'<t>' + REPLACE(@delimited,@delimiter,'</t><t>') + '</t>'

          INSERT INTO @t(val)
          SELECT  r.value('.','varchar(MAX)') as item
          FROM  @xml.nodes('/t') as records(r)
          RETURN
        END

and rewrite your script as below

SET @FIRSTNAME= (select val from split(@Name,' ') where ID = 1)

SET @LASTNAME= (select val from split(@Name,' ') where ID = 2)

Thanks,
-RG

Posted 6-Mar-14 23:33pm

Ramug10

Updated 6-Mar-14 23:34pm

v2

Solution 2

You can try this link

http://www.aspdotnet-suresh.com/2013/07/sql-server-split-function-example-in.html[^]

Posted 6-Mar-14 23:22pm

Rahul_Pandit

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

SwarupDChavan · Accepted Answer · 2014-03-06T23:21:00

Solution 1

Just change

SQL

SELECT @FIRSTNAME=SELECT Item from dbo.SplitString(@Name, ' ')where ItemIndex=0

to

SQL

SELECT @FIRSTNAME= Item from dbo.SplitString(@Name, ' ')where ItemIndex=0

Posted 6-Mar-14 23:21pm

SwarupDChavan

Updated 6-Mar-14 23:38pm

v2