How can I fix my IF STATEMENT

Question

0.00/5 (No votes)

See more:

Hello, I am doing a conditional statement in javascript. When the user enters a value in the input box "Collect", its value together with the value from input box "CurBal" will perform an addition and put the answer in the input box named "Balance".

If the user enters a value in the input box "Deposit", its value will be substracted from the "CurBal" and the difference will also be reflected (supposedly) in the "Balance"

I have this code:

JavaScript

var collect = parseFloat(document.getElementById("Collect").value) ||0;
var dep     = parseFloat(document.getElementById("Deposit").value) ||0;
var curr    = parseFloat(document.getElementById("CurBal").value) ||0;
var bal     = document.getElementById("Balance");
						
	if (collect.value =! 0)
	{
          bal.value = (collect + curr).toFixed(2);
	}
						
	if (dep.value =! 0)
	{
	  bal.value = (curr - dep).toFixed(2);
	}

The HTML:

HTML

<tr>
   <td>  Collections: </td>
    <td>   <input  önchange="addNumbers()" type="text" id="Collect" name="Collect" value="" /> </td>
  </tr>
  
  <tr>
    <td>  Deposits: </td>
    <td>  <input  önchange="addNumbers()" type="text" id="Deposit" name="Deposit" value="" /> </td>
  </tr>
  
  <tr>
    <td>  Current Balance: </td>
    <td>  <input  önchange="addNumbers()" type="text" id="CurBal" name= "CurBal" value="<?php echo $all['balance']; ?>" readonly="readOnly" /> </td>
  </tr>

  <tr>
    <td>  Balance: </td>
    <td>  <input type="text" id="Balance" name="Balance" value="" readonly="readOnly" /> </td>
</tr>

But, its just performing the 2nd condition correctly. If I entered a value in the input box "Collect", it isn't adding the value from "CurBal", its just copying the value from "CurBal".

What should be removed or added or changed? Thank you for the help

Additional info: The user can only EITHER enter a value to "Collect" OR "Deposit".

Posted 12-Mar-14 19:15pm

bearhuggs

Updated 12-Mar-14 19:22pm

v5

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Snesh Prajapati · Answer 1 · 2014-03-12T21:21:00

I modified your code as given below. Hope may help you.

C#

function addNumbers() {

           var collect = parseFloat(document.getElementById("Collect").value) || 0;
           var dep = parseFloat(document.getElementById("Deposit").value) || 0;
           var curr = parseFloat(document.getElementById("CurBal").value);

           if (collect.value != 0) {
               var addbal = collect + curr;
               document.getElementById("Balance").value = addbal;
           }
       }

       function subNumbers() {

           var collect = parseFloat(document.getElementById("Collect").value) || 0;
           var dep = parseFloat(document.getElementById("Deposit").value) || 0;
           var curr = parseFloat(document.getElementById("CurBal").value);

           if (collect.value != 0) {
               var subbal = collect - dep;
               document.getElementById("Balance").value = subbal;
           }
       }

HTML code:

<tr>
           <td>Collections: </td>
           <td>
               <input  type="text" id="Collect" name="Collect"  />
           </td>
       </tr>
       <tr>
           <td>Deposits: </td>
           <td>
               <input  onchange="subNumbers()"  type="text" id="Deposit"          name="Deposit" />
           </td>
       </tr>
       <tr>
           <td>Current Balance: </td>
           <td>
               <input onchange="addNumbers()" type="text" id="CurBal" name="CurBal"  />
           </td>
       </tr>

       <tr>
           <td>Balance: </td>
           <td>
               <input type="text" id="Balance" name="Balance" readonly="readOnly" />
           </td>
       </tr>

Peter Leow · Answer 2 · 2014-03-12T22:47:00

Some mistakes in your code:
1. it should be != not =!
2. redundant

</td>

3. forgot to remove the php code which was supposed to get the current balance from somewhere (database?)
See the modified version below:

XML

<html>
<body>
<table>
<tr>
   <td>  Collections: </td>
    <td>   <input type="text" onchange="addNumbers()" id="Collect" name="Collect" value="0" />
  </tr>
  <tr>
    <td>  Deposits: </td>
    <td>  <input  onchange="addNumbers()" type="text" id="Deposit" name="Deposit" value="0" />
  </tr>
  <tr>
    <td>  Current Balance: </td>
    <td>  <input  type="text" id="CurBal" name= "CurBal" value="100" readonly="readonly" />
  </tr>
  <tr>
    <td>  Balance: </td>
    <td>  <input type="text" id="Balance" name="Balance" value="" />
</tr>
</table>
<script>
function addNumbers() {
  var collect = parseFloat(document.getElementById("Collect").value);
  var dep     = parseFloat(document.getElementById("Deposit").value);
  var curr    = parseFloat(document.getElementById("CurBal").value);
  var bal     = document.getElementById("Balance");

  bal.value = (collect + curr - dep).toFixed(2);
}
</script>
</body>
</html>

How can I fix my IF STATEMENT

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0