How Can I Reduce Code........

Question

0.00/5 (No votes)

See more:

SQL-Server-2008

Hi ,
anyone please give idea How can i reduce search code......

C#

private void cmdsearch_Click(object sender, EventArgs e)
        {
           
            
            if (comboBox1.Text=="Name")
            {
                SqlDataAdapter adp = new SqlDataAdapter("select * from test1 where name='" + textBox3.Text + "'", conn);

                DataTable tbl = new DataTable();
                adp.Fill(tbl);
                dataGridView1.DataSource = tbl;
              
            }
            else if (comboBox1.Text == "ID")
            {
                SqlDataAdapter adp = new SqlDataAdapter("select * from test1 where id='" + int.Parse(textBox3.Text) + "'", conn);
                DataTable tbl = new DataTable();
                adp.Fill(tbl);
                dataGridView1.DataSource = tbl;
              
            }
else if (comboBox1.Text == "Contactno")
            {
                SqlDataAdapter adp = new SqlDataAdapter("select * from test1 where contactno='" + textBox3.Text + "'", conn);
                DataTable tbl = new DataTable();
                adp.Fill(tbl);
                dataGridView1.DataSource = tbl;
              
            }
else if (comboBox1.Text == "Post")
            {
                SqlDataAdapter adp = new SqlDataAdapter("select * from test1 where post='" + textBox3.Text+ "'", conn);
                DataTable tbl = new DataTable();
                adp.Fill(tbl);
                dataGridView1.DataSource = tbl;
              
            }

Posted 24-Mar-14 1:43am

manish7664

Updated 24-Mar-14 1:45am

Kenneth Haugland

v2

Add a Solution

3 solutions

Solution 3

First off, Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.
Then it's pretty simple:

C#

private void cmdsearch_Click(object sender, EventArgs e)
    {
    switch (comboBox1.Text.ToLower())
        {
        case "name":
        case "id":
        case "contactno":
        case "post":
            SqlDataAdapter adp = new SqlDataAdapter("SELECT * FROM test1 WHERE " + comboBox1.Text + "=@PAR", conn);
            adp.SelectCommand.Parameters.AddWithValue("@PAR", textBox3.Text);
            DataTable tbl = new DataTable();
            adp.Fill(tbl);
            dataGridView1.DataSource = tbl;
            break;
        }
    }

Posted 24-Mar-14 1:55am

OriginalGriff

Updated 24-Mar-14 3:47am

v2

Comments

manish7664 24-Mar-14 9:24am

Thanks but it's not working

OriginalGriff 24-Mar-14 9:47am

That's a helpful error message!
What is it doing that you didn't expect, or not doing that you did?
What did you do to get those results?

OriginalGriff 24-Mar-14 9:48am

Hang on, hang on... try the modified version - I used textBox3 twice! :laugh:

Solution 1

declare string variable
string sql = string.empty;

put string inside the if block and assign the sql statement

Move the following lines outside.

C#

SqlDataAdapter adp = new SqlDataAdapter(sql, conn);
DataTable tbl = new DataTable();
adp.Fill(tbl);
dataGridView1.DataSource = tbl;

Posted 24-Mar-14 1:52am

ArunRajendra

Comments

manish7664 24-Mar-14 8:29am

Mr Arun Thanks for reply. but if i used sqldataadpter adp= new data... outside
then one error coming.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Raul Iloc · Accepted Answer · 2014-03-24T01:53:00

Solution 2

Should be like this:

C#

private void cmdsearch_Click(object sender, EventArgs e)
{
SqlDataAdapter adp = new SqlDataAdapter(string.Format("select * from test1 where {0}='{1}'", comboBox1.Text, textBox3.Text), conn);
//
DataTable tbl = new DataTable();
adp.Fill(tbl);
dataGridView1.DataSource = tbl;
}

Posted 24-Mar-14 1:53am

Raul Iloc

Updated 24-Mar-14 1:55am

v2

Comments

manish7664 24-Mar-14 8:15am

where {0}='{1}'" could you please explain..

Raul Iloc 24-Mar-14 8:19am

In my code there is a string.Format() used to create the SQL, and this format method has two parameters placeholders {0} and {1}; the value of comboBox1.Text and textBox3.Text will replace these two placeholders in the string.

Raul Iloc 24-Mar-14 8:30am

So did you try my solution?

Raul Iloc 24-Mar-14 8:40am

The code from my solution is from your posting.
It seems that for you is not cleat the string.Format(), so please have a look in Help/MSDN/Google for some example with string.Format() and should be more clear for you.

manish7664 26-Mar-14 9:35am

Mr Raul . i need your help.
i have two form.in first form have two textbox and one find button and second form have one datagrid.
i want when i click form 1 find button then form 2 datagrid open and if i click any perticular datagrid records cell then selected record show in form 1 textbox
i use below code but not working .

// Form 1

private void cmdfind_Click(object sender, EventArgs e)
{
Form2 form2 = new Form2();
form2.Show();

}
//Form 2

private void dataGridView1_CellContentClick_1(object sender, DataGridViewCellEventArgs e)
{
Form2 form2 = new Form2();
DataGridViewRow row = dataGridView1.Rows[e.RowIndex];
form2.textBox1.Text = row.Cells[0].Value.ToString();
form2.textBox2.Text = row.Cells[1].Value.ToString();
}

Raul Iloc 26-Mar-14 9:43am

Should be like this:

// Form 1
private void cmdfind_Click(object sender, EventArgs e)
{
Form2 form2 = new Form2();
this.Hide(); //Hide the current form (Form1)!
form2.Show();
this.Close();// Close Form1!
}
//Form 2
private void dataGridView1_CellContentClick_1(object sender, DataGridViewCellEventArgs e)
{
Form1 form1 = new Form1(); //Here was you bigger error, you used Form2!
DataGridViewRow row = dataGridView1.Rows[e.RowIndex];
form1.textBox1.Text = row.Cells[0].Value.ToString();
form1.textBox2.Text = row.Cells[1].Value.ToString();
this.Hide(); // Hide the current form (Form2)!
form1.Show();
this.Close();// Close Form2!
}

manish7664 26-Mar-14 10:01am

Thanks you so much.....

Raul Iloc 26-Mar-14 10:03am

Welcome! Now you should give me some 5+ votes... :)

manish7664 2-Apr-14 8:21am

i want to change the text box values according to the combo box selection.
below code Execute fine but when i select id from combobox then "System.Data.DataRowView" show in textbox instead of database value.
could you please help me what's wrong in my code....

private void comboBox1_SelectedIndexChanged(object sender, EventArgs e)
{
SqlConnection conn = new SqlConnection(@"Data Source=MANISH-PC\SQLEXPRESS;Initial Catalog=test2.mdf;Integrated Security=True");
conn.Open();
SqlCommand command = new SqlCommand("select name from table1 where id=@id", conn);
int comboxchoice;
Int32.TryParse(comboBox1.SelectedItem.ToString(), out comboxchoice);
command.Parameters.AddWithValue("@id", comboxchoice);
SqlDataAdapter adp = new SqlDataAdapter(command);
DataSet ds = new DataSet();
adp.Fill(ds, "table1");
textBox1.Text = comboBox1.SelectedValue.ToString();
}

Raul Iloc 2-Apr-14 8:33am

You should do: "textBox1.Text = comboBox1.Text;"

manish7664 2-Apr-14 8:45am

if i do so then what value i select from combox same value showing in taxtbox.
i want if i select 1 then manish (Column Value) should show in textbox.