Windows Application with Globalization

Question

0.00/5 (No votes)

See more:

Hello team,

I am creating one Windows application that is going to be use by India & Netherland users.
Application is working fine in India - users machine.
But when Netherland users trying to Insert Data into database...Program giving me error.

My Qyery is -

INSERT INTO tbl fld1,fld2,fld3 values ("+val1.Text+","+val2.Text+","+val3.Text+")

Value is fld1 = "10,000.00"

Value is fld2 = "20,000.00"

Value is fld3 = "30,000.00"

Here problem is due to comma, comma is treated as field seperater...

Please suggest me approve so that we have handle this problem.

Thanks,
Pravin Karne

Posted 23-Apr-14 2:20am

Pravinkarne.31

Add a Solution

3 solutions

Solution 1

have you used parameters for SQLCommand class?
if not check by inserting value through parameters

Posted 23-Apr-14 2:29am

Brahmmam

Comments

Pravinkarne.31 5-May-14 8:35am

Good idea but when I required to insert around 35-40 fields, Then this will be too-long cut

Brahmmam 6-May-14 1:11am

That is not a problem if you have 35-40 fields and Security will be high if you use parameters in your query.

Solution 2

The proper way to do it is to use parameters. Right now, your database is open to SQL injection attacks.

Do something like this:

SQL

cmd.CommandText = "INSERT INTO tbl (fld1,fld2,fld3) VALUES (@val1, @val2, @val3)";
cmd.Parameters.AddWithValue("@val1", val1.Text);
...

Posted 23-Apr-14 2:38am

ZurdoDev

Comments

Pravinkarne.31 5-May-14 8:34am

Good idea but when I required to insert around 35-40 fields, Then this will be too-long cut

ZurdoDev 5-May-14 8:38am

Regardless of how many you have, you never want to jeopardize security just because it might save you a few lines of code. I have stored procedures that take 30+ parameters so there is nothing unreasonable about doing it the right way.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

DamithSL · Accepted Answer · 2014-04-23T03:07:00

use parameters like below

C#

int val1 = int.Parse(val1.Text, NumberStyles.AllowThousands);
int val2 = int.Parse(val2.Text, NumberStyles.AllowThousands);
int val3 = int.Parse(val3.Text, NumberStyles.AllowThousands);
cmd.CommandText = "INSERT INTO tbl (fld1,fld2,fld3) VALUES (@val1, @val2, @val3)";
cmd.Parameters.AddWithValue("@val1", val1);
cmd.Parameters.AddWithValue("@val1", val2);
cmd.Parameters.AddWithValue("@val1", val3);

if you have issue with int.parse method for inputs, you can try with int.TryParse

C#

int num;
if (int.TryParse(val1.Text, NumberStyles.AllowThousands,
                 CultureInfo.InvariantCulture, out num))
{
    // parse success
}