I am trying to upload multiple files .but it gives error @DocDatahas already been declared. Variable names must be unique within a query batch or stored procedure

Question

0.00/5 (No votes)

See more:

C#

if (gvAttachments.Rows.Count > 0)
          {
              string[] Records = Session["FileDetail"].ToString().Split('#');
              for (int i = 0; i <Records.Length; i++)
              {
                  string[] arrRecords = Records[i].Split(',');
                  string[] fileExtension = arrRecords[0].Split('.');
                  string documentType = string.Empty;
                  switch (fileExtension[1])
                  {
                      case : documentType = "application/pdf";
                          break;
                      case : documentType = "application/vnd.ms-excel";
                          break;
                      case : documentType = "application/vnd.ms-excel";
                          break;
                      case : documentType = "application/vnd.ms-word";
                          break;
                      case "docx": documentType = "application/vnd.ms-word";
                          break;
                      case "gif": documentType = "image/gif";
                          break;
                      case "png": documentType = "image/png";
                          break;
                      case "jpg": documentType = "image/jpg";
                          break;
                  }
                  string size = arrRecords[2];
                  int fileSize = Convert.ToInt32(size);
                  byte[] documentbinary = new byte[fileSize];
                  fuUpload.PostedFile.InputStream.Read(documentbinary, 0, fileSize);
                  string file = arrRecords[0].ToString();
                  string format = documentType.ToString();
                  cmd.CommandText = "Insert into Attachment(File_Name,File_Format,File_Content,User_Notice_Mapping_ID) values('" + file + "','" + format + "',@DocData," + userNoticeID + ")";
                  cmd.CommandType = CommandType.Text;
                  cmd.Connection = con;
                  cmd.Parameters.Add("@DocData", SqlDbType.VarBinary, fileSize);
                  cmd.Parameters["@DocData"].Value = documentbinary;
                  cmd.ExecuteNonQuery();
                  String msg = "Your message has been Sent Successfully";
                  ShowAlert(msg, true);
              }
          }

Posted 24-Apr-14 20:38pm

Neha Mukesh

Updated 24-Apr-14 20:48pm

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Raul Iloc · Accepted Answer · 2014-04-24T21:13:00

1.Your problem is that your are using the same SqlCommand object for all items of your for, so the command object already have the parameter after its first iteration.

2.The solution is to create the SqlCommand object local inside the for:

C#

for (int i = 0; i <Records.Length; i++)
              {
                  string[] arrRecords = Records[i].Split(',');
                  string[] fileExtension = arrRecords[0].Split('.');
                  string documentType = string.Empty;
                  switch (fileExtension[1])
                  {
                      case : documentType = "application/pdf";
                          break;
                      case : documentType = "application/vnd.ms-excel";
                          break;
                      case : documentType = "application/vnd.ms-excel";
                          break;
                      case : documentType = "application/vnd.ms-word";
                          break;
                      case "docx": documentType = "application/vnd.ms-word";
                          break;
                      case "gif": documentType = "image/gif";
                          break;
                      case "png": documentType = "image/png";
                          break;
                      case "jpg": documentType = "image/jpg";
                          break;
                  }
                  string size = arrRecords[2];
                  int fileSize = Convert.ToInt32(size);
                  byte[] documentbinary = new byte[fileSize];
                  fuUpload.PostedFile.InputStream.Read(documentbinary, 0, fileSize);
                  string file = arrRecords[0].ToString();
                  string format = documentType.ToString();
                  //
                  cmd = new SqlCommand(); //Must be a new SqlCommand for each item! 
                  // 
                  cmd.CommandText = "Insert into Attachment(File_Name,File_Format,File_Content,User_Notice_Mapping_ID) values('" + file + "','" + format + "',@DocData," + userNoticeID + ")";
                  cmd.CommandType = CommandType.Text;
                  cmd.Connection = con;
                  cmd.Parameters.Add("@DocData", SqlDbType.VarBinary, fileSize);
                  cmd.Parameters["@DocData"].Value = documentbinary;
                  cmd.ExecuteNonQuery();
                  String msg = "Your message has been Sent Successfully";
                  ShowAlert(msg, true);
              }