Getting the largest number from each of the 2 arrays

Question

0.00/5 (No votes)

See more:

In my self study of Java, I'm trying to get the largest number from each of the 2 arrays

I don't know why the following output is being executed:

VB

Largest: 3
Largest: 8
Largest: 9
Largest: 23
Largest: 33
Largest: 41
Largest: 51

The correct output should be:

Java

Largest: 23
Largest: 51

How could the following code get the largest number? Because (getLargest1[i] > largest) is equal to getLargest1[i] > 0, which largest = 0.

Why should largest = getLargest1[i];?

C#

public class MyProgram
{
    public void start()
    {
        int[] getLargest1 = {3, 8, 4, 9, 5, 5, 23, 14};
        int[] getLargest2 = {33, 23, 41, 9, 17, 51, 23, 45};
        getLargestFunc(getLargest1, getLargest2);
    }

    private void getLargestFunc(int[] getLargest1, int[] getLargest2)
    {
        int largest = 0;

        for (int i = 0; i < getLargest1.length; i++)
        {
            if (getLargest1[i] > largest)
            {
                largest = getLargest1[i];
                System.out.println("Largest: " + largest);
            }
        }

        for (int i = 0; i < getLargest2.length; i++)
        {
            if (getLargest2[i] > largest)
            {
                largest = getLargest2[i];
                System.out.println("Largest: " + largest);
            }
        }
    }
}

Posted 10-Jul-14 23:23pm

Member 10925581

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

TorstenH. · Accepted Answer · 2014-07-11T01:01:00

Your ddea is good, that code is working correctly.

if (getLargest1[i] > largest)
is a comparison. You are comparing the next number to the yet found biggest number.

largest = getLargest1[i];
is an assignment when you've found a number, that is bigger than the so far found biggest number.

You should move the output behind the loops, so you'd get only the desired output:

Java

public class MyProgram
{
    public static void main(String[] args) 
    {
        new MyProgram().start();
    }
	
    public void start()
    {
        int[] getLargest1 = {3, 8, 4, 9, 5, 5, 23, 14};
        int[] getLargest2 = {33, 23, 41, 9, 17, 51, 23, 45};
        getLargestFunc(getLargest1, getLargest2);
    }
 
    private void getLargestFunc(int[] getLargest1, int[] getLargest2)
    {
        int largest = 0;
 
        for (int i = 0; i < getLargest1.length; i++)
        {
            if (getLargest1[i] > largest)
            {
                largest = getLargest1[i];
            }
        }
        System.out.println("Largest: " + largest);
 
        for (int i = 0; i < getLargest2.length; i++)
        {
            if (getLargest2[i] > largest)
            {
                largest = getLargest2[i];
            }
        }
        System.out.println("Largest: " + largest);
    }
}